Fix formatters for BinaryNinja::Confidence

saagarjha · CouleeApps · commit 92b817b784d2 · 2024-01-05T13:25:39.000-05:00
diff --git a/binaryninjaapi.h b/binaryninjaapi.h
@@ -16350,8 +16350,7 @@ template<typename T> struct fmt::formatter<BinaryNinja::Confidence<T>>
 {
 	format_context::iterator format(const BinaryNinja::Confidence<T>& obj, format_context& ctx) const
 	{
-		fmt::formatter<T>().format(obj.GetValue(), ctx);
-		return fmt::format_to(ctx.out(), " ({} confidence)", ctx);
+		return fmt::format_to(ctx.out(), "{} ({} confidence)", obj.GetValue(), obj.GetConfidence());
 	}
 	constexpr auto parse(format_parse_context& ctx) -> format_parse_context::iterator { return ctx.begin(); }
 };
@@ -16360,8 +16359,7 @@ template<typename T> struct fmt::formatter<BinaryNinja::Confidence<BinaryNinja::
 {
 	format_context::iterator format(const BinaryNinja::Confidence<BinaryNinja::Ref<T>>& obj, format_context& ctx) const
 	{
-		fmt::formatter<T>().format(*obj.GetValue().GetPtr(), ctx);
-		return fmt::format_to(ctx.out(), " ({} confidence)", ctx);
+		return fmt::format_to(ctx.out(), "{} ({} confidence)", *obj.GetValue().GetPtr(), obj.GetConfidence());
 	}
 	constexpr auto parse(format_parse_context& ctx) -> format_parse_context::iterator { return ctx.begin(); }
 };

Original file line number	Diff line number	Diff line change
`@@ -16350,8 +16350,7 @@ template<typename T> struct fmt::formatter<BinaryNinja::Confidence<T>>`
`16350`	`16350`	`{`
`16351`	`16351`	`format_context::iterator format(const BinaryNinja::Confidence<T>& obj, format_context& ctx) const`
`16352`	`16352`	`{`
`16353`		`- fmt::formatter<T>().format(obj.GetValue(), ctx);`
`16354`		`- return fmt::format_to(ctx.out(), " ({} confidence)", ctx);`
	`16353`	`+ return fmt::format_to(ctx.out(), "{} ({} confidence)", obj.GetValue(), obj.GetConfidence());`
`16355`	`16354`	`}`
`16356`	`16355`	`constexpr auto parse(format_parse_context& ctx) -> format_parse_context::iterator { return ctx.begin(); }`
`16357`	`16356`	`};`
`@@ -16360,8 +16359,7 @@ template<typename T> struct fmt::formatter<BinaryNinja::Confidence<BinaryNinja::`
`16360`	`16359`	`{`
`16361`	`16360`	`format_context::iterator format(const BinaryNinja::Confidence<BinaryNinja::Ref<T>>& obj, format_context& ctx) const`
`16362`	`16361`	`{`
`16363`		`- fmt::formatter<T>().format(*obj.GetValue().GetPtr(), ctx);`
`16364`		`- return fmt::format_to(ctx.out(), " ({} confidence)", ctx);`
	`16362`	`+ return fmt::format_to(ctx.out(), "{} ({} confidence)", *obj.GetValue().GetPtr(), obj.GetConfidence());`
`16365`	`16363`	`}`
`16366`	`16364`	`constexpr auto parse(format_parse_context& ctx) -> format_parse_context::iterator { return ctx.begin(); }`
`16367`	`16365`	`};`