[SharedCache] Move plugin_rpath calls into BN_INTERNAL_BUILD blocks

These calls set the rpaths used for release builds of the dylibs using a
macro that isn't available in the API repository. They are not necessary
when building the shared cache plug-in outside of the context of the
app.

Author: bdash

view/kernelcache/CMakeLists.txt

@@ -47,6 +47,7 @@ if(BN_INTERNAL_BUILD)
     set_target_properties(kernelcache PROPERTIES
             LIBRARY_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR}
             RUNTIME_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR})
+    plugin_rpath(kernelcache)
 else()
     set_target_properties(kernelcache PROPERTIES
             LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/out/plugins
@@ -66,7 +67,6 @@ target_include_directories(kernelcache PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMA
 
 target_link_libraries(kernelcache PUBLIC kernelcacheapi binaryninjaapi kernelcachecore) # kernelcacheworkflow)
 
-plugin_rpath(kernelcache)
 
 
 set(COMPILE_DEFS "")

view/kernelcache/ui/CMakeLists.txt

@@ -45,6 +45,7 @@ if(BN_INTERNAL_BUILD)
     set_target_properties(kernelcacheui PROPERTIES
             LIBRARY_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR}
             RUNTIME_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR})
+    ui_plugin_rpath(kernelcacheui)
 else()
     set_target_properties(kernelcacheui PROPERTIES
             LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/out/plugins
@@ -93,5 +94,4 @@ target_include_directories(kernelcacheui PRIVATE ${INCLUDES})
 
 target_link_libraries(kernelcacheui kernelcacheapi kernelcache binaryninjaui Qt6::Core Qt6::Gui Qt6::Widgets)
 
-ui_plugin_rpath(kernelcacheui)
 

view/sharedcache/CMakeLists.txt

@@ -48,6 +48,7 @@ if(BN_INTERNAL_BUILD)
     set_target_properties(sharedcache PROPERTIES
             LIBRARY_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR}
             RUNTIME_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR})
+    plugin_rpath(sharedcache)
 else()
     set_target_properties(sharedcache PROPERTIES
             LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/out/plugins
@@ -68,9 +69,6 @@ target_include_directories(sharedcache PRIVATE ${CMAKE_CURRENT_SOURCE_DIR} ${CMA
 
 target_link_libraries(sharedcache PUBLIC sharedcacheapi binaryninjaapi sharedcachecore sharedcacheworkflow)
 
-plugin_rpath(sharedcache)
-
-
 set(COMPILE_DEFS "")
 
 if (HARD_FAIL_MODE)

view/sharedcache/ui/CMakeLists.txt

@@ -45,6 +45,7 @@ if(BN_INTERNAL_BUILD)
     set_target_properties(sharedcacheui PROPERTIES
             LIBRARY_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR}
             RUNTIME_OUTPUT_DIRECTORY ${BN_CORE_PLUGIN_DIR})
+    ui_plugin_rpath(sharedcacheui)
 else()
     set_target_properties(sharedcacheui PROPERTIES
             LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/out/plugins
@@ -94,5 +95,4 @@ target_include_directories(sharedcacheui PRIVATE ${INCLUDES})
 
 target_link_libraries(sharedcacheui sharedcacheapi sharedcache binaryninjaui Qt6::Core Qt6::Gui Qt6::Widgets)
 
-ui_plugin_rpath(sharedcacheui)