[ObjC] Fix an off-by-one error that would skip inlining of the first objc_msgSend stub

bdash · bdash · commit b34d6b8b9e13 · 2025-07-13T10:08:42.000-07:00
diff --git a/plugins/workflow_objc/Workflow.cpp b/plugins/workflow_objc/Workflow.cpp
@@ -225,7 +225,7 @@ void Workflow::inlineMethodCalls(AnalysisContextRef ac)
 
     if (auto info = GlobalState::analysisInfo(bv))
     {
-        if (info->hasObjcStubs && func->GetStart() > info->objcStubsStartEnd.first && func->GetStart() < info->objcStubsStartEnd.second)
+        if (info->hasObjcStubs && func->GetStart() >= info->objcStubsStartEnd.first && func->GetStart() < info->objcStubsStartEnd.second)
         {
             func->SetAutoInlinedDuringAnalysis({true, BN_FULL_CONFIDENCE});
             // Do no further cleanup, this is a stub and it will be cleaned up after inlining

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ void Workflow::inlineMethodCalls(AnalysisContextRef ac)`
`225`	`225`
`226`	`226`	`if (auto info = GlobalState::analysisInfo(bv))`
`227`	`227`	`{`
`228`		`- if (info->hasObjcStubs && func->GetStart() > info->objcStubsStartEnd.first && func->GetStart() < info->objcStubsStartEnd.second)`
	`228`	`+ if (info->hasObjcStubs && func->GetStart() >= info->objcStubsStartEnd.first && func->GetStart() < info->objcStubsStartEnd.second)`
`229`	`229`	`{`
`230`	`230`	`func->SetAutoInlinedDuringAnalysis({true, BN_FULL_CONFIDENCE});`
`231`	`231`	`// Do no further cleanup, this is a stub and it will be cleaned up after inlining`