WIP: Attempt to appease the nondeterminism gods

Author: emesare

plugins/warp/src/cache/guid.rs

@@ -49,7 +49,7 @@ where
     // TODO: Implied constraints, symbol name, image offset
     let cs_constraints = cached_call_site_constraints(function);
     let adj_constraints = cached_adjacency_constraints(function, filter);
-    cs_constraints.union(&adj_constraints).cloned().collect()
+    cs_constraints.union(&adj_constraints).copied().collect()
 }
 
 pub fn cached_call_site_constraints(function: &BNFunction) -> HashSet<Constraint> {
@@ -151,7 +151,9 @@ impl ConstraintBuilder {
         offset: i64,
     ) -> Vec<Constraint> {
         let mut constraints = vec![];
-        if let Some(guid) = try_cached_function_guid(function) {
+        // NOTE: Previously we only queried the GUID if it was cached, however, this caused issues with
+        // functions that were not analyzed yet. We now always query the GUID and cache it if it is not cached.
+        if let Some(guid) = cached_function_guid(function, || function.lifted_il_if_available()) {
             let guid_constraint = Constraint::from_function(&guid, Some(offset));
             constraints.push(guid_constraint);
         }