Fix memory leaks in Sections, Segments, Settings, ExternalLibrary, and BackgroundTask

Author: plafosse

binaryview.cpp

@@ -3835,7 +3835,7 @@ Ref<BackgroundTask> BinaryView::GetBackgroundAnalysisTask()
 	if (!task)
 		return nullptr;
 
-	return new BackgroundTask(BNNewBackgroundTaskReference(task));
+	return new BackgroundTask(task);
 }
 
 
@@ -4954,7 +4954,7 @@ Ref<Segment> BinaryView::GetSegmentAt(uint64_t addr)
 	if (!segment)
 		return nullptr;
 
-	return new Segment(BNNewSegmentReference(segment));
+	return new Segment(segment);
 }
 
 
@@ -5043,7 +5043,7 @@ Ref<Section> BinaryView::GetSectionByName(const string& name)
 {
 	BNSection* section = BNGetSectionByName(m_object, name.c_str());
 	if (section)
-		return new Section(BNNewSectionReference(section));
+		return new Section(section);
 	return nullptr;
 }
 
@@ -5386,7 +5386,7 @@ Ref<ExternalLibrary> BinaryView::AddExternalLibrary(const std::string& name, Ref
 	BNExternalLibrary* lib = BNBinaryViewAddExternalLibrary(m_object, name.c_str(), backingFile ? backingFile->m_object : nullptr, isAuto);
 	if (!lib)
 		return nullptr;
-	return new ExternalLibrary(BNNewExternalLibraryReference(lib));
+	return new ExternalLibrary(lib);
 }
 
 

externallibrary.cpp

@@ -92,7 +92,7 @@ Ref<ExternalLibrary> ExternalLocation::GetExternalLibrary()
 	BNExternalLibrary* lib = BNExternalLocationGetExternalLibrary(m_object);
 	if (!lib)
 		return nullptr;
-	return new ExternalLibrary(BNNewExternalLibraryReference(lib));
+	return new ExternalLibrary(lib);
 }
 
 

python/binaryview.py

@@ -9545,9 +9545,7 @@ def get_segment_at(self, addr: int) -> Optional[Segment]:
 		seg = core.BNGetSegmentAt(self.handle, addr)
 		if not seg:
 			return None
-		segment_handle = core.BNNewSegmentReference(seg)
-		assert segment_handle is not None, "core.BNNewSegmentReference returned None"
-		return Segment(segment_handle)
+		return Segment(seg)
 
 	def get_address_for_data_offset(self, offset: int) -> Optional[int]:
 		"""
@@ -9639,9 +9637,7 @@ def get_section_by_name(self, name: str) -> Optional[Section]:
 		section = core.BNGetSectionByName(self.handle, name)
 		if section is None:
 			return None
-		section_handle = core.BNNewSectionReference(section)
-		assert section_handle is not None, "core.BNNewSectionReference returned None"
-		result = Section(section_handle)
+		result = Section(section)
 		return result
 
 	def get_unique_section_names(self, name_list: List[str]) -> List[str]:

settings.cpp

@@ -7,7 +7,7 @@ using namespace std;
 
 Settings::Settings(BNSettings* settings)
 {
-	m_object = BNNewSettingsReference(settings);
+	m_object = settings;
 }