Misc python fixes

Fixes #6655
Fixes #6654
Fixes #6653

https://i.imgflip.com/5llikl.png

Author: emesare

python/binaryview.py

@@ -9726,7 +9726,7 @@ def set_comment_at(self, addr: int, comment: str) -> None:
 			>>> bv.set_comment_at(here, "hi")
 
 		"""
-		core.BNSetGlobalCommentForAddress(self.handle, addr, comment)
+		core.BNSetGlobalCommentForAddress(self.handle, addr, str(comment))
 
 	@property
 	def debug_info(self) -> "debuginfo.DebugInfo":
@@ -9766,7 +9766,7 @@ def query_metadata(self, key: str) -> 'metadata.MetadataValueType':
 			>>> bv.query_metadata("string")
 			'my_data'
 		"""
-		md_handle = core.BNBinaryViewQueryMetadata(self.handle, key)
+		md_handle = core.BNBinaryViewQueryMetadata(self.handle, str(key))
 		if md_handle is None:
 			raise KeyError(key)
 		return metadata.Metadata(handle=md_handle).value
@@ -9802,7 +9802,7 @@ def store_metadata(self, key: str, md: metadata.MetadataValueType, isAuto: bool
 		_md = md
 		if not isinstance(_md, metadata.Metadata):
 			_md = metadata.Metadata(_md)
-		core.BNBinaryViewStoreMetadata(self.handle, key, _md.handle, isAuto)
+		core.BNBinaryViewStoreMetadata(self.handle, str(key), _md.handle, isAuto)
 
 	def remove_metadata(self, key: str) -> None:
 		"""
@@ -9815,7 +9815,7 @@ def remove_metadata(self, key: str) -> None:
 			>>> bv.store_metadata("integer", 1337)
 			>>> bv.remove_metadata("integer")
 		"""
-		core.BNBinaryViewRemoveMetadata(self.handle, key)
+		core.BNBinaryViewRemoveMetadata(self.handle, str(key))
 
 	@property
 	def metadata(self) -> Dict[str, 'metadata.MetadataValueType']:
@@ -9878,7 +9878,7 @@ def get_load_settings(self, type_name: str) -> Optional[settings.Settings]:
 		:return: the load settings
 		:rtype: :py:class:`~binaryninja.settings.Settings`, or ``None``
 		"""
-		settings_handle = core.BNBinaryViewGetLoadSettings(self.handle, type_name)
+		settings_handle = core.BNBinaryViewGetLoadSettings(self.handle, str(type_name))
 		if settings_handle is None:
 			return None
 		return settings.Settings(handle=settings_handle)
@@ -9893,7 +9893,7 @@ def set_load_settings(self, type_name: str, settings: Optional[settings.Settings
 		"""
 		if settings is not None:
 			settings = settings.handle
-		core.BNBinaryViewSetLoadSettings(self.handle, type_name, settings)
+		core.BNBinaryViewSetLoadSettings(self.handle, str(type_name), settings)
 
 	def parse_expression(self, expression: str, here: int = 0) -> int:
 		r"""

python/database.py

@@ -333,23 +333,23 @@ def globals(self) -> Dict[str, str]:
 
 	def read_global(self, key: str) -> str:
 		"""Get a specific global by key"""
-		value = core.BNReadDatabaseGlobal(self.handle, key)
+		value = core.BNReadDatabaseGlobal(self.handle, str(key))
 		assert value is not None
 		return value
 
 	def write_global(self, key: str, value: str):
 		"""Write a global into the database"""
-		core.BNWriteDatabaseGlobal(self.handle, key, value)
+		core.BNWriteDatabaseGlobal(self.handle, str(key), str(value))
 
 	def read_global_data(self, key: str) -> databuffer.DataBuffer:
 		"""Get a specific global by key, as a binary buffer"""
-		handle = core.BNReadDatabaseGlobalData(self.handle, key)
+		handle = core.BNReadDatabaseGlobalData(self.handle, str(key))
 		assert handle is not None
 		return databuffer.DataBuffer(handle=handle)
 
 	def write_global_data(self, key: str, value: databuffer.DataBuffer):
 		"""Write a binary buffer into a global in the database"""
-		core.BNWriteDatabaseGlobalData(self.handle, key, value.handle)
+		core.BNWriteDatabaseGlobalData(self.handle, str(key), value.handle)
 
 	@property
 	def file(self) -> 'filemetadata.FileMetadata':

python/project.py

@@ -139,7 +139,7 @@ def name(self, new_name: str) -> bool:
 
 		:param new_name: Desired name
 		"""
-		return core.BNProjectFileSetName(self._handle, new_name)
+		return core.BNProjectFileSetName(self._handle, str(new_name))
 
 	@property
 	def description(self) -> str:
@@ -157,7 +157,7 @@ def description(self, new_description: str) -> bool:
 
 		:param new_description: Desired description
 		"""
-		return core.BNProjectFileSetDescription(self._handle, new_description)
+		return core.BNProjectFileSetDescription(self._handle, str(new_description))
 
 	@property
 	def folder(self) -> Optional['ProjectFolder']:
@@ -257,7 +257,7 @@ def name(self, new_name: str) -> bool:
 
 		:param new_name: Desired name
 		"""
-		return core.BNProjectFolderSetName(self._handle, new_name)
+		return core.BNProjectFolderSetName(self._handle, str(new_name))
 
 	@property
 	def description(self) -> str:
@@ -275,7 +275,7 @@ def description(self, new_description: str) -> bool:
 
 		:param new_description: Desired description
 		"""
-		return core.BNProjectFolderSetDescription(self._handle, new_description)
+		return core.BNProjectFolderSetDescription(self._handle, str(new_description))
 
 	@property
 	def parent(self) -> Optional['ProjectFolder']:
@@ -353,7 +353,7 @@ def create_project(path: AsPath, name: str) -> 'Project':
 		:raises ProjectException: If there was an error creating the project
 		"""
 		binaryninja._init_plugins()
-		project_handle = core.BNCreateProject(str(path), name)
+		project_handle = core.BNCreateProject(str(path), str(name))
 		if project_handle is None:
 			raise ProjectException("Failed to create project")
 		return Project(handle=project_handle)
@@ -417,7 +417,7 @@ def name(self, new_name: str):
 
 		:param new_name: Desired name
 		"""
-		core.BNProjectSetName(self._handle, new_name)
+		core.BNProjectSetName(self._handle, str(new_name))
 
 	@property
 	def description(self) -> str:
@@ -435,15 +435,15 @@ def description(self, new_description: str):
 
 		:param new_description: Desired description
 		"""
-		core.BNProjectSetDescription(self._handle, new_description)
+		core.BNProjectSetDescription(self._handle, str(new_description))
 
 	def query_metadata(self, key: str) -> MetadataValueType:
 		"""
 		Retrieves metadata stored under a key from the project
 
 		:param str key: Key to query
 		"""
-		md_handle = core.BNProjectQueryMetadata(self._handle, key)
+		md_handle = core.BNProjectQueryMetadata(self._handle, str(key))
 		if md_handle is None:
 			raise KeyError(key)
 		return Metadata(handle=md_handle).value
@@ -458,15 +458,15 @@ def store_metadata(self, key: str, value: MetadataValueType):
 		_val = value
 		if not isinstance(_val, Metadata):
 			_val = Metadata(_val)
-		core.BNProjectStoreMetadata(self._handle, key, _val.handle)
+		core.BNProjectStoreMetadata(self._handle, str(key), _val.handle)
 
 	def remove_metadata(self, key: str):
 		"""
 		Removes the metadata associated with this key from the project
 
 		:param str key: Key associated with the metadata object to remove
 		"""
-		core.BNProjectRemoveMetadata(self._handle, key)
+		core.BNProjectRemoveMetadata(self._handle, str(key))
 
 	def create_folder_from_path(self, path: Union[PathLike, str], parent: Optional[ProjectFolder] = None, description: str = "", progress_func: ProgressFuncType = _nop) -> ProjectFolder:
 		"""
@@ -483,7 +483,7 @@ def create_folder_from_path(self, path: Union[PathLike, str], parent: Optional[P
 			project=self._handle,
 			path=str(path),
 			parent=parent_handle,
-			description=description,
+			description=str(description),
 			ctxt=None,
 			progress=_wrap_progress(progress_func)
 		)
@@ -506,8 +506,8 @@ def create_folder(self, parent: Optional[ProjectFolder], name: str, description:
 		folder_handle = core.BNProjectCreateFolder(
 			project=self._handle,
 			parent=parent_handle,
-			name=name,
-			description=description,
+			name=str(name),
+			description=str(description),
 		)
 
 		if folder_handle is None:
@@ -575,8 +575,8 @@ def create_file_from_path(self, path: AsPath, folder: Optional[ProjectFolder], n
 			project=self._handle,
 			path=str(path),
 			folder=folder_handle,
-			name=name,
-			description=description,
+			name=str(name),
+			description=str(description),
 			ctxt=None,
 			progress=_wrap_progress(progress_func)
 		)
@@ -596,6 +596,7 @@ def create_file(self, contents: bytes, folder: Optional[ProjectFolder], name: st
 		:param description: Description to assign to the created file
 		:param progress_func: Progress function that will be called as the file is being added
 		"""
+		description = description if description is not None else ""
 		folder_handle = folder._handle if folder is not None else None
 		buf = (ctypes.c_ubyte * len(contents))()
 		ctypes.memmove(buf, contents, len(contents))
@@ -604,8 +605,8 @@ def create_file(self, contents: bytes, folder: Optional[ProjectFolder], name: st
 			contents=buf,
 			contentsSize=len(contents),
 			folder=folder_handle,
-			name=name,
-			description=description,
+			name=str(name),
+			description=str(description),
 			ctxt=None,
 			progress=_wrap_progress(progress_func)
 		)
@@ -644,7 +645,7 @@ def get_file_by_id(self, id: str) -> Optional[ProjectFile]:
 		:param id: Unique identifier for a file
 		:return: File with the requested id or None
 		"""
-		handle = core.BNProjectGetFileById(self._handle, id)
+		handle = core.BNProjectGetFileById(self._handle, str(id))
 		if handle is None:
 			return None
 		file = ProjectFile(handle)