Allow overriding common loader settings when automatic load file parsing fails.

Author: bpotchik

view/elf/elfview.cpp

@@ -739,6 +739,9 @@ bool ElfView::Init()
 			m_logger->LogError("ELF architecture %d is not supported", m_commonHeader.arch);
 			break;
 		}
+
+		if (!m_parseOnly)
+			m_logger->LogWarn("Unable to determine architecture. Please open the file with options and select a valid architecture.");
 		return false;
 	}
 
@@ -2944,8 +2947,8 @@ Ref<Settings> ElfViewType::GetLoadSettingsForData(BinaryView* data)
 	Ref<BinaryView> viewRef = Parse(data);
 	if (!viewRef || !viewRef->Init())
 	{
-		m_logger->LogError("View type '%s' could not be created", GetName().c_str());
-		return nullptr;
+		m_logger->LogWarn("Failed to initialize view of type '%s'. Generating default load settings.", GetName().c_str());
+		viewRef = data;
 	}
 
 	Ref<Settings> settings = GetDefaultLoadSettingsForData(viewRef);

view/macho/machoview.cpp

@@ -3863,8 +3863,8 @@ Ref<Settings> MachoViewType::GetLoadSettingsForData(BinaryView* data)
 	Ref<BinaryView> viewRef = Parse(data);
 	if (!viewRef || !viewRef->Init())
 	{
-		m_logger->LogError("View type '%s' could not be created", GetName().c_str());
-		return nullptr;
+		m_logger->LogWarn("Failed to initialize view of type '%s'. Generating default load settings.", GetName().c_str());
+		viewRef = data;
 	}
 
 	Ref<Settings> settings = GetDefaultLoadSettingsForData(viewRef);

view/md1rom/md1rom.cpp

@@ -423,8 +423,8 @@ Ref<Settings> Md1romViewType::GetLoadSettingsForData(BinaryNinja::BinaryView* da
 	Ref<BinaryView> viewRef = Parse(data);
 	if (!viewRef || !viewRef->Init())
 	{
-		m_logger->LogError("View type '%s' could not be created", GetName().c_str());
-		return nullptr;
+		m_logger->LogWarn("Failed to initialize view of type '%s'. Generating default load settings.", GetName().c_str());
+		viewRef = data;
 	}
 
 	Ref<Settings> settings = GetDefaultLoadSettingsForData(viewRef);

view/pe/coffview.cpp

@@ -459,6 +459,10 @@ bool COFFView::Init()
 				m_logger->LogError("COFF architecture '0x%x' is not supported", header.machine);
 				break;
 			}
+
+			if (!m_parseOnly)
+				m_logger->LogWarn("Unable to determine architecture. Please open the file with options and select a valid architecture.");
+
 			return false;
 		}
 
@@ -1662,8 +1666,8 @@ Ref<Settings> COFFViewType::GetLoadSettingsForData(BinaryView* data)
 	Ref<BinaryView> viewRef = Parse(data);
 	if (!viewRef || !viewRef->Init())
 	{
-		m_logger->LogError("View type '%s' could not be created", GetName().c_str());
-		return nullptr;
+		m_logger->LogWarn("Failed to initialize view of type '%s'. Generating default load settings.", GetName().c_str());
+		viewRef = data;
 	}
 
 	Ref<Settings> settings = GetDefaultLoadSettingsForData(viewRef);

view/pe/peview.cpp

@@ -640,6 +640,10 @@ bool PEView::Init()
 				m_logger->LogError("PE architecture '0x%x' is not supported", header.machine);
 				break;
 			}
+
+			if (!m_parseOnly)
+				m_logger->LogWarn("Unable to determine architecture. Please open the file with options and select a valid architecture.");
+
 			return false;
 		}
 
@@ -3086,8 +3090,8 @@ Ref<Settings> PEViewType::GetLoadSettingsForData(BinaryView* data)
 	Ref<BinaryView> viewRef = Parse(data);
 	if (!viewRef || !viewRef->Init())
 	{
-		m_logger->LogError("View type '%s' could not be created", GetName().c_str());
-		return nullptr;
+		m_logger->LogWarn("Failed to initialize view of type '%s'. Generating default load settings.", GetName().c_str());
+		viewRef = data;
 	}
 
 	Ref<Settings> settings = GetDefaultLoadSettingsForData(viewRef);

view/pe/teview.cpp

@@ -257,16 +257,12 @@ bool TEView::Init()
 				break;
 			default:
 				LogError("TE platform '0x%x' is not supported", header.machine);
+				if (!m_parseOnly)
+					m_logger->LogWarn("Unable to determine architecture. Please open the file with options and select a valid architecture.");
 				return false;
 			}
 		}
 
-		if (!platform)
-		{
-			LogError("Platform not supported by this version of Binary Ninja");
-			return false;
-		}
-
 		m_arch = platform->GetArchitecture();
 		if (!m_arch)
 		{
@@ -371,13 +367,13 @@ bool TEViewType::IsTypeValidForData(BinaryView* bv)
 	return false;
 }
 
-Ref<Settings> TEViewType::GetLoadSettingsForData(BinaryView *bv)
+Ref<Settings> TEViewType::GetLoadSettingsForData(BinaryView* data)
 {
-	Ref<BinaryView> viewRef = Parse(bv);
+	Ref<BinaryView> viewRef = Parse(data);
 	if (!viewRef || !viewRef->Init())
 	{
-		m_logger->LogError("View type '%s' could not be created", GetName().c_str());
-		return nullptr;
+		m_logger->LogWarn("Failed to initialize view of type '%s'. Generating default load settings.", GetName().c_str());
+		viewRef = data;
 	}
 
 	// specify default load settings that can be overridden

view/sharedcache/core/DSCView.cpp

@@ -769,8 +769,8 @@ Ref<Settings> DSCViewType::GetLoadSettingsForData(BinaryView* data)
 	Ref<BinaryView> viewRef = Parse(data);
 	if (!viewRef || !viewRef->Init())
 	{
-		LogError("View type '%s' could not be created", GetName().c_str());
-		return nullptr;
+		LogWarn("Failed to initialize view of type '%s'. Generating default load settings.", GetName().c_str());
+		viewRef = data;
 	}
 
 	Ref<Settings> settings = GetDefaultLoadSettingsForData(viewRef);