Fix cxx20 build issue on Linux.

fuzyll · fuzyll · commit d7000347df9a · 2025-06-04T15:01:27.000-04:00
Apparently the compiler on macOS is less strict about this change?
diff --git a/view/sharedcache/core/refcountobject.h b/view/sharedcache/core/refcountobject.h
@@ -58,9 +58,9 @@ namespace BinaryNinja::DSC {
 #endif
 
 	public:
-		DSCRef<T>() : m_obj(NULL) {}
+		DSCRef() : m_obj(NULL) {}
 
-		DSCRef<T>(T* obj) : m_obj(obj)
+		DSCRef(T* obj) : m_obj(obj)
 		{
 			if (m_obj)
 			{
@@ -71,7 +71,7 @@ namespace BinaryNinja::DSC {
 			}
 		}
 
-		DSCRef<T>(const DSCRef<T>& obj) : m_obj(obj.m_obj)
+		DSCRef(const DSCRef& obj) : m_obj(obj.m_obj)
 		{
 			if (m_obj)
 			{
@@ -82,7 +82,7 @@ namespace BinaryNinja::DSC {
 			}
 		}
 
-		~DSCRef<T>()
+		~DSCRef()
 		{
 			if (m_obj)
 			{
@@ -94,7 +94,7 @@ namespace BinaryNinja::DSC {
 		}
 
 		// move constructor
-		DSCRef<T>(DSCRef<T>&& other) : m_obj(other.m_obj)
+		DSCRef(DSCRef&& other) : m_obj(other.m_obj)
 		{
 			other.m_obj = 0;
 #ifdef BN_REF_COUNT_DEBUG

Original file line number	Diff line number	Diff line change
`@@ -58,9 +58,9 @@ namespace BinaryNinja::DSC {`
`58`	`58`	`#endif`
`59`	`59`
`60`	`60`	`public:`
`61`		`- DSCRef<T>() : m_obj(NULL) {}`
	`61`	`+ DSCRef() : m_obj(NULL) {}`
`62`	`62`
`63`		`- DSCRef<T>(T* obj) : m_obj(obj)`
	`63`	`+ DSCRef(T* obj) : m_obj(obj)`
`64`	`64`	`{`
`65`	`65`	`if (m_obj)`
`66`	`66`	`{`
`@@ -71,7 +71,7 @@ namespace BinaryNinja::DSC {`
`71`	`71`	`}`
`72`	`72`	`}`
`73`	`73`
`74`		`- DSCRef<T>(const DSCRef<T>& obj) : m_obj(obj.m_obj)`
	`74`	`+ DSCRef(const DSCRef& obj) : m_obj(obj.m_obj)`
`75`	`75`	`{`
`76`	`76`	`if (m_obj)`
`77`	`77`	`{`
`@@ -82,7 +82,7 @@ namespace BinaryNinja::DSC {`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`
`85`		`- ~DSCRef<T>()`
	`85`	`+ ~DSCRef()`
`86`	`86`	`{`
`87`	`87`	`if (m_obj)`
`88`	`88`	`{`
`@@ -94,7 +94,7 @@ namespace BinaryNinja::DSC {`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`// move constructor`
`97`		`- DSCRef<T>(DSCRef<T>&& other) : m_obj(other.m_obj)`
	`97`	`+ DSCRef(DSCRef&& other) : m_obj(other.m_obj)`
`98`	`98`	`{`
`99`	`99`	`other.m_obj = 0;`
`100`	`100`	`#ifdef BN_REF_COUNT_DEBUG`