Fix TagType objects being leaked when opening tags sidebar

emesare · emesare · commit eb36a2b19746 · 2025-07-03T00:13:59.000-04:00
diff --git a/binaryninjacore.h b/binaryninjacore.h
@@ -5532,7 +5532,7 @@ extern "C"
 	BINARYNINJACOREAPI size_t BNGetAllTagReferencesOfTypeCount(BNBinaryView* view, BNTagType* tagType);
 	BINARYNINJACOREAPI void BNGetAllTagReferenceTypeCounts(
 	    BNBinaryView* view, BNTagType*** tagTypes, size_t** counts, size_t* count);
-	BINARYNINJACOREAPI void BNFreeTagReferenceTypeCounts(BNTagType** tagTypes, size_t* counts);
+	BINARYNINJACOREAPI void BNFreeTagReferenceTypeCounts(BNTagType** tagTypes, size_t* counts, size_t count);
 
 	BINARYNINJACOREAPI BNTagReference* BNGetFunctionAllTagReferences(BNFunction* func, size_t* count);
 	BINARYNINJACOREAPI BNTagReference* BNGetFunctionTagReferencesOfType(
diff --git a/binaryview.cpp b/binaryview.cpp
@@ -3373,7 +3373,7 @@ std::map<Ref<TagType>, size_t> BinaryView::GetAllTagReferenceTypeCounts()
 		result[new TagType(BNNewTagTypeReference(types[i]))] = counts[i];
 	}
 
-	BNFreeTagReferenceTypeCounts(types, counts);
+	BNFreeTagReferenceTypeCounts(types, counts, count);
 	return result;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3373,7 +3373,7 @@ std::map<Ref<TagType>, size_t> BinaryView::GetAllTagReferenceTypeCounts()`
`3373`	`3373`	`result[new TagType(BNNewTagTypeReference(types[i]))] = counts[i];`
`3374`	`3374`	`}`
`3375`	`3375`
`3376`		`- BNFreeTagReferenceTypeCounts(types, counts);`
	`3376`	`+ BNFreeTagReferenceTypeCounts(types, counts, count);`
`3377`	`3377`	`return result;`
`3378`	`3378`	`}`
`3379`	`3379`