Fix crash with invalid vtable info when processing MSVC vftables

emesare · emesare · commit f30b00d5e8d5 · 2025-05-21T09:23:32.000+02:00
Found when a vtable is constrained to a size less than the base vft, indicating a bad base vft associating most likely. Fixes #6840
diff --git a/plugins/rtti/microsoft.cpp b/plugins/rtti/microsoft.cpp
@@ -790,8 +790,8 @@ void MicrosoftRTTIProcessor::ProcessVFT()
         }
 
         vftFinished.insert(vftAddr);
-        auto vftInfo = ProcessVFT(vftAddr, classInfo, baseClassInfo);
-        classInfo.vft = vftInfo.value();
+        if (auto vftInfo = ProcessVFT(vftAddr, classInfo, baseClassInfo))
+            classInfo.vft = vftInfo.value();
     };
 
     size_t processedNum = 0;

Original file line number	Diff line number	Diff line change
`@@ -790,8 +790,8 @@ void MicrosoftRTTIProcessor::ProcessVFT()`
`790`	`790`	`}`
`791`	`791`
`792`	`792`	`vftFinished.insert(vftAddr);`
`793`		`- auto vftInfo = ProcessVFT(vftAddr, classInfo, baseClassInfo);`
`794`		`- classInfo.vft = vftInfo.value();`
	`793`	`+ if (auto vftInfo = ProcessVFT(vftAddr, classInfo, baseClassInfo))`
	`794`	`+ classInfo.vft = vftInfo.value();`
`795`	`795`	`};`
`796`	`796`
`797`	`797`	`size_t processedNum = 0;`