reimplement llil validation for caller_sites and implement plural IL forms on references

Author: psifertex

python/binaryview.py

@@ -125,18 +125,42 @@ def llil(self) -> Optional[lowlevelil.LowLevelILInstruction]:
 			return None
 		return self.function.get_low_level_il_at(self.address, self.arch)
 
+	@property
+	def llils(self) -> Iterator[lowlevelil.LowLevelILInstruction]:
+		"""Returns the low level il instructions at the current location if any exists"""
+		if self.function is None or self.arch is None:
+			return
+		return self.function.get_low_level_ils_at(self.address, self.arch)
+
 	@property
 	def mlil(self) -> Optional[mediumlevelil.MediumLevelILInstruction]:
 		"""Returns the medium level il instruction at the current location if one exists"""
 		llil = self.llil
 		return llil.mlil if llil is not None else None
 
+	@property
+	def mlils(self) -> Iterator[mediumlevelil.MediumLevelILInstruction]:
+		"""Returns the medium level il instructions at the current location if any exists"""
+		if self.function is None or self.arch is None:
+			return
+		for llil in self.llils:
+			for mlil in llil.mlils:
+				yield mlil
+
 	@property
 	def hlil(self) -> Optional[highlevelil.HighLevelILInstruction]:
 		"""Returns the high level il instruction at the current location if one exists"""
 		mlil = self.mlil
 		return mlil.hlil if mlil is not None else None
 
+	@property
+	def hlils(self) -> Iterator[highlevelil.HighLevelILInstruction]:
+		"""Returns the high level il instructions at the current location if any exists"""
+		if self.function is None or self.arch is None:
+			return
+		for llil in self.llils:
+			for hlil in llil.hlils:
+				yield hlil
 
 class NotificationType(IntFlag):
 	NotificationBarrier = 1 << 0

python/function.py

@@ -1863,6 +1863,38 @@ def get_low_level_il_at(
 
 		return llil[idx]
 
+	def get_low_level_ils_at(self, addr: int,
+	                 arch: Optional['architecture.Architecture'] = None) -> List['lowlevelil.LowLevelILInstruction']:
+		"""
+		``get_low_level_ils_at`` gets the LowLevelILInstruction(s) corresponding to the given virtual address
+		See the `developer docs <https://dev-docs.binary.ninja/dev/concepts.html#mapping-between-ils>`_ for more information.
+
+		:param int addr: virtual address of the instruction to be queried
+		:param Architecture arch: (optional) Architecture for the given function
+		:rtype: list(LowLevelILInstruction)
+		:Example:
+
+			>>> func = next(bv.functions)
+			>>> func.get_low_level_ils_at(func.start)
+			[<il: push(rbp)>]
+		"""
+		llil = self.llil
+		if llil is None:
+			return []
+
+		if arch is None:
+			arch = self.arch
+		count = ctypes.c_ulonglong()
+		instrs = core.BNGetLowLevelILInstructionsForAddress(self.handle, arch.handle, addr, count)
+		assert instrs is not None, "core.BNGetLowLevelILInstructionsForAddress returned None"
+		try:
+			result = []
+			for i in range(0, count.value):
+				result.append(llil[instrs[i]])
+			return result
+		finally:
+			core.BNFreeILInstructionList(instrs)
+
 	def get_llil_at(self, addr: int,
 	                arch: Optional['architecture.Architecture'] = None) -> Optional['lowlevelil.LowLevelILInstruction']:
 		"""
@@ -3265,8 +3297,9 @@ def caller_sites(self) -> Generator['binaryview.ReferenceSource', None, None]:
 		:rtype: list(ReferenceSource)
 		"""
 		for site in self.view.get_code_refs(self.start):
-			if isinstance(site.llil, Localcall):
-				yield site
+			for llil in site.llils:
+				if isinstance(llil, Localcall) and llil.dest.value == self.start:
+					yield site
 
 	@property
 	def workflow(self):