Merge https://github.com/Vector35/binaryninja-api into dev

Author: v1X3Q0

.github/ISSUE_TEMPLATE/bug_report.md

@@ -26,8 +26,17 @@ Please provide all steps required to reproduce the behavior:
 **Expected Behavior:**
 Please provide a clear and concise description of what you *expected* to happen.
 
-**Screenshots:**
-If applicable, please add screenshots here to help explain your problem.
+**Screenshots/Video Recording:**
+If applicable, please add screenshots/video recording here to help explain your problem.
+
+**Binary:**
+If applicable, please provide us with the binary to help us work with the issue faster. Here are a few options:
+
+1. Directly attach it to this issue in a ZIP archive
+2. Share a publicly accessible link to it (For malware samples, we do not have access to VirusTotal; [Malshare](https://malshare.com/) is an option)
+3. Email it to binaryninja at vector35.com, or join our [slack](https://slack.binary.ninja/) and share with us in private
+4. We understand sometimes it is not possible to share the binary -- sure, no worries, we can still work with it!
+5. If your issue is general and not related to a specific binary, then there is no need to attach the binary as well
 
 **Additional Information:**
 Please add any other context about the problem here.

.gitmodules

@@ -1,9 +1,6 @@
 [submodule "examples/x86_extension/src/asmx86"]
 	path = examples/x86_extension/src/asmx86
 	url = https://github.com/Vector35/asmx86.git
-[submodule "suite/binaries"]
-	path = suite/binaries
-	url = https://github.com/Vector35/BinaryTestCases.git
 [submodule "vendor/fmt"]
 	path = vendor/fmt
 	url = https://github.com/fmtlib/fmt.git

README.md

@@ -53,6 +53,7 @@ In addition to the default build setup, you may want to:
 
 There are many examples available. The [Python examples folder](https://github.com/Vector35/binaryninja-api/tree/dev/python/examples) demonstrates many different applications of the Python API, while C++ examples include:
 
+- [background_task](https://github.com/Vector35/binaryninja-api/tree/dev/examples/background_task) is a plugin that demonstrates managing a background task.\*
 - [bin-info](https://github.com/Vector35/binaryninja-api/tree/dev/examples/bin-info) is a standalone executable that prints some information about a given binary to the terminal.\*
 - [breakpoint](https://github.com/Vector35/binaryninja-api/tree/dev/examples/breakpoint) is a plugin that allows you to select a region within an x86 binary and use the context menu to fill it with breakpoint bytes.
 - [command-line disassm](https://github.com/Vector35/binaryninja-api/tree/dev/examples/cmdline_disasm) demonstrates how to dump disassembly to the command line.\*

arch/arm64/arch_arm64.cpp

@@ -2450,8 +2450,17 @@ class Arm64ImportedFunctionRecognizer : public FunctionRecognizer
 
 		Ref<Symbol> funcSym = Symbol::ImportedFunctionFromImportAddressSymbol(sym, func->GetStart());
 		data->DefineAutoSymbol(funcSym);
-		func->ApplyImportedTypes(funcSym);
-		return true;
+
+		auto extSym = data->GetSymbolsByName(funcSym->GetRawName(), data->GetExternalNameSpace());
+		if (!extSym.empty()) {
+			DataVariable var;
+			if (data->GetDataVariableAtAddress(extSym.front()->GetAddress(), var))
+			{
+				func->ApplyImportedTypes(funcSym, var.type);
+			}
+			return true;
+		}
+		return false;
 	}
 
 

arch/arm64/arm64test.py

@@ -366,6 +366,8 @@ const char *get_system_register_name(enum SystemReg sr)
 		case 50823: return "scxtnum_el1";
 		case 50952: return "cntkctl_el1";
 		case 53248: return "csselr_el1";
+		case 55297: return "ctr_el0";
+		case 55303: return "dczid_el0";
 		case 55824: return "nzcv";
 		case 55825: return "daifset";
 		case 55829: return "dit";
@@ -433,6 +435,7 @@ const char *get_system_register_name(enum SystemReg sr)
 		case 57086: return "amevtyper114_el0";
 		case 57087: return "amevtyper115_el0";
 		case 57088: return "cntfrq_el0";
+		case 57089: return "cntpct_el0";
 		case 57104: return "cntp_tval_el0";
 		case 57105: return "cntp_ctl_el0";
 		case 57106: return "cntp_cval_el0";

arch/arm64/disassembler/sysregs.c

@@ -361,6 +361,8 @@ enum SystemReg {
 	REG_SCXTNUM_EL1=50823,
 	REG_CNTKCTL_EL1=50952,
 	REG_CSSELR_EL1=53248,
+	REG_CTR_EL0=55297,
+	REG_DCZID_EL0=55303,
 	REG_NZCV=55824,
 	REG_DAIFSET=55825,
 	REG_DIT=55829,
@@ -428,6 +430,7 @@ enum SystemReg {
 	REG_AMEVTYPER114_EL0=57086,
 	REG_AMEVTYPER115_EL0=57087,
 	REG_CNTFRQ_EL0=57088,
+	REG_CNTPCT_EL0=57089,
 	REG_CNTP_TVAL_EL0=57104,
 	REG_CNTP_CTL_EL0=57105,
 	REG_CNTP_CVAL_EL0=57106,