[SharedCache] Make error about invalid metadata a warning, we recover sorta gracefully now

emesare · emesare · commit fe4a8b6c058d · 2025-03-08T12:54:36.000-05:00
diff --git a/view/sharedcache/core/SharedCache.cpp b/view/sharedcache/core/SharedCache.cpp
@@ -1455,7 +1455,7 @@ SharedCache::SharedCache(BinaryNinja::Ref<BinaryNinja::BinaryView> dscView) :
 		// TODO: We need a way to prompt the user and ask if they want to continue (like BNDB version upgrades)
 		// TODO: To do that we really need to consolidate _where_ SharedCache is called.
 		// TODO: Specifically the **first** call to this must originate in DSCView, which is NOT the case currently.
-		m_logger->LogError("Metadata was invalid, recreating initial load of shared cache information...");
+		m_logger->LogWarn("Metadata was invalid, recreating initial load of shared cache information...");
 	}
 
 	if (m_modifiedState->viewState.value_or(m_viewSpecificState->viewState) != DSCViewStateUnloaded)

Original file line number	Diff line number	Diff line change
`@@ -1455,7 +1455,7 @@ SharedCache::SharedCache(BinaryNinja::Ref<BinaryNinja::BinaryView> dscView) :`
`1455`	`1455`	`// TODO: We need a way to prompt the user and ask if they want to continue (like BNDB version upgrades)`
`1456`	`1456`	`// TODO: To do that we really need to consolidate _where_ SharedCache is called.`
`1457`	`1457`	`// TODO: Specifically the first call to this must originate in DSCView, which is NOT the case currently.`
`1458`		`- m_logger->LogError("Metadata was invalid, recreating initial load of shared cache information...");`
	`1458`	`+ m_logger->LogWarn("Metadata was invalid, recreating initial load of shared cache information...");`
`1459`	`1459`	`}`
`1460`	`1460`
`1461`	`1461`	`if (m_modifiedState->viewState.value_or(m_viewSpecificState->viewState) != DSCViewStateUnloaded)`