Types not being properly applied on initial analysis

[yrp604]

Version and Platform (required):

• Binary Ninja Version: 4603-dev
• OS: Windows
• OS Version: 11
• CPU Architecture: x64

Bug Description:
The function parameter for _guard_dispatch_icall is not applying on initial analysis

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

1. Open ntoskrnl.exe and load the pdb
2. Navigate to ExAllocateFromNPagedLookasideList
3. Select the _guard_dispatch_icall call and hit y
4. Hit enter, accepting the default
5. See the IL change/get updated

Expected Behavior:
If a function has a type signature, I expect it to be applied by default. Accepting a default value should not change the IL
 
Screenshots:
Before:

During:

After:

To be clear, I did not enter the type for _guard_dispatch_icall, binja was aware this was the type and was not applying it.

[xusheng6]

This is an interesting bug that we should seek to prioritize.

[plafosse]

So guard_dispatch_icall is special it is ultimately just a pass though to the function passed in the first parameter. The before in the image above is more correct than the after Whats happening here is that we're using heuristics to determine that all those parameters are being passed into _guard_dispatch_icall because they actually are, and this is more correct than _guard_dispatch_icall just taking a single function pointer parameter. So I don't believe there is a bug in this regard. However....

Ultimately you should never be seeing the calls to _guard_dispatch_icall as we're supposed to be re-writing them as calls to the first parameter. I've identified a bug causing us tom miss direct calls to _guard_dispatch_icall This will be fixed in 5.3.8657