Attempting to move non-project file tabs into project windows makes binja unresponsive/crashes

[droogie]

Version and Platform (required):

• Binary Ninja Version: Active version: 5.1.7910-dev commercial
• Edition: Commercial
• OS: Arch Linux
• OS Version: rolling, kernel 6.15.5-arch1-1
• CPU Architecture: x64

Bug Description:

I had two different scenarios where my binja windows became non responsive:

• Attempting to drag a tab from a window with an arbitrary file into a binja window with a project removed the original tab, added to project window and then both windows locked up and binja process crashed.

• I had an arbitrary file open in a window, i also had a binja window with a project open, on the project window I tried to open the same arbitrary file as the other window in a new tab, it spawned the tab in the non-project window and both windows locked up (possibly due to the same file being operated on twice?), I waited for awhile but then manually killed the process

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:
Case 1:

1. Open an arbitrary file in a binja window
2. Attempt to open a project file and it will spawn a new binja window for the project
3. Click and drag the original windows arbitrary file tab and drag it into the project window to move it there

Case 2:

1. Open an arbitrary file in a binja window
2. Attempt to open a project file and it will spawn a new binja window for the project
3. From the project window open the same file as the other window but via the file browser, it will spawn a second tab in the other window of the same file

Expected Behavior:
It is now my understanding that project related windows are kept separate, so for the time being the expected behavior is simply to not crash and handle these edge cases

Screenshots/Video Recording:
N/A

Binary:
N/A

Additional Information:
N/A

[negasora]

What window manager are you using?
Are you using X or wayland?
If wayland, is binja running under xwayland?

[droogie]

I'm using X

I just tried replicating the issue on 5.2.8161-dev commercial and it is no longer crashing for me. There's some minor cosmetic issues regarding the tabs themselves like disappearing and not reappearing until you try to add a new tab or something, but the actual issue of locking up the windows and crashing appears to be fixed. Thanks for looking into this, hopefully you didn't end up down a rabbit hole too long of wasting time :/

[negasora]

Glad it's fixed, thanks for confirming!