Call with non-resolvable target cannot set stack adjustment

[CouleeApps]

Version and Platform (required):

• Binary Ninja Version: 5.2.8614
• Edition: Ultimate
• OS: macOS
• OS Version: 15.5
• CPU Architecture: M1

Bug Description:
When a call has a target which cannot be resolved, trying to set user stack adjustment on the call has no effect. This can lead to mismatched stack pointers in later blocks which cannot be easily fixed.

Steps To Reproduce:

1. New Mapped Data
2. Assemble x86:

cmp esi, 0
je after
mov eax, 1000
push ecx
call eax

after:
ret

3. Create function at the start
4. Observe the return has a mismatched stack pointer
5. Right click call to eax and try to Set Stack Adjustment to 4
6. Observe no change to analysis

Expected Behavior:
I expected setting the stack adjustment of a call to actually have an effect

Screenshots/Video Recording:

Additional Information:
Setting a user call type on the call fixes this by bypassing the early-exit in the stack resolver. Looks like this is bailing early at core/stackadjustresolver.cpp:231

Reported by loadlibrary on Slack

[CouleeApps]

Fixed in >= 5.3.8649 by doing heuristics and overrides even for unresolved targets