Fix TTD Memory issues: use !tt command for time travel, improve context menu integration, and add missing context menu entries

Co-authored-by: xusheng6 <[email protected]>

Author: Copilot

core/adapters/dbgengttdadapter.cpp

@@ -457,31 +457,19 @@ bool DbgEngTTDAdapter::SetTTDPosition(const TTDPosition& position)
 		return false;
 	}
 
-	// Use data model API to navigate to position
-	std::string expression = fmt::format("@$curprocess.TTD.SetPosition(\"{:X}:{:X}\")", position.sequence, position.step);
-	std::string output = EvaluateDataModelExpression(expression);
-	
-	if (!output.empty())
-	{
-		// Check if the operation succeeded
-		bool success = output.find("error") == std::string::npos && output.find("Error") == std::string::npos;
-		if (success)
-		{
-			LogInfo("Successfully navigated to TTD position {:X}:{:X}", position.sequence, position.step);
-			return true;
-		}
-	}
-	
-	// Fallback to command interface if data model doesn't work
-	LogWarn("Data model navigation failed, falling back to command interface");
+	// Use InvokeBackendCommand with !tt command to navigate to position
 	std::string command = fmt::format("!tt {:X}:{:X}", position.sequence, position.step);
-	std::string output_fallback = InvokeBackendCommand(command);
+	std::string output = InvokeBackendCommand(command);
 
 	// Check if the command succeeded (basic check)
-	bool success = output_fallback.find("error") == std::string::npos && output_fallback.find("failed") == std::string::npos;
+	bool success = output.find("error") == std::string::npos && output.find("failed") == std::string::npos;
 	if (success)
 	{
-		LogInfo("Successfully navigated to TTD position {:X}:{:X} (fallback)", position.sequence, position.step);
+		LogInfo("Successfully navigated to TTD position {:X}:{:X}", position.sequence, position.step);
+	}
+	else
+	{
+		LogError("Failed to navigate to TTD position {:X}:{:X}", position.sequence, position.step);
 	}
 	return success;
 }

ui/ui.cpp

@@ -42,6 +42,7 @@ limitations under the License.
 #include "debuggerinfowidget.h"
 #include "ttdmemorywidget.h"
 #include "freeversion.h"
+#include <QTimer>
 
 #ifdef WIN32
 	#include "ttdrecord.h"
@@ -216,9 +217,7 @@ void GlobalDebuggerUI::QueryTTDMemoryAccess(const UIActionContext& ctxt, uint64_
 	if (!sidebar)
 		return;
 
-	sidebar->activate("TTD Memory");
-
-	// Get the current view frame and find the TTD Memory widget
+	// Get the current view frame
 	ViewFrame* frame = ctxt.context->getCurrentViewFrame();
 	if (!frame)
 		return;
@@ -227,18 +226,25 @@ void GlobalDebuggerUI::QueryTTDMemoryAccess(const UIActionContext& ctxt, uint64_
 	if (!controller)
 		return;
 
-	// Get the TTDMemoryWidgetType and find the widget instance
-	// For now, we'll use a simple approach: iterate through created widgets
-	// Note: This is a simplified implementation - in production code, 
-	// we might need a more robust widget discovery mechanism
-	
 	// Convert BNDebuggerTTDMemoryAccessType to TTDMemoryAccessType
 	TTDMemoryAccessType accessTypeEnum = static_cast<TTDMemoryAccessType>(accessType);
 
-	// Try to find the TTD Memory sidebar widget
-	// Since we just activated it, we can try to access it through global widget tracking
-	// For this implementation, we'll use a callback approach through the widget type
+	// Set pending query first
 	TTDMemoryWidgetType::SetPendingQuery(frame, ctxt.binaryView, startAddr, endAddr, accessTypeEnum);
+	
+	// Activate the sidebar widget
+	sidebar->activate("TTD Memory");
+	
+	// Try to find the widget that was just created/activated and apply the query immediately
+	// We'll give it a moment to be created if needed
+	QTimer::singleShot(100, [frame, ctxt, startAddr, endAddr, accessTypeEnum]() {
+		// Try to find the active TTD Memory widget
+		auto* sidebarWidget = frame->getSidebarWidget("TTD Memory");
+		if (auto* ttdWidget = qobject_cast<TTDMemorySidebarWidget*>(sidebarWidget))
+		{
+			ttdWidget->setParametersAndQuery(startAddr, endAddr, accessTypeEnum);
+		}
+	});
 }
 
 

ui/uinotification.cpp

@@ -186,4 +186,12 @@ void NotificationListener::OnContextMenuCreated(UIContext *context, View* view,
 	menu.addAction("Debugger", "Run To Here", "Control");
 	menu.addAction("Debugger", "Create Stack View", "Misc");
 	menu.addAction("Debugger", "Override IP", "Misc");
+#ifdef WIN32
+	// TTD Memory Access context menu items
+	menu.addAction("Debugger", "TTD Memory Access\\Read", "TTD");
+	menu.addAction("Debugger", "TTD Memory Access\\Write", "TTD");
+	menu.addAction("Debugger", "TTD Memory Access\\Read/Write", "TTD");
+	menu.addAction("Debugger", "TTD Memory Access\\Execute", "TTD");
+	menu.addAction("Debugger", "TTD Memory Access\\Read/Write/Execute", "TTD");
+#endif
 }