Add debug adapter selection dropdown at the top of the debugger sidebar (#895)

Author: Copilot

ui/debuggerwidget.cpp

@@ -18,6 +18,8 @@ limitations under the License.
 #include <QHeaderView>
 #include <QLineEdit>
 #include <QStatusBar>
+#include <QLabel>
+#include <QHBoxLayout>
 #include "debuggerwidget.h"
 #include "ui.h"
 
@@ -36,6 +38,35 @@ DebuggerWidget::DebuggerWidget(const QString& name, ViewFrame* view, BinaryViewR
 	layout->setSpacing(0);
 	layout->setAlignment(Qt::AlignTop);
 
+	m_adapterSelector = new QComboBox();
+	// Populate adapter selector
+	for (const std::string& adapter : DebugAdapterType::GetAvailableAdapters(m_controller->GetData()))
+	{
+		m_adapterSelector->addItem(QString::fromStdString(adapter));
+	}
+	
+	// Set current adapter
+	if (!m_controller->GetAdapterType().empty())
+	{
+		m_adapterSelector->setCurrentText(QString::fromStdString(m_controller->GetAdapterType()));
+	}
+	else if (m_adapterSelector->count() > 0)
+	{
+		// Set first available adapter if none is set
+		m_controller->SetAdapterType(m_adapterSelector->itemText(0).toStdString());
+		m_adapterSelector->setCurrentIndex(0);
+	}
+	else
+	{
+		// No adapters available
+		m_adapterSelector->addItem("(No available debug adapter)");
+		m_adapterSelector->setEnabled(false);
+	}
+	
+	connect(m_adapterSelector, &QComboBox::currentTextChanged, this, &DebuggerWidget::selectAdapter);
+	
+	layout->addWidget(m_adapterSelector);
+
 	m_splitter = new QSplitter(Qt::Vertical, this);
 	m_splitter->setChildrenCollapsible(true);
 
@@ -79,6 +110,14 @@ void DebuggerWidget::updateContent()
 void DebuggerWidget::uiEventHandler(const DebuggerEvent& event)
 {
 	m_controlsWidget->updateButtons();
+	
+	// Enable adapter selector only when not connected
+	DebugAdapterConnectionStatus connection = m_controller->GetConnectionStatus();
+	if (m_adapterSelector->count() > 0 && m_adapterSelector->currentText() != "(No available debug adapter)")
+	{
+		m_adapterSelector->setEnabled(connection == DebugAdapterNotConnectedStatus);
+	}
+	
 	switch (event.type)
 	{
 	case TargetStoppedEventType:
@@ -102,3 +141,21 @@ void DebuggerWidget::uiEventHandler(const DebuggerEvent& event)
 		break;
 	}
 }
+
+
+void DebuggerWidget::selectAdapter(const QString& adapter)
+{
+	if (adapter.isEmpty())
+		return;
+
+	auto adapterType = DebugAdapterType::GetByName(adapter.toStdString());
+	if (!adapterType)
+		return;
+
+	m_controller->SetAdapterType(adapter.toStdString());
+	Ref<Metadata> data = new Metadata(adapter.toStdString());
+	m_controller->GetData()->StoreMetadata("debugger.adapter_type", data);
+
+	// Update button states after adapter change
+	m_controlsWidget->updateButtons();
+}

ui/debuggerwidget.h

@@ -22,6 +22,7 @@ limitations under the License.
 #include <QTableView>
 #include <QStyledItemDelegate>
 #include <QTabWidget>
+#include <QComboBox>
 #include "inttypes.h"
 #include "binaryninjaapi.h"
 #include "viewframe.h"
@@ -45,6 +46,7 @@ class DebuggerWidget : public SidebarWidget
 	ViewFrame* m_view;
 	DbgRef<DebuggerController> m_controller;
 
+	QComboBox* m_adapterSelector;
 	QSplitter* m_splitter;
 	QTabWidget* m_tabs;
 
@@ -60,6 +62,7 @@ class DebuggerWidget : public SidebarWidget
 
 private slots:
 	void uiEventHandler(const DebuggerEvent& event);
+	void selectAdapter(const QString& adapter);
 
 public:
 	DebuggerWidget(const QString& name, ViewFrame* view, BinaryViewRef data);