Add max query results setting for TTD Memory and TTD Calls queries

Co-authored-by: xusheng6 <[email protected]>

Author: Copilot

core/adapters/dbgengttdadapter.cpp

@@ -352,6 +352,16 @@ Ref<Settings> DbgEngTTDAdapterType::RegisterAdapterSettings()
 			"readOnly" : false,
 			"uiSelectionAction" : "file"
 			})");
+	settings->RegisterSetting("ttd.maxQueryResults",
+		R"({
+			"title" : "Max Query Results",
+			"type" : "number",
+			"default" : 10000,
+			"minValue" : 1,
+			"maxValue" : 1000000,
+			"description" : "Maximum number of results to return from TTD Memory and TTD Calls queries to prevent performance issues with large traces",
+			"readOnly" : false
+			})");
 
 	return settings;
 }
@@ -497,8 +507,13 @@ bool DbgEngTTDAdapter::QueryMemoryAccessByAddress(uint64_t startAddress, uint64_
 			return false;
 		}
 
-		// Create the actual TTD memory query expression
-		std::string expression = fmt::format("@$cursession.TTD.Memory(0x{:x},0x{:x},\"{}\")", startAddress, endAddress, accessTypeStr);
+		// Get the max results setting
+		auto adapterSettings = GetAdapterSettings();
+		BNSettingsScope scope = SettingsResourceScope;
+		auto maxResults = adapterSettings->Get<uint64_t>("ttd.maxQueryResults", GetData(), &scope);
+		
+		// Create the actual TTD memory query expression with result limit
+		std::string expression = fmt::format("@$cursession.TTD.Memory(0x{:x},0x{:x},\"{}\").Take({})", startAddress, endAddress, accessTypeStr, maxResults);
 
 		LogInfo("Executing TTD memory query: %s", expression.c_str());
 
@@ -509,7 +524,7 @@ bool DbgEngTTDAdapter::QueryMemoryAccessByAddress(uint64_t startAddress, uint64_
 			return false;
 		}
 
-		LogInfo("Successfully retrieved %zu TTD memory events", events.size());
+		LogInfo("Successfully retrieved %zu TTD memory events (limited to %llu)", events.size(), maxResults);
 		return true;
 	}
 	catch (const std::exception& e)
@@ -982,6 +997,13 @@ bool DbgEngTTDAdapter::QueryCallsForSymbols(const std::vector<std::string>& symb
 				fmt::format("{:x}", endReturnAddress) + ")";
 		}
 
+		// Get the max results setting and add Take() to limit results
+		auto adapterSettings = GetAdapterSettings();
+		BNSettingsScope scope = SettingsResourceScope;
+		auto maxResults = adapterSettings->Get<uint64_t>("ttd.maxQueryResults", GetData(), &scope);
+		
+		expression += fmt::format(".Take({})", maxResults);
+		
 		LogInfo("Executing TTD calls query: %s", expression.c_str());
 
 		return ParseTTDCallObjects(expression, events);

ui/ttdmemorywidget.cpp

@@ -418,6 +418,20 @@ void TTDMemoryQueryWidget::performQuery()
 		}
 
 		updateStatus(QString("Found %1 memory access events").arg(events.size()));
+		
+		// Check if results might be truncated by comparing with max results setting
+		if (m_controller && m_controller->GetAdapterSettings())
+		{
+			auto adapterSettings = m_controller->GetAdapterSettings();
+			BNSettingsScope scope = SettingsResourceScope;
+			auto maxResults = adapterSettings->Get<uint64_t>("ttd.maxQueryResults", m_data, &scope);
+			
+			if (events.size() >= maxResults)
+			{
+				updateStatus(QString("Found %1 memory access events (results may be truncated at limit of %2)")
+					.arg(events.size()).arg(maxResults));
+			}
+		}
 	}
 	catch (const std::exception& e)
 	{