Skip to content

Commit a29db8a

Browse files
authored
Simplify TTD button logic: always enable buttons, show errors on click (#856)
1 parent 3b188f4 commit a29db8a

File tree

2 files changed

+17
-27
lines changed

2 files changed

+17
-27
lines changed

ui/ttdcallswidget.cpp

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,18 +201,31 @@ void TTDCallsQueryWidget::performQuery()
201201
{
202202
if (!m_controller)
203203
{
204+
QMessageBox::warning(this, "Controller Not Available",
205+
"No debugger controller is available.");
204206
return;
205207
}
206208

207209
if (!m_controller->IsConnected())
208210
{
211+
QMessageBox::warning(this, "Not Connected",
212+
"Not connected to a debugging target.");
213+
return;
214+
}
215+
216+
if (!m_controller->IsTTD())
217+
{
218+
QMessageBox::warning(this, "TTD Not Available",
219+
"Time Travel Debugging is not available with the current target.");
209220
return;
210221
}
211222

212223
// Get symbols string
213224
QString symbolsText = m_symbolsEdit->text().trimmed();
214225
if (symbolsText.isEmpty())
215226
{
227+
QMessageBox::warning(this, "No Symbols Specified",
228+
"Please enter one or more symbol names to search for.");
216229
return;
217230
}
218231

ui/ttdmemorywidget.cpp

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -214,33 +214,10 @@ void TTDMemoryQueryWidget::setupUI()
214214

215215
setLayout(mainLayout);
216216

217-
// Update UI state based on controller
218-
bool canQuery = false;
219-
if (m_controller)
220-
{
221-
canQuery = m_controller->IsTTD();
222-
}
223-
224-
m_queryButton->setEnabled(canQuery);
225-
226-
if (!canQuery)
227-
{
228-
if (!m_controller)
229-
{
230-
updateStatus("No debugger controller available");
231-
m_queryButton->setToolTip("Query Memory Events - No debugger controller available");
232-
}
233-
else if (!m_controller->IsTTD())
234-
{
235-
updateStatus("TTD (Time Travel Debugging) not available with current target");
236-
m_queryButton->setToolTip("Query Memory Events - TTD (Time Travel Debugging) not available with current adapter");
237-
}
238-
}
239-
else
240-
{
241-
updateStatus("Ready - TTD memory analysis available");
242-
m_queryButton->setToolTip("Execute TTD memory analysis query");
243-
}
217+
// Button is always enabled - errors are shown in performQuery() if needed
218+
m_queryButton->setEnabled(true);
219+
m_queryButton->setToolTip("Execute TTD memory analysis query");
220+
updateStatus("Ready");
244221
}
245222

246223
void TTDMemoryQueryWidget::setupTable()

0 commit comments

Comments
 (0)