LLDB remote debugging working for the first time

Author: xusheng6

core/adapters/lldbadapter.cpp

@@ -1157,8 +1157,12 @@ Ref<Metadata> LldbAdapter::GetProperty(const std::string &name)
 		for (size_t i = 0; i < m_debugger.GetNumAvailablePlatforms(); i++)
 		{
 			auto platform = m_debugger.GetAvailablePlatformInfoAtIndex(i);
+			auto nameData = platform.GetValueForKey("name");
+			char name[1024];
+			nameData.GetStringValue(name, 1024);
+			platforms.emplace_back(name);
 		}
-//		return Metadata(platforms);
+		return new Metadata(platforms);
 	}
 	return nullptr;
 }
@@ -1181,3 +1185,21 @@ bool LldbAdapter::SetProperty(const std::string &name, const Ref<Metadata> &valu
 	}
 	return false;
 }
+
+
+bool LldbAdapter::ConnectToDebugServer(const std::string &server, std::uint32_t port)
+{
+	auto platform = m_debugger.GetSelectedPlatform();
+	auto connectionString = fmt::format("connect://{}:{}", server, port);
+	SBPlatformConnectOptions options(connectionString.c_str());
+	auto error = platform.ConnectRemote(options);
+	return error.Success();
+}
+
+
+bool LldbAdapter::DisconnectDebugServer()
+{
+	auto platform = m_debugger.GetSelectedPlatform();
+	platform.DisconnectRemote();
+	return true;
+}

core/adapters/lldbadapter.h

@@ -114,6 +114,10 @@ namespace BinaryNinjaDebugger {
 		Ref<Metadata> GetProperty(const std::string& name) override;
 
 		bool SetProperty(const std::string& name, const Ref<Metadata>& value) override;
+
+		bool ConnectToDebugServer(const std::string &server, std::uint32_t port) override;
+
+		bool DisconnectDebugServer() override;
 	};
 
 	class LldbAdapterType: public DebugAdapterType

ui/debugserversetting.cpp

@@ -36,16 +36,13 @@ DebugServerSettingsDialog::DebugServerSettingsDialog(QWidget* parent, DebuggerCo
     titleLayout->setContentsMargins(0, 0, 0, 0);
 
     m_platformEntry = new QComboBox(this);
-	// workaround for the missing Metadata API
-	m_platformEntry->setEditable(true);
-
-//    auto platformsMetaData = m_controller->GetAdapterProperty("platforms");
-//    if (platformsMetaData->IsStringList())
-//    {
-//        auto platforms = platformsMetaData->GetStringList();
-//        for (const auto& platform: platforms)
-//            m_platformEntry->addItem(QString::fromStdString(platform));
-//    }
+    auto platformsMetaData = m_controller->GetAdapterProperty("platforms");
+    if (platformsMetaData->IsStringList())
+    {
+        auto platforms = platformsMetaData->GetStringList();
+        for (const auto& platform: platforms)
+            m_platformEntry->addItem(QString::fromStdString(platform));
+    }
 
     auto currentPlatformMetadata = m_controller->GetAdapterProperty("current_platform");
     if (currentPlatformMetadata && currentPlatformMetadata->IsString())
@@ -111,9 +108,12 @@ void DebugServerSettingsDialog::apply()
     m_controller->GetData()->StoreMetadata("debugger.remote_port", data);
 
 	const auto platform = m_platformEntry->currentText().toStdString();
-	data = new Metadata(platform);
-	m_controller->SetAdapterProperty("current_platform", data);
-	m_controller->GetData()->StoreMetadata("debugger.platform", data);
+	if (!platform.empty())
+	{
+		data = new Metadata(platform);
+		m_controller->SetAdapterProperty("current_platform", data);
+		m_controller->GetData()->StoreMetadata("debugger.platform", data);
+	}
 
     accept();
 }