Move copy functionality to threadframes widget and revert stackwidget changes

Co-authored-by: xusheng6 <[email protected]>

Author: Copilot

ui/stackwidget.cpp

@@ -17,9 +17,6 @@ limitations under the License.
 #include <QPainter>
 #include <QHeaderView>
 #include <QLineEdit>
-#include <QGuiApplication>
-#include <QMimeData>
-#include <QClipboard>
 #include "stackwidget.h"
 #include "fmt/format.h"
 
@@ -412,18 +409,6 @@ DebugStackWidget::DebugStackWidget(const QString& name, ViewFrame* view, BinaryV
 	layout->addWidget(m_table);
 	setLayout(layout);
 
-	m_actionHandler.setupActionHandler(this);
-	m_contextMenuManager = new ContextMenuManager(this);
-	m_menu = new Menu();
-
-	m_menu->addAction("Copy", "Options", MENU_ORDER_NORMAL);
-	m_actionHandler.bindAction("Copy", UIAction([&]() { copy(); }, [&]() { return selectionNotEmpty(); }));
-
-	QString actionName = QString::fromStdString("Copy All Stack Entries");
-	UIAction::registerAction(actionName);
-	m_menu->addAction(actionName, "Options", MENU_ORDER_NORMAL);
-	m_actionHandler.bindAction(actionName, UIAction([this]() { copyAll(); }));
-
 	updateContent();
 }
 
@@ -436,99 +421,10 @@ void DebugStackWidget::notifyStackChanged(std::vector<DebugStackItem> stackItems
 }
 
 
-void DebugStackWidget::contextMenuEvent(QContextMenuEvent* event)
-{
-	showContextMenu();
-}
-
-
-void DebugStackWidget::showContextMenu()
-{
-	m_contextMenuManager->show(m_menu, &m_actionHandler);
-}
-
-
-bool DebugStackWidget::selectionNotEmpty()
-{
-	QModelIndexList sel = m_table->selectionModel()->selectedRows();
-	return !sel.empty();
-}
-
-
-void DebugStackWidget::copy()
-{
-	QModelIndexList sel = m_table->selectionModel()->selectedRows();
-	if (sel.empty())
-		return;
-
-	QString text;
-	for (int i = 0; i < sel.size(); i++)
-	{
-		if (i > 0)
-			text += "\n";
-
-		int row = sel[i].row();
-		if (row < 0 || row >= m_model->rowCount())
-			continue;
-
-		DebugStackItem item = m_model->getRow(row);
-
-		// Format: Offset Address Value Hint
-		QString offsetStr;
-		ptrdiff_t offset = item.offset();
-		if (offset < 0)
-			offsetStr = QString::asprintf("-0x%" PRIx64, (uint64_t)-offset);
-		else
-			offsetStr = QString::asprintf("0x%" PRIx64, (uint64_t)offset);
-
-		text += QString::asprintf("%s 0x%" PRIx64 " 0x%" PRIx64 " %s", offsetStr.toStdString().c_str(), item.address(),
-			item.value(), item.hint().c_str());
-	}
-
-	auto* clipboard = QGuiApplication::clipboard();
-	clipboard->clear();
-	auto* mime = new QMimeData();
-	mime->setText(text);
-	clipboard->setMimeData(mime);
-}
-
-
-void DebugStackWidget::copyAll()
-{
-	QString text;
-	int rowCount = m_model->rowCount();
-
-	for (int row = 0; row < rowCount; row++)
-	{
-		if (row > 0)
-			text += "\n";
-
-		DebugStackItem item = m_model->getRow(row);
-
-		// Format: Offset Address Value Hint
-		QString offsetStr;
-		ptrdiff_t offset = item.offset();
-		if (offset < 0)
-			offsetStr = QString::asprintf("-0x%" PRIx64, (uint64_t)-offset);
-		else
-			offsetStr = QString::asprintf("0x%" PRIx64, (uint64_t)offset);
-
-		text += QString::asprintf("%s 0x%" PRIx64 " 0x%" PRIx64 " %s", offsetStr.toStdString().c_str(), item.address(),
-			item.value(), item.hint().c_str());
-	}
-
-	auto* clipboard = QGuiApplication::clipboard();
-	clipboard->clear();
-	auto* mime = new QMimeData();
-	mime->setText(text);
-	clipboard->setMimeData(mime);
-}
-
-
-// void DebugStackWidget::notifyFontChanged()
+//void DebugStackWidget::notifyFontChanged()
 //{
-//     m_delegate->updateFonts();
-// }
+//    m_delegate->updateFonts();
+//}
 
 
 void DebugStackWidget::updateContent()

ui/stackwidget.h

@@ -21,16 +21,12 @@ limitations under the License.
 #include <QModelIndex>
 #include <QTableView>
 #include <QStyledItemDelegate>
-#include <QGuiApplication>
-#include <QMimeData>
-#include <QClipboard>
 #include "inttypes.h"
 #include "binaryninjaapi.h"
 #include "viewframe.h"
 #include "fontsettings.h"
 #include "theme.h"
 #include "debuggerapi.h"
-#include "menus.h"
 
 using namespace BinaryNinjaDebuggerAPI;
 
@@ -142,27 +138,15 @@ class DebugStackWidget : public QWidget
 	DebugStackListModel* m_model;
 	DebugStackItemDelegate* m_delegate;
 
-	UIActionHandler m_actionHandler;
-	ContextMenuManager* m_contextMenuManager;
-	Menu* m_menu;
+	//void shouldBeVisible()
 
-	virtual void contextMenuEvent(QContextMenuEvent* event) override;
-	bool selectionNotEmpty();
-
-	// void shouldBeVisible()
-
-	// virtual void notifyFontChanged() override;
+	//virtual void notifyFontChanged() override;
 
 
 public:
 	DebugStackWidget(const QString& name, ViewFrame* view, BinaryViewRef data);
 	void notifyStackChanged(std::vector<DebugStackItem> stackItems);
 
-private slots:
-	void copy();
-	void copyAll();
-
 public slots:
 	void updateContent();
-	void showContextMenu();
 };

ui/threadframes.cpp

@@ -58,7 +58,8 @@ int FrameItem::row() const
 }
 
 
-ThreadFrameModel::ThreadFrameModel(QObject* parent, DebuggerControllerRef controller) : QAbstractItemModel(parent), m_controller(controller)
+ThreadFrameModel::ThreadFrameModel(QObject* parent, DebuggerControllerRef controller) :
+	QAbstractItemModel(parent), m_controller(controller)
 {
 	rootItem = new FrameItem();
 }
@@ -109,7 +110,8 @@ QVariant ThreadFrameModel::data(const QModelIndex& index, int role) const
 
 		auto isActiveThread = m_controller->GetActiveThread().m_tid == item->tid();
 
-		QString text = QString::asprintf("%s0x%x @ 0x%" PRIx64, isActiveThread ? "(*) " : "", item->tid(), item->threadPc());
+		QString text =
+			QString::asprintf("%s0x%x @ 0x%" PRIx64, isActiveThread ? "(*) " : "", item->tid(), item->threadPc());
 		if (role == Qt::SizeHintRole)
 			return QVariant((qulonglong)text.size());
 
@@ -182,20 +184,22 @@ void ThreadFrameModel::updateRows(DebuggerController* controller)
 	parents << rootItem;
 
 	std::vector<DebugThread> threads = controller->GetThreads();
-	
+
 	// Sort threads so that the active thread appears first
 	uint32_t activeThreadId = controller->GetActiveThread().m_tid;
 	std::sort(threads.begin(), threads.end(), [activeThreadId](const DebugThread& a, const DebugThread& b) {
 		// Active thread comes first, then sort by thread ID for consistent ordering
 		bool aIsActive = (a.m_tid == activeThreadId);
 		bool bIsActive = (b.m_tid == activeThreadId);
-		
-		if (aIsActive && !bIsActive) return true;
-		if (!aIsActive && bIsActive) return false;
-		
+
+		if (aIsActive && !bIsActive)
+			return true;
+		if (!aIsActive && bIsActive)
+			return false;
+
 		return a.m_tid < b.m_tid;
 	});
-	
+
 	for (const DebugThread& thread : threads)
 	{
 		parents.last()->appendChild(new FrameItem(thread, parents.last()));
@@ -550,6 +554,92 @@ void ThreadFramesWidget::copy()
 }
 
 
+void ThreadFramesWidget::copyCurrentFrame()
+{
+	QModelIndexList sel = selectionModel()->selectedIndexes();
+	if (sel.empty())
+		return;
+
+	QString text;
+	QSet<int> processedRows;
+
+	for (const QModelIndex& index : sel)
+	{
+		if (!index.isValid())
+			continue;
+
+		int row = index.row();
+		if (processedRows.contains(row))
+			continue;
+
+		processedRows.insert(row);
+
+		FrameItem* item = static_cast<FrameItem*>(index.internalPointer());
+		if (!item || !item->isFrame())
+			continue;
+
+		if (!text.isEmpty())
+			text += "\n";
+
+		// Format: FrameIndex Module Function PC SP FP
+		text += QString::asprintf("%lu %s %s 0x%" PRIx64 " 0x%" PRIx64 " 0x%" PRIx64, item->frameIndex(),
+			item->module().c_str(), item->function().c_str(), item->framePc(), item->sp(), item->fp());
+	}
+
+	if (text.isEmpty())
+		return;
+
+	auto* clipboard = QGuiApplication::clipboard();
+	clipboard->clear();
+	auto* mime = new QMimeData();
+	mime->setText(text);
+	clipboard->setMimeData(mime);
+}
+
+
+void ThreadFramesWidget::copyAllFrames()
+{
+	QString text;
+
+	// Iterate through all top-level items (threads)
+	for (int i = 0; i < m_model->rowCount(); i++)
+	{
+		QModelIndex threadIndex = m_model->index(i, 0);
+		if (!threadIndex.isValid())
+			continue;
+
+		FrameItem* threadItem = static_cast<FrameItem*>(threadIndex.internalPointer());
+		if (!threadItem)
+			continue;
+
+		// Iterate through all frames in this thread
+		for (int j = 0; j < threadItem->childCount(); j++)
+		{
+			FrameItem* frameItem = threadItem->child(j);
+			if (!frameItem || !frameItem->isFrame())
+				continue;
+
+			if (!text.isEmpty())
+				text += "\n";
+
+			// Format: FrameIndex Module Function PC SP FP
+			text += QString::asprintf("%lu %s %s 0x%" PRIx64 " 0x%" PRIx64 " 0x%" PRIx64, frameItem->frameIndex(),
+				frameItem->module().c_str(), frameItem->function().c_str(), frameItem->framePc(), frameItem->sp(),
+				frameItem->fp());
+		}
+	}
+
+	if (text.isEmpty())
+		return;
+
+	auto* clipboard = QGuiApplication::clipboard();
+	clipboard->clear();
+	auto* mime = new QMimeData();
+	mime->setText(text);
+	clipboard->setMimeData(mime);
+}
+
+
 ThreadFramesWidget::ThreadFramesWidget(QWidget* parent, ViewFrame* frame, BinaryViewRef data) :
 	QTreeView(parent), m_view(frame)
 {
@@ -585,7 +675,8 @@ ThreadFramesWidget::ThreadFramesWidget(QWidget* parent, ViewFrame* frame, Binary
 	actionName = QString::fromStdString("Resume Thread");
 	UIAction::registerAction(actionName);
 	m_menu->addAction(actionName, "Options", MENU_ORDER_FIRST);
-	m_actionHandler.bindAction(actionName, UIAction([this]() { resumeThread(); }, [this]() { return canSuspendOrResume(); }));
+	m_actionHandler.bindAction(
+		actionName, UIAction([this]() { resumeThread(); }, [this]() { return canSuspendOrResume(); }));
 
 	actionName = QString::fromStdString("Make It Solo Thread");
 	UIAction::registerAction(actionName);
@@ -623,16 +714,24 @@ ThreadFramesWidget::ThreadFramesWidget(QWidget* parent, ViewFrame* frame, Binary
 		}
 	});
 
+	actionName = QString::fromStdString("Copy Current Stack Trace");
+	UIAction::registerAction(actionName);
+	m_menu->addAction(actionName, "Options", MENU_ORDER_NORMAL);
+	m_actionHandler.bindAction(
+		actionName, UIAction([this]() { copyCurrentFrame(); }, [this]() { return selectionNotEmpty(); }));
+
+	actionName = QString::fromStdString("Copy All Stack Traces");
+	UIAction::registerAction(actionName);
+	m_menu->addAction(actionName, "Options", MENU_ORDER_NORMAL);
+	m_actionHandler.bindAction(actionName, UIAction([this]() { copyAllFrames(); }));
+
 	// TODO: set as active thread action?
 
 	connect(this, &QTreeView::doubleClicked, this, &ThreadFramesWidget::onDoubleClicked);
 	connect(this, &ThreadFramesWidget::debuggerEvent, this, &ThreadFramesWidget::onDebuggerEvent);
 
 	m_debuggerEventCallback = m_debugger->RegisterEventCallback(
-		[&](const DebuggerEvent& event) {
-			emit debuggerEvent(event);
-		},
-		"Thread Frame");
+		[&](const DebuggerEvent& event) { emit debuggerEvent(event); }, "Thread Frame");
 
 	updateContent();
 }
@@ -721,7 +820,7 @@ void ThreadFramesWidget::onDoubleClicked()
 	{
 		uint32_t tid = frameItem->tid();
 		uint32_t currentTid = m_debugger->GetActiveThread().m_tid;
-		
+
 		if (tid != currentTid && !m_debugger->IsRunning())
 			m_debugger->SetActiveThread(tid);
 

ui/threadframes.h

@@ -197,6 +197,8 @@ private slots:
 	void resumeThread();
 	void makeItSoloThread();
 	void copy();
+	void copyCurrentFrame();
+	void copyAllFrames();
 };
 
 class ThreadFramesContainer : public SidebarWidget