Address PR feedback: restore formatting, use dynamic column sizing, add event listener

Co-authored-by: xusheng6 <[email protected]>

Author: Copilot

api/debuggerapi.h

@@ -538,7 +538,7 @@ namespace BinaryNinjaDebuggerAPI {
 		uint64_t size;                 // Size of the module in bytes
 		uint32_t checksum;             // Checksum of the module
 		uint32_t timestamp;            // Timestamp of the module
-
+		
 		TTDModule() : address(0), size(0), checksum(0), timestamp(0) {}
 	};
 
@@ -551,7 +551,7 @@ namespace BinaryNinjaDebuggerAPI {
 		TTDPosition lifetimeEnd;       // Lifetime end position
 		TTDPosition activeTimeStart;   // Active time start position
 		TTDPosition activeTimeEnd;     // Active time end position
-
+		
 		TTDThread() : uniqueId(0), id(0) {}
 	};
 
@@ -571,7 +571,7 @@ namespace BinaryNinjaDebuggerAPI {
 		uint32_t flags;                // Exception flags
 		uint64_t recordAddress;        // Where in memory the exception record is found
 		TTDPosition position;          // Position where exception occurred
-
+		
 		TTDException() : type(TTDExceptionSoftware), programCounter(0), code(0), flags(0), recordAddress(0) {}
 	};
 
@@ -580,12 +580,12 @@ namespace BinaryNinjaDebuggerAPI {
 	{
 		TTDEventType type;             // Type of event
 		TTDPosition position;          // Position where event occurred
-
+		
 		// Optional child objects - existence depends on event type
 		std::optional<TTDModule> module;      // For ModuleLoaded/ModuleUnloaded events
 		std::optional<TTDThread> thread;      // For ThreadCreated/ThreadTerminated events
 		std::optional<TTDException> exception; // For Exception events
-
+		
 		TTDEvent() : type(TTDEventThreadCreated) {}
 		TTDEvent(TTDEventType eventType) : type(eventType) {}
 	};

ui/ttdheapwidget.cpp

@@ -42,7 +42,7 @@ class NumericalTableWidgetItem : public QTableWidgetItem
 
 // TTDHeapQueryWidget implementation
 TTDHeapQueryWidget::TTDHeapQueryWidget(QWidget* parent, BinaryViewRef data)
-	: QWidget(parent), m_data(data)
+	: QWidget(parent), m_data(data), m_hasPopulatedData(false)
 {
 	m_controller = DebuggerController::GetController(m_data);
 	if (!m_controller)
@@ -65,10 +65,22 @@ TTDHeapQueryWidget::TTDHeapQueryWidget(QWidget* parent, BinaryViewRef data)
 
 	setupUI();
 	setupUIActions();
+	
+	// Register for debugger events
+	connect(this, &TTDHeapQueryWidget::debuggerEvent, this, &TTDHeapQueryWidget::onDebuggerEvent);
+	
+	m_debuggerEventCallback = m_controller->RegisterEventCallback(
+		[&](const DebuggerEvent& event) {
+			emit debuggerEvent(event);
+		},
+		"TTD Heap Widget");
 }
 
 TTDHeapQueryWidget::~TTDHeapQueryWidget()
 {
+	if (m_controller)
+		m_controller->RemoveEventCallback(m_debuggerEventCallback);
+	
 	if (m_contextMenuManager)
 		delete m_contextMenuManager;
 }
@@ -118,25 +130,6 @@ void TTDHeapQueryWidget::setupTable()
 	m_resultsTable->setSelectionBehavior(QAbstractItemView::SelectRows);
 	m_resultsTable->setSortingEnabled(true);
 	m_resultsTable->setContextMenuPolicy(Qt::CustomContextMenu);
-	
-	// Set column widths
-	m_resultsTable->setColumnWidth(IndexColumn, 80);
-	m_resultsTable->setColumnWidth(EventTypeColumn, 100);
-	m_resultsTable->setColumnWidth(ActionColumn, 100);
-	m_resultsTable->setColumnWidth(TimeStartColumn, 120);
-	m_resultsTable->setColumnWidth(TimeEndColumn, 120);
-	m_resultsTable->setColumnWidth(HeapColumn, 120);
-	m_resultsTable->setColumnWidth(AddressColumn, 120);
-	m_resultsTable->setColumnWidth(PreviousAddressColumn, 120);
-	m_resultsTable->setColumnWidth(SizeColumn, 100);
-	m_resultsTable->setColumnWidth(BaseAddressColumn, 120);
-	m_resultsTable->setColumnWidth(FlagsColumn, 100);
-	m_resultsTable->setColumnWidth(ResultColumn, 100);
-	m_resultsTable->setColumnWidth(ReserveSizeColumn, 100);
-	m_resultsTable->setColumnWidth(CommitSizeColumn, 100);
-	m_resultsTable->setColumnWidth(MakeReadOnlyColumn, 100);
-	m_resultsTable->setColumnWidth(ThreadIdColumn, 100);
-	m_resultsTable->setColumnWidth(UniqueThreadIdColumn, 120);
 
 	updateColumnVisibility();
 
@@ -263,6 +256,12 @@ void TTDHeapQueryWidget::performQuery()
 			m_resultsTable->setItem(i, ParametersColumn, new QTableWidgetItem(paramStrings.join(", ")));
 		}
 
+		// Resize columns to fit contents after populating data
+		m_resultsTable->resizeColumnsToContents();
+		
+		// Mark that we have populated data
+		m_hasPopulatedData = true;
+		
 		updateStatus(QString("Found %1 heap objects").arg(events.size()));
 	}
 	catch (const std::exception& e)
@@ -277,6 +276,7 @@ void TTDHeapQueryWidget::performQuery()
 void TTDHeapQueryWidget::clearResults()
 {
 	m_resultsTable->setRowCount(0);
+	m_hasPopulatedData = false;
 	updateStatus("Results cleared");
 }
 
@@ -499,6 +499,22 @@ void TTDHeapQueryWidget::copyEntireTable()
 	QApplication::clipboard()->setText(tableData.join("\n"));
 }
 
+void TTDHeapQueryWidget::onDebuggerEvent(const DebuggerEvent& event)
+{
+	switch (event.type)
+	{
+		case TargetStoppedEventType:
+			// When the target stops, populate data if not already populated
+			if (!m_hasPopulatedData && m_controller && m_controller->IsTTD())
+			{
+				performQuery();
+			}
+			break;
+		default:
+			break;
+	}
+}
+
 // TTDHeapWidget implementation (tab container)
 TTDHeapWidget::TTDHeapWidget(QWidget* parent, BinaryViewRef data)
 	: QWidget(parent), m_data(data)

ui/ttdheapwidget.h

@@ -98,6 +98,10 @@ class TTDHeapQueryWidget : public QWidget
 	ContextMenuManager* m_contextMenuManager;
 	Menu* m_menu;
 
+	// Event callback
+	size_t m_debuggerEventCallback;
+	bool m_hasPopulatedData;
+	
 	void setupUI();
 	void setupTable();
 	void updateStatus(const QString& message);
@@ -118,6 +122,9 @@ class TTDHeapQueryWidget : public QWidget
 	// Method to check if this tab is unused (no results and default parameters)
 	bool isUnused() const;
 
+Q_SIGNALS:
+	void debuggerEvent(const DebuggerEvent& event);
+
 private Q_SLOTS:
 	void clearResults();
 	void onCellDoubleClicked(int row, int column);
@@ -128,6 +135,7 @@ private Q_SLOTS:
 	void copySelectedCell();
 	void copySelectedRow();
 	void copyEntireTable();
+	void onDebuggerEvent(const DebuggerEvent& event);
 };
 
 class TTDHeapWidget : public QWidget