Support querying arbitrary property from the debugadapter

Author: xusheng6

api/debuggerapi.h

@@ -334,6 +334,9 @@ namespace BinaryNinjaDebuggerAPI
 
 		static std::string GetDebugStopReasonString(DebugStopReason reason);
 		DebugStopReason StopReason();
+
+        BinaryNinja::Ref<Metadata> GetAdapterProperty(const std::string& name);
+        bool SetAdapterProperty(const std::string& name, const BinaryNinja::Ref<Metadata>& value);
 	};
 
 

api/debuggercontroller.cpp

@@ -665,3 +665,18 @@ DebugStopReason DebuggerController::StopReason()
 {
 	return BNDebuggerGetStopReason(m_object);
 }
+
+
+Ref<Metadata> DebuggerController::GetAdapterProperty(const std::string& name)
+{
+    BNMetadata* value = BNDebuggerGetAdapterProperty(m_object, name.c_str());
+    if (!value)
+        return nullptr;
+    return new Metadata(value);
+}
+
+
+bool DebuggerController::SetAdapterProperty(const std::string& name, const BinaryNinja::Ref<Metadata>& value)
+{
+    return BNDebuggerSetAdapterProperty(m_object, name.c_str(), value->m_object);
+}

api/ffi.h

@@ -51,6 +51,7 @@ extern "C"
 	struct BNBinaryView;
 	struct BNArchitecture;
 	struct BNDataBuffer;
+    struct BNMetadata;
 	enum BNFunctionGraphType;
 
 	struct BNDebugThread
@@ -399,6 +400,10 @@ extern "C"
 															void* ctx);
 	DEBUGGER_FFI_API void BNDebuggerRemoveEventCallback(BNDebuggerController* controller, size_t index);
 
+    DEBUGGER_FFI_API BNMetadata* BNDebuggerGetAdapterProperty(BNDebuggerController* controller, const char* name);
+    DEBUGGER_FFI_API bool BNDebuggerSetAdapterProperty(BNDebuggerController* controller, const char* name,
+                                                      BNMetadata* value);
+
 #ifdef __cplusplus
 }
 #endif

core/debugadapter.cpp

@@ -112,3 +112,15 @@ bool DebugAdapter::DisconnectDebugServer()
 {
     return true;
 }
+
+
+Ref<Metadata> DebugAdapter::GetProperty(const std::string &name)
+{
+    return nullptr;
+}
+
+
+bool DebugAdapter::SetProperty(const std::string &name, const BinaryNinja::Ref<BinaryNinja::Metadata>& value)
+{
+    return false;
+}

core/debugadapter.h

@@ -272,5 +272,9 @@ namespace BinaryNinjaDebugger
 		void PostDebuggerEvent(const DebuggerEvent &event);
 
 		virtual void WriteStdin(const std::string& msg);
+
+        BinaryNinja::Ref<BinaryNinja::Metadata> GetProperty(const std::string& name);
+
+        bool SetProperty(const std::string& name, const BinaryNinja::Ref<BinaryNinja::Metadata>& value);
 	};
 };

core/debuggercontroller.cpp

@@ -1477,3 +1477,18 @@ DebugStopReason DebuggerController::WaitForAdapterStop()
 	RemoveEventCallback(callback);
 	return reason;
 }
+
+
+Ref<Metadata> DebuggerController::GetAdapterProperty(const std::string& name)
+{
+    if (!m_adapter)
+        return nullptr;
+
+    return m_adapter->GetProperty(name);
+}
+
+
+bool DebuggerController::SetAdapterProperty(const std::string& name, const BinaryNinja::Ref<BinaryNinja::Metadata>& value)
+{
+    return true;
+}

core/debuggercontroller.h

@@ -226,5 +226,8 @@ namespace BinaryNinjaDebugger
 
 		DebugStopReason WaitForTargetStop();
 		DebugStopReason WaitForAdapterStop();
+
+        BinaryNinja::Ref<BinaryNinja::Metadata> GetAdapterProperty(const std::string& name);
+        bool SetAdapterProperty(const std::string& name, const BinaryNinja::Ref<BinaryNinja::Metadata>& value);
 	};
 };

core/ffi.cpp

@@ -819,3 +819,16 @@ DEBUGGER_FFI_API DebugStopReason BNDebuggerGetStopReason(BNDebuggerController* c
 {
 	return controller->object->StopReason();
 }
+
+
+DEBUGGER_FFI_API BNMetadata* BNDebuggerGetAdapterProperty(BNDebuggerController* controller, const char* name)
+{
+    return API_OBJECT_REF(controller->object->GetAdapterProperty(name));
+}
+
+
+DEBUGGER_FFI_API bool BNDebuggerSetAdapterProperty(BNDebuggerController* controller, const char* name,
+                                                   BNMetadata* value)
+{
+    return controller->object->SetAdapterProperty(name, new Metadata(BNNewMetadataReference(value)));
+}

ui/debugserversetting.h

@@ -28,19 +28,17 @@ limitations under the License.
 #include "fontsettings.h"
 #include "debuggerapi.h"
 
-using namespace BinaryNinjaDebuggerAPI;
-
 class DebugServerSettingsDialog: public QDialog
 {
     Q_OBJECT
 
 private:
-    DebuggerController* m_controller;
+    BinaryNinjaDebuggerAPI::DebuggerController* m_controller;
     QLineEdit* m_addressEntry;
     QLineEdit* m_portEntry;
 
 public:
-    DebugServerSettingsDialog(QWidget* parent, DebuggerController* controller);
+    DebugServerSettingsDialog(QWidget* parent, BinaryNinjaDebuggerAPI::DebuggerController* controller);
 
 private Q_SLOTS:
     void apply();