WIP on querying properties from the DebugAdapter

Author: xusheng6

core/adapters/lldbadapter.cpp

@@ -1142,3 +1142,29 @@ void LldbAdapter::WriteStdin(const std::string &msg)
 {
 	m_process.PutSTDIN(msg.c_str(), msg.length());
 }
+
+
+Ref<Metadata> LldbAdapter::GetProperty(const std::string &name)
+{
+	if (name == "current_platform")
+	{
+		auto platform = m_debugger.GetSelectedPlatform();
+		return new Metadata(platform.GetName());
+	}
+	else if (name == "platforms")
+	{
+		std::vector<std::string> platforms;
+		for (size_t i = 0; i < m_debugger.GetNumAvailablePlatforms(); i++)
+		{
+			auto platform = m_debugger.GetAvailablePlatformInfoAtIndex(i);
+		}
+//		return Metadata(platforms);
+	}
+	return nullptr;
+}
+
+
+bool LldbAdapter::SetProperty(const std::string &name, const Ref<Metadata> &value)
+{
+	return false;
+}

core/adapters/lldbadapter.h

@@ -110,6 +110,10 @@ namespace BinaryNinjaDebugger {
 		void WriteStdin(const std::string& msg) override;
 
 		void FixActiveThread();
+
+		Ref<Metadata> GetProperty(const std::string& name) override;
+
+		bool SetProperty(const std::string& name, const Ref<Metadata>& value) override;
 	};
 
 	class LldbAdapterType: public DebugAdapterType

core/debugadapter.h

@@ -273,8 +273,8 @@ namespace BinaryNinjaDebugger
 
 		virtual void WriteStdin(const std::string& msg);
 
-        BinaryNinja::Ref<BinaryNinja::Metadata> GetProperty(const std::string& name);
+        virtual BinaryNinja::Ref<BinaryNinja::Metadata> GetProperty(const std::string& name);
 
-        bool SetProperty(const std::string& name, const BinaryNinja::Ref<BinaryNinja::Metadata>& value);
+        virtual bool SetProperty(const std::string& name, const BinaryNinja::Ref<BinaryNinja::Metadata>& value);
 	};
 };

ui/debugserversetting.cpp

@@ -36,16 +36,16 @@ DebugServerSettingsDialog::DebugServerSettingsDialog(QWidget* parent, DebuggerCo
     titleLayout->setContentsMargins(0, 0, 0, 0);
 
     m_platformEntry = new QComboBox(this);
-    auto platformsMetaData = m_controller->GetAdapterProperty("platforms");
-    if (platformsMetaData->IsStringList())
-    {
-        auto platforms = platformsMetaData->GetStringList();
-        for (const auto& platform: platforms)
-            m_platformEntry->addItem(QString::fromStdString(platform));
-    }
+//    auto platformsMetaData = m_controller->GetAdapterProperty("platforms");
+//    if (platformsMetaData->IsStringList())
+//    {
+//        auto platforms = platformsMetaData->GetStringList();
+//        for (const auto& platform: platforms)
+//            m_platformEntry->addItem(QString::fromStdString(platform));
+//    }
 
     auto currentPlatformMetadata = m_controller->GetAdapterProperty("current_platform");
-    if (currentPlatformMetadata->IsString())
+    if (currentPlatformMetadata && currentPlatformMetadata->IsString())
     {
         const auto currentPlatform = currentPlatformMetadata->GetString();
         m_platformEntry->setCurrentText(QString::fromStdString(currentPlatform));
@@ -55,6 +55,7 @@ DebugServerSettingsDialog::DebugServerSettingsDialog(QWidget* parent, DebuggerCo
     m_portEntry = new QLineEdit(this);
 
     QFormLayout* formLayout = new QFormLayout;
+    formLayout->addRow("Platform", m_platformEntry);
     formLayout->addRow("Host", m_addressEntry);
     formLayout->addRow("Port", m_portEntry);