Fix type errors

Author: amrit110

.github/workflows/code_checks.yml

@@ -43,9 +43,21 @@ jobs:
         with:
           python-version-file: ".python-version"
 
+      - name: "Set up Node.js"
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+          cache-dependency-path: 'dashboard/package-lock.json'
+
       - name: Install the project
         run: uv sync --all-extras --dev
 
+      - name: Install dashboard dependencies
+        run: |
+          cd dashboard
+          npm ci
+
       - name: Install dependencies and check code
         run: |
           source .venv/bin/activate

dashboard/components/overview-table.tsx

@@ -67,7 +67,7 @@ export default function OverviewTable({ prSummaries }: OverviewTableProps) {
             className="w-full"
           >
             <option value="all">All Statuses</option>
-            {filterOptions['status']?.map((status: string) => (
+            {(filterOptions['status'] as string[] | undefined)?.map((status) => (
               <option key={status} value={status}>
                 {status.replace('_', ' ')}
               </option>
@@ -85,7 +85,7 @@ export default function OverviewTable({ prSummaries }: OverviewTableProps) {
             className="w-full"
           >
             <option value="all">All Failure Types</option>
-            {filterOptions['failure_type']?.map((type: string) => (
+            {(filterOptions['failure_type'] as string[] | undefined)?.map((type) => (
               <option key={type} value={type}>
                 {type}
               </option>

dashboard/components/pr-velocity-chart.tsx

@@ -161,7 +161,7 @@ export default function PRVelocityChart({ prSummaries }: PRVelocityChartProps) {
                     </text>
                   )
                 }
-                return null
+                return <g />
               }}
             />
             <YAxis

dashboard/lib/hooks.ts

@@ -33,7 +33,7 @@ export function useTableData<T extends Record<string, unknown>>(
 
   // Get unique values for each filter field
   const filterOptions = useMemo(() => {
-    const options: Record<string, unknown[]> = {}
+    const options: Record<string, T[keyof T][]> = {}
     filterFields.forEach(field => {
       options[field as string] = getUniqueValues(data, field)
     })

dashboard/lib/types.ts

@@ -98,7 +98,7 @@ export interface TraceIndex {
 }
 
 // PR summary for overview table
-export interface PRSummary {
+export interface PRSummary extends Record<string, unknown> {
   repo: string
   pr_number: number
   title: string

dashboard/lib/utils.ts

@@ -95,17 +95,20 @@ export function sortBy<T>(
   direction: 'asc' | 'desc' = 'asc'
 ): T[] {
   return [...array].sort((a, b) => {
-    let aVal = a[field]
-    let bVal = b[field]
+    const aVal = a[field]
+    const bVal = b[field]
 
     // Handle null/undefined
     if (aVal == null) return 1
     if (bVal == null) return -1
 
     // Handle dates
     if (aVal instanceof Date && bVal instanceof Date) {
-      aVal = aVal.getTime() as number
-      bVal = bVal.getTime() as number
+      const aTime = aVal.getTime()
+      const bTime = bVal.getTime()
+      if (aTime < bTime) return direction === 'asc' ? -1 : 1
+      if (aTime > bTime) return direction === 'asc' ? 1 : -1
+      return 0
     }
 
     if (aVal < bVal) return direction === 'asc' ? -1 : 1
@@ -136,9 +139,9 @@ export function searchFilter<T>(
 /**
  * Get unique values from array for a specific field
  */
-export function getUniqueValues<T>(items: T[], field: keyof T): unknown[] {
+export function getUniqueValues<T, K extends keyof T>(items: T[], field: K): T[K][] {
   const uniqueSet = new Set(items.map(item => item[field]).filter(Boolean))
-  return Array.from(uniqueSet)
+  return Array.from(uniqueSet) as T[K][]
 }
 
 /**