Merge pull request #9 from VectorInstitute/add_pyproject.toml

amrit110 · web-flow · commit 4e1237a46f94 · 2025-10-30T11:43:44.000-04:00
Add pyproject.toml and run pre-commit
diff --git a/.github/workflows/deploy_coder_gcp.yml b/.github/workflows/deploy_coder_gcp.yml
@@ -40,7 +40,7 @@ jobs:
       - name: Terraform Init
         working-directory: ${{ env.TF_DIR }}
         run: terraform init -backend-config="bucket=${{ vars.TF_STATE_BUCKET }}"
-      
+
       - name: Replace env variables in startup script
         working-directory: ${{ env.TF_DIR }}
         run: |
@@ -79,7 +79,7 @@ jobs:
         with:
           name: tf-artifacts
           path: ${{ env.TF_DIR }}
-      
+
       - name: Grant execute permissions to Terraform folder
         working-directory: ${{ env.TF_DIR }}
         run: chmod -R +x .terraform/
diff --git a/.gitignore b/.gitignore
@@ -29,4 +29,4 @@ terraform.tfvars
 .terraform.lock.hcl
 .terraform.tfstate.lock.info
 
-.coder
+.coder
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -0,0 +1,61 @@
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v6.0.0  # Use the ref you want to point at
+    hooks:
+    - id: trailing-whitespace
+    - id: check-ast
+    - id: check-builtin-literals
+    - id: check-docstring-first
+    - id: check-executables-have-shebangs
+    - id: debug-statements
+    - id: end-of-file-fixer
+    - id: mixed-line-ending
+      args: [--fix=lf]
+    - id: fix-byte-order-marker
+    - id: check-merge-conflict
+    - id: check-symlinks
+    - id: detect-private-key
+    - id: check-yaml
+      args: [--unsafe]
+    - id: check-toml
+
+  - repo: https://github.com/astral-sh/uv-pre-commit
+    rev: 0.8.23
+    hooks:
+      - id: uv-lock
+
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: 'v0.13.3'
+    hooks:
+    - id: ruff-check
+      args: [--fix, --exit-non-zero-on-fix]
+      types_or: [python, jupyter]
+    - id: ruff-format
+      types_or: [python, jupyter]
+
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v1.18.2
+    hooks:
+    - id: mypy
+      entry: python3 -m mypy --config-file pyproject.toml
+      language: system
+      types: [python]
+      exclude: "tests"
+
+  - repo: https://github.com/crate-ci/typos
+    rev: v1
+    hooks:
+      - id: typos
+        args: []
+
+ci:
+    autofix_commit_msg: |
+        [pre-commit.ci] Add auto fixes from pre-commit.com hooks
+
+        for more information, see https://pre-commit.ci
+    autofix_prs: true
+    autoupdate_branch: ''
+    autoupdate_commit_msg: '[pre-commit.ci] pre-commit autoupdate'
+    autoupdate_schedule: weekly
+    skip: [pytest,doctest,mypy]
+    submodules: false
diff --git a/README.md b/README.md
@@ -6,22 +6,22 @@ The folder `coder` contains all resources needed to deploy a [Coder](https://cod
 
 ### Structure
 
-- **deploy/**  
-  Terraform scripts and startup automation for provisioning the Coder server on a GCP VM.  
-  
-- **docker/**  
-  Dockerfiles and guides for building custom images used by Coder workspace templates.  
+- **deploy/**
+  Terraform scripts and startup automation for provisioning the Coder server on a GCP VM.
 
-- **templates/**  
-  Coder workspace templates for reproducible, containerized development environments on GCP.  
+- **docker/**
+  Dockerfiles and guides for building custom images used by Coder workspace templates.
+
+- **templates/**
+  Coder workspace templates for reproducible, containerized development environments on GCP.
 
 ## Usage
 
-1. **Provision Coder on GCP**  
+1. **Provision Coder on GCP**
    Follow the steps in [`deploy/README.md`](coder/deploy/README.md) to set up your GCP environment and deploy the Coder server using Terraform.
 
-2. **Build and Push Docker Images**  
+2. **Build and Push Docker Images**
    Use [`docker/README.md`](coder/docker/README.md) to build and upload Docker images required by your templates.
 
-3. **Push Workspace Templates**  
-   See [`templates/README.md`](coder/templates/README.md) for instructions on uploading workspace templates to your Coder instance.
+3. **Push Workspace Templates**
+   See [`templates/README.md`](coder/templates/README.md) for instructions on uploading workspace templates to your Coder instance.
diff --git a/coder/cli_scripts/suspend_users.sh b/coder/cli_scripts/suspend_users.sh
@@ -145,4 +145,3 @@ if [[ ${error_count} -gt 0 ]]; then
 else
     log_success "Script completed successfully"
 fi
-
diff --git a/coder/deploy/README.md b/coder/deploy/README.md
@@ -38,4 +38,4 @@ You'll need a `terraform.tfvars` file in this folder. Copy over the example file
 
 ### Stop the instance
 
-    terraform destroy -var-file=../terraform.tfvars
+    terraform destroy -var-file=../terraform.tfvars
diff --git a/coder/deploy/backend.tf b/coder/deploy/backend.tf
@@ -1,3 +1,3 @@
 terraform {
   backend "gcs" {}
-}
+}
diff --git a/coder/deploy/variables.tf b/coder/deploy/variables.tf
@@ -25,4 +25,4 @@ variable "service_account_email" {
 
 variable "vm_name" {
     type = string
-}
+}
diff --git a/coder/templates/bootcamp/README.md b/coder/templates/bootcamp/README.md
@@ -21,22 +21,22 @@ This template provisions Coder workspaces on Google Cloud Platform (GCP) for Vec
 
 ## Usage
 
-1. **Configure Variables**  
+1. **Configure Variables**
    Copy `terraform.tfvars.example` to `terraform.tfvars` and update values:
    - `project`, `region`, `zone`: GCP settings
    - `machine_type`: VM type (e.g., `e2-medium`)
    - `container_image`: Docker image URI
    - `jupyterlab`, `codeserver`, `streamlit`: `"true"` or `"false"` to enable apps
    - `github_repo`, `github_branch`: Repository and branch to clone
 
-2. **Push Template to Coder**  
+2. **Push Template to Coder**
    ```sh
    coder login <your-coder-instance-url>
    cp terraform.tfvars.example terraform.tfvars
    coder templates push
    ```
 
-3. **Verify Workspace**  
+3. **Verify Workspace**
    Launch a workspace from the Coder dashboard and confirm your environment is set up.
 
 ## Reference
@@ -45,5 +45,5 @@ This template provisions Coder workspaces on Google Cloud Platform (GCP) for Vec
 - [GCP VM Documentation](https://cloud.google.com/compute/docs/instances)
 - [Docker Build & Push Guide](../../docker/README.md)
 
-> **Note:**  
-> This template is a starting point. Customize the Terraform files and Docker images to fit your
+> **Note:**
+> This template is a starting point. Customize the Terraform files and Docker images to fit your
diff --git a/coder/templates/bootcamp/variables.tf b/coder/templates/bootcamp/variables.tf
@@ -47,4 +47,4 @@ variable github_app_id {
 
 variable container_image {
     type = string
-}
+}
diff --git a/coder/templates/bootcamp_gpu/README.md b/coder/templates/bootcamp_gpu/README.md
@@ -21,22 +21,22 @@ This template provisions Coder workspaces on Google Cloud Platform (GCP) with GP
 
 ## Usage
 
-1. **Configure Variables**  
+1. **Configure Variables**
    Copy `terraform.tfvars.example` to `terraform.tfvars` and update values:
    - `project`, `region`, `zone`: GCP settings
    - `machine_type`: VM type (e.g., `n1-standard-4`)
    - `guest_accelerator_type`: GPU type (e.g., `nvidia-tesla-t4`)
    - `container_image`: Docker image URI
    - `jupyterlab`, `codeserver`, `streamlit`: `"true"` or `"false"` to enable apps
 
-2. **Push Template to Coder**  
+2. **Push Template to Coder**
    ```sh
    coder login <your-coder-instance-url>
    cp terraform.tfvars.example terraform.tfvars
    coder templates push <template-name>
    ```
 
-3. **Verify Workspace**  
+3. **Verify Workspace**
    Launch a workspace from the Coder dashboard and confirm GPU availability (e.g., `nvidia-smi`).
 
 ## Reference
@@ -45,5 +45,5 @@ This template provisions Coder workspaces on Google Cloud Platform (GCP) with GP
 - [GCP GPU VM Documentation](https://cloud.google.com/compute/docs/gpus)
 - [Docker CUDA Images](https://hub.docker.com/r/nvidia/cuda)
 
-> **Note:**  
-> This template is a starting point. Customize the Terraform files and Docker images to fit your bootcamp requirements.
+> **Note:**
+> This template is a starting point. Customize the Terraform files and Docker images to fit your bootcamp requirements.
diff --git a/coder/templates/bootcamp_gpu/main.tf b/coder/templates/bootcamp_gpu/main.tf
@@ -42,7 +42,7 @@ resource "coder_agent" "main" {
     set -e
 
     export PATH="/home/${local.username}/.local/bin:$PATH"
-    
+
     echo "Changing permissions of /home/${local.username} folder"
     sudo chown -R ${local.username}:${local.username} /home/${local.username}
 
@@ -129,7 +129,7 @@ module "gce-container" {
         value = "all"
       },
       {
-        name  = "NVIDIA_DRIVER_CAPABILITIES" 
+        name  = "NVIDIA_DRIVER_CAPABILITIES"
         value = "all"
       }
     ]
@@ -158,7 +158,7 @@ module "gce-container" {
       }
     ]
   }
-  
+
   # Declare the volumes
   volumes = [
     {
@@ -201,72 +201,72 @@ resource "google_compute_instance" "dev" {
   zone         = var.zone
   count        = data.coder_workspace.me.start_count
   name         = "coder-${lower(data.coder_workspace_owner.me.name)}-${lower(data.coder_workspace.me.name)}"
-  
+
   # Use N1 machine type for T4 GPU compatibility
   machine_type = var.machine_type # Should be n1-standard-* for T4 GPUs
-  
+
   # GPU configuration for T4
   guest_accelerator {
     type  = var.guest_accelerator_type
     count = 1
   }
-  
+
   # Required for GPU instances
   scheduling {
     on_host_maintenance = "TERMINATE"
   }
-  
+
   network_interface {
     network = "default"
     access_config {
       // Ephemeral public IP
     }
   }
-  
+
   boot_disk {
     initialize_params {
       # Use Container-Optimized OS with GPU support (milestone 85+)
       image = "cos-cloud/cos-stable"
       size  = 50 # Increased size for GPU drivers
     }
   }
-  
+
   attached_disk {
     source      = google_compute_disk.pd.self_link
     device_name = "data-disk-0"
     mode        = "READ_WRITE"
   }
-  
+
   service_account {
     email = data.google_compute_default_service_account.default.email
     scopes = [
       "https://www.googleapis.com/auth/cloud-platform",
       "https://www.googleapis.com/auth/devstorage.read_only" # Required for cos-extensions
     ]
   }
-  
+
   metadata = {
     "gce-container-declaration" = module.gce-container.metadata_value
     # Add startup script to install GPU drivers
     "startup-script" = <<-EOF
       #!/bin/bash
       # Install GPU drivers
       sudo cos-extensions install gpu
-      
+
       # Make drivers executable (required for COS)
       sudo mount --bind /var/lib/nvidia /var/lib/nvidia
       sudo mount -o remount,exec /var/lib/nvidia
-      
+
       # Restart docker to pick up GPU runtime
       sudo systemctl restart docker
     EOF
   }
-  
+
   labels = {
     container-vm = module.gce-container.vm_container_label
     gpu-type     = "nvidia-tesla-t4"
   }
-  
+
   # Add network tags if you need specific firewall rules
   tags = ["gpu-instance", "coder-workspace"]
 }
diff --git a/coder/templates/bootcamp_gpu/variables.tf b/coder/templates/bootcamp_gpu/variables.tf
@@ -51,4 +51,4 @@ variable container_image {
 
 variable guest_accelerator_type {
     type = string
-}
+}
diff --git a/pyproject.toml b/pyproject.toml
diff --git a/uv.lock b/uv.lock

-Original file line number
+Diff line change
 else
     log_success "Script completed successfully"
 fi
+-
Original file line number	Diff line number	Diff line change
@@ -38,4 +38,4 @@ You'll need a `terraform.tfvars` file in this folder. Copy over the example file
`38`	`38`
`39`	`39`	`### Stop the instance`
`40`	`40`
`41`		`- terraform destroy -var-file=../terraform.tfvars`
	`41`	`+ terraform destroy -var-file=../terraform.tfvars`