Skip to content

Commit 5220432

Browse files
authored
👷‍♂️ Add solc 0.8.33 to CI (#1505)
* Bump solc version * Update solc version * Skip 0.8.32 version * T * T
1 parent cbcfe00 commit 5220432

File tree

3 files changed

+20
-13
lines changed

3 files changed

+20
-13
lines changed

.github/workflows/ci-all-via-ir.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,11 @@ jobs:
4545
forge test --use 0.8.16 --via-ir &&
4646
forge test --use 0.8.17 --via-ir
4747
) ||
48+
# NOTE: skipping solc 0.8.32 due to compiler bug
49+
# https://github.com/argotorg/solidity/issues/16360
4850
( [ "${{ matrix.profile }}" = "via-ir-3" ] &&
51+
forge test --use 0.8.33 --via-ir &&
52+
forge test --use 0.8.31 --via-ir &&
4953
forge test --use 0.8.30 --via-ir &&
5054
forge test --use 0.8.29 --via-ir &&
5155
forge test --use 0.8.28 --via-ir &&

.github/workflows/ci.yml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
runs-on: ubuntu-latest
1717
strategy:
1818
matrix:
19-
profile: [post-prague,post-prague-via-ir,solc-past-versions-0,solc-past-versions-1,via-ir,min-solc,min-solc-via-ir,intense]
19+
profile: [post-osaka,post-osaka-via-ir,solc-past-versions-0,solc-past-versions-1,via-ir,min-solc,min-solc-via-ir,intense]
2020
steps:
2121
- uses: actions/checkout@v5
2222
- name: Install Foundry Stable
@@ -25,15 +25,17 @@ jobs:
2525
version: stable
2626
- name: Install Dependencies
2727
run: forge install
28+
# NOTE: skipping solc 0.8.32 due to compiler bug
29+
# https://github.com/argotorg/solidity/issues/16360
2830
- name: Run Tests with ${{ matrix.profile }}
2931
run: >
30-
( [ "${{ matrix.profile }}" = "post-prague" ] &&
31-
FOUNDRY_PROFILE=post_prague forge test --use 0.8.30 &&
32-
FOUNDRY_PROFILE=zksync forge test --use 0.8.30
32+
( [ "${{ matrix.profile }}" = "post-osaka" ] &&
33+
FOUNDRY_PROFILE=post_osaka forge test --use 0.8.33 &&
34+
FOUNDRY_PROFILE=zksync forge test --use 0.8.33
3335
) ||
34-
( [ "${{ matrix.profile }}" = "post-prague-via-ir" ] &&
35-
FOUNDRY_PROFILE=post_prague forge test --use 0.8.30 --via-ir &&
36-
FOUNDRY_PROFILE=zksync forge test --use 0.8.30 --via-ir
36+
( [ "${{ matrix.profile }}" = "post-osaka-via-ir" ] &&
37+
FOUNDRY_PROFILE=post_osaka forge test --use 0.8.33 --via-ir &&
38+
FOUNDRY_PROFILE=zksync forge test --use 0.8.33 --via-ir
3739
) ||
3840
( [ "${{ matrix.profile }}" = "solc-past-versions-0" ] &&
3941
FOUNDRY_PROFILE=pre_global_structs forge test --use 0.8.5 --fuzz-runs 16 &&
@@ -62,8 +64,9 @@ jobs:
6264
forge test --use 0.8.26 --fuzz-runs 16 &&
6365
forge test --use 0.8.27 --fuzz-runs 16 &&
6466
forge test --use 0.8.28 --fuzz-runs 16 &&
65-
forge test --use 0.8.29 --fuzz-runs 16
66-
67+
forge test --use 0.8.29 --fuzz-runs 16 &&
68+
forge test --use 0.8.30 --fuzz-runs 16 &&
69+
forge test --use 0.8.31 --fuzz-runs 16
6770
) ||
6871
( [ "${{ matrix.profile }}" = "via-ir" ] &&
6972
forge test --via-ir

foundry.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
# The Default Profile
66
[profile.default]
7-
solc_version = "0.8.30"
8-
evm_version = "paris" # Cancun will be tested in the CI.
7+
solc_version = "0.8.33"
8+
evm_version = "paris" # osaka will be tested in the CI.
99
auto_detect_solc = false
1010
optimizer = true
1111
optimizer_runs = 1_000
@@ -20,8 +20,8 @@ remappings = [
2020
skip = ["*/g/*", "*/*7702*", "*/*BlockHashLib*", "*/*Transient*", "*/ext/ithaca/*", "*/ext/zksync/*"]
2121

2222

23-
[profile.post_prague]
24-
evm_version = "prague"
23+
[profile.post_osaka]
24+
evm_version = "osaka"
2525
skip = ["*/ext/ithaca/*"]
2626

2727
[profile.zksync]

0 commit comments

Comments
 (0)