Bugfix: Assume that if AMP_CONTEXT_DATA is an object that it is an instance of context (ampproject#40267)

The setupMetadata_ Object is currently passed in a context object from
ads safeframe code which causes a parsing error that is silently caught
by the wrapping top level try/catch in https://github.com/ampproject/amphtml/blob/6a610ba7734d8bfced751644876e9f72e9108725/3p/ampcontext-lib.js#L19-L27

Author: erwinmombay

3p/ampcontext.js

@@ -326,7 +326,7 @@ export class AbstractAmpContext {
   /**
    *  Parse the metadata attributes from the name and add them to
    *  the class instance.
-   *  @param {!Object|string} data
+   *  @param {string} data
    *  @private
    */
   setupMetadata_(data) {
@@ -346,6 +346,17 @@ export class AbstractAmpContext {
       delete this.data['_context'];
     }
 
+    this.setupMetadataFromContext_(context);
+
+    this.embedType_ = dataObject.type || null;
+  }
+
+  /**
+   *  Set the metadata attributes from the "context" instance directly.
+   *  @param {!Object} context
+   *  @private
+   */
+  setupMetadataFromContext_(context) {
     this.canary = context.canary;
     this.canonicalUrl = context.canonicalUrl;
     this.clientId = context.clientId;
@@ -367,8 +378,6 @@ export class AbstractAmpContext {
     this.sourceUrl = context.sourceUrl;
     this.startTime = context.startTime;
     this.tagName = context.tagName;
-
-    this.embedType_ = dataObject.type || null;
   }
 
   /**
@@ -403,8 +412,11 @@ export class AbstractAmpContext {
     } else if (this.win_.AMP_CONTEXT_DATA) {
       if (typeof this.win_.AMP_CONTEXT_DATA == 'string') {
         this.sentinel = this.win_.AMP_CONTEXT_DATA;
+        // If AMP_CONTEXT_DATA is an Object, Assume that it is the Context Object
+        // and not inside the attributes._context which is the structure
+        // parsed from "name" on other instances.
       } else if (isObject(this.win_.AMP_CONTEXT_DATA)) {
-        this.setupMetadata_(this.win_.AMP_CONTEXT_DATA);
+        this.setupMetadataFromContext_(this.win_.AMP_CONTEXT_DATA);
       }
     } else {
       this.setupMetadata_(this.win_.name);

test/unit/test-amp-context.js

@@ -103,8 +103,8 @@ describes.sandboxed('3p ampcontext.js', {}, (env) => {
     expect(context.referrer).to.equal('baz.net');
   });
 
-  it('should add metadata to window.context using window var.', () => {
-    win.AMP_CONTEXT_DATA = generateAttributes();
+  it('should add metadata to window.context using window global.', () => {
+    win.AMP_CONTEXT_DATA = generateAMPConfigObject();
     const context = new AmpContext(win);
     expect(context.location).to.deep.equal({
       'hash': '',
@@ -393,6 +393,20 @@ describes.sandboxed('3p ampcontext.js', {}, (env) => {
   });
 });
 
+function generateAMPConfigObject() {
+  return {
+    location: {
+      href: 'https://foo.com/a?b=c',
+    },
+    canonicalUrl: 'https://bar.com',
+    pageViewId: '1',
+    pageViewId64: 'abcdef',
+    sentinel: '1-291921',
+    startTime: 0,
+    referrer: 'baz.net',
+  };
+}
+
 function generateSerializedAttributes(opt_sentinel) {
   return JSON.stringify(generateAttributes(opt_sentinel));
 }