Upload Function/Plugin Minimum Filesize Bug

[cwlangford]

When using the upload function, with the SSH accessor, I have noticed that files under a certain filesize (file size not known) are uploading without any of there date resulting in a file with 0 bytes.

Artifact:

author: CL

type: SERVER

parameters:
  - name: TargetHost
    description: <IP address:PortNo>
  - name: TargetUsername
    description: Enter the username that will be used to establish your SSH connection to your remote host.
  - name: TargetPassword
    description:  Enter the password that will be used to establish your SSH connection to your remote host.
  - name: TargetDirectory
    description: Enter the full directory path housing the files you wish to retrieve.
    default: /var/log/*

sources:
  - query: |
        LET SSH_CONFIG <= dict(
            hostname=TargetHost,
            username=TargetUsername,
            password=TargetPassword
        )
        SELECT OSPath, upload(file=OSPath, accessor='ssh')
        FROM glob(globs=TargetDirectory, accessor='ssh')`

Result:

Troubleshooting:

• Originally observed issue on 74.1 and have since upgraded to the latest version and can confirm issue is still present.
• I noticed, and as you can see in the original screenshot, only files with lots of data in were being uploaded. Auth.log was uploading however auth.log.1 wasn't. As you can see in the screenshot below this has data in, albeit less than auth.log and the same permissions and ownership.

• All evidence indicates files under a certain size are not being uploaded. To test this I pushed auth.log data into boot.log and re-run the artifact and can confirm boot.log is now uploading. I tried it again with another file that had a small amount of data already but wasn't uploading and now that file is also uploading. These tests suggests there is a minimum file size required before the upload function works.

[predictiple]

The problem happens only when using uploads() with the ssh accessor via a notebook or server artifact.

Test notebook query:

LET SSH_CONFIG <= dict(secret="alpine")

SELECT OSPath,
       Mtime,
       Size,
       upload(file=OSPath, accessor="ssh") AS FileUpload
FROM glob(globs='/var/log/*', accessor='ssh')

---

When run via a client it works as expected...

Test artifact:

name: SSH.Upload
description: |
  Uploads files from a remote host via the SSH accessor.
  The remote host and access credentials are defined in a server secret.

type: CLIENT

sources:
  - query: |
      LET SSH_CONFIG <= dict(secret="alpine")
      
      SELECT OSPath,
             Mtime,
             Size,
             upload(file=OSPath, accessor="ssh") AS FilePreview
      FROM glob(globs='/var/log/*', accessor='ssh')

column_types:
  - name: FilePreview
    type: preview_upload
  - name: Size
    type: mb

[scudette]

Fixed by #4650