removed validation for ca revoke capability

* removed validation for ca revoke capability

* removed test related to ca revoke validation

* removed not used ca revoke data

Author: angelmoo

pkg/venafi/cloud/cloud.go

@@ -74,16 +74,6 @@ const (
 	TeamType
 )
 
-var CATypesSupportedForRevocationSlice = []string{
-	"DIGICERT", "MICROSOFT", "ZTPKI",
-}
-
-var CATypesSupportedForRevocation = map[string]bool{
-	CATypesSupportedForRevocationSlice[0]: true,
-	CATypesSupportedForRevocationSlice[1]: true,
-	CATypesSupportedForRevocationSlice[2]: true,
-}
-
 // RevocationReasonsMap maps *certificate.RevocationRequest.Reason to ca-operations reasons
 var RevocationReasonsMap = map[string]service.RevocationReason{
 	"":                       service.RevocationReasonUnspecified,          // NoReason

pkg/venafi/cloud/connector.go

@@ -606,12 +606,6 @@ func (c *Connector) RevokeCertificate(revReq *certificate.RevocationRequest) (en
 			return nil, fmt.Errorf("failed to find CA account %q", revReq.CertificateAuthorityAccountName)
 		}
 
-		//validating the CAType is into the set of supported types to perform revocation
-		if !CATypesSupportedForRevocation[caAccount.CertificateAuthorityType] {
-			return nil, fmt.Errorf("the CA type of the CA account %q is not supported for revocation. "+
-				"It is only supported CA accounts of type %s", caAccount.Name, util.GetQuotedStrings(CATypesSupportedForRevocationSlice))
-		}
-
 		certificateAuthorityAccountId = &caAccount.Id
 	}
 

pkg/venafi/cloud/connector_test.go

@@ -1078,49 +1078,6 @@ func TestRevokeCertificate(t *testing.T) {
 		require.Error(t, err)
 		require.ErrorContains(t, err, fmt.Sprintf("failed to find CA account %q", revReq.CertificateAuthorityAccountName))
 	})
-	t.Run("failed-unsupported ca type", func(t *testing.T) {
-		mockCtrl := gomock.NewController(t)
-		defer mockCtrl.Finish()
-
-		caAccountId := "myId"
-		caAccountName := "MyAccountName"
-		thumbprint := "MyThumbprint"
-
-		revReq := &certificate.RevocationRequest{
-			Thumbprint:                      thumbprint,
-			Reason:                          "",
-			CertificateAuthorityAccountName: caAccountName,
-		}
-
-		//1. mocking the caAccountsClient
-		caAccountExpected := &caaccountssservice.ListCAAccountsCertificateAuthorityAccountsCertificateAuthorityAccountConnectionNodesCertificateAuthorityAccount{
-			Id:                       caAccountId,
-			Name:                     "MyAccountName",
-			CertificateAuthorityType: caaccountssservice.CertificateAuthorityTypeGlobalsign,
-		}
-
-		listCAAccountsResponse := &caaccountssservice.ListCAAccountsResponse{
-			CertificateAuthorityAccounts: &caaccountssservice.ListCAAccountsCertificateAuthorityAccountsCertificateAuthorityAccountConnection{
-				Nodes: []*caaccountssservice.ListCAAccountsCertificateAuthorityAccountsCertificateAuthorityAccountConnectionNodesCertificateAuthorityAccount{
-					caAccountExpected,
-				},
-			},
-		}
-
-		caAccountsService := mocks.NewMockCAAccountsServiceWrapper(mockCtrl)
-		caAccountsService.EXPECT().ListCAAccounts(context.Background()).Return(listCAAccountsResponse, nil)
-
-		//replacing the caAccountsService reference with the mock
-		conn.caAccountsClient.SetCAAccountsService(caAccountsService)
-
-		revokeCertificate, err := conn.RevokeCertificate(revReq)
-		require.Nil(t, revokeCertificate)
-		require.Error(t, err)
-		//require.ErrorContains(t, err, fmt.Sprintf("unsupported CA type for revocation: %s", caAccountExpected.CertificateAuthorityType))
-		require.ErrorContains(t, err, fmt.Sprintf("the CA type of the CA account %q is not supported for revocation. "+
-			"It is only supported CA accounts of type %s", caAccountExpected.Name, util.GetQuotedStrings(CATypesSupportedForRevocationSlice)))
-	})
-
 }
 
 func TestReadPolicyConfigurationOnlyEC(t *testing.T) {