Skip to content

Commit 3b0878f

Browse files
committed
fix: comments
1 parent caca99e commit 3b0878f

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

deployed-contracts/venus-erc4626.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@
3030
* VenusERC4626Factory: [`0xC6C8249a0B44973673f3Af673e530B85038a0480`](https://sepolia.arbiscan.io/address/0xC6C8249a0B44973673f3Af673e530B85038a0480)
3131
* VenusERC4626Implementation: [`0x3442ACDbCc927cC401236C69a14ca909fC5B14ba`](https://sepolia.arbiscan.io/address/0x3442ACDbCc927cC401236C69a14ca909fC5B14ba)
3232

33-
## zkSync Mainnet
33+
## ZKSync Mainnet
3434

3535
* VenusERC4626Factory: [`0xDC59Dd76Dd7A64d743C764a9aa8C96Ff2Ea8BAc3`](https://explorer.zksync.io/address/0xDC59Dd76Dd7A64d743C764a9aa8C96Ff2Ea8BAc3)
3636
* VenusERC4626Implementation: [`0xBd86974B3a7348AC153aEFEe5Dc5111246a99c11`](https://explorer.zksync.io/address/0xBd86974B3a7348AC153aEFEe5Dc5111246a99c11)
3737

38-
## zkSync Sepolia
38+
## ZKSync Sepolia
3939

4040
* VenusERC4626Factory: [`0xa30dcc21B8393A4031cD6364829CDfE2b6D7B283`](https://sepolia.explorer.zksync.io/address/0xa30dcc21B8393A4031cD6364829CDfE2b6D7B283)
4141
* VenusERC4626Implementation: [`0x97ab473c81C5E654B71690e3B4225180C687E3eB`](https://sepolia.explorer.zksync.io/address/0x97ab473c81C5E654B71690e3B4225180C687E3eB)

security-and-audits.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -703,8 +703,8 @@ These contracts were in the scope of the audits done before the launch of Isolat
703703
**Scope**: VenusERC4626 Vaults
704704

705705
* [Certik audit report](https://github.com/VenusProtocol/isolated-pools/blob/1faa46139aaec06e0eb2e48341bff22cd6c38c6c/audits/129_erc4626_certik_20250514.pdf)
706-
* [FairyProof audit report](https://github.com/VenusProtocol/isolated-pools/blob/1faa46139aaec06e0eb2e48341bff22cd6c38c6c/audits/130_erc4626_fairyproof_20250414.pdf)
707706
* [Pessimistic audit report](https://github.com/VenusProtocol/isolated-pools/blob/1faa46139aaec06e0eb2e48341bff22cd6c38c6c/audits/131_erc4626_pessimistic_20250502.pdf)
707+
* [FairyProof audit report](https://github.com/VenusProtocol/isolated-pools/blob/1faa46139aaec06e0eb2e48341bff22cd6c38c6c/audits/130_erc4626_fairyproof_20250414.pdf)
708708

709709
<details>
710710
<summary>Detailed scope</summary>

technical-reference/reference-technical-articles/venus-erc-4626.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,12 @@ contract VenusERC4626 is
192192

193193
#### Core ERC-4626 Functions
194194

195-
- **`deposit(uint256 assets, address receiver)`**: Deposits assets and mints shares to the receiver.
196-
- **`mint(uint256 shares, address receiver)`**: Mints exact shares by depositing required assets.
197-
- **`withdraw(uint256 assets, address receiver, address owner)`**: Withdraws exact assets and burns shares from the owner.
195+
- **`deposit(uint256 assets, address receiver)`**: Deposits assets and mints shares to the receiver.
196+
- Note - It can mint slightly fewer shares than requested, because vToken.mint rounds down.
197+
- **`mint(uint256 shares, address receiver)`**: Mints exact shares by depositing required assets.
198+
- Note - It can mint slightly fewer shares than requested, because vToken.mint rounds down.
199+
- **`withdraw(uint256 assets, address receiver, address owner)`**: Withdraws exact assets and burns shares from the owner.
200+
- Note - Receiver can receive slightly more assets than requested, because VToken.redeemUnderlying rounds up
198201
- **`redeem(uint256 shares, address receiver, address owner)`**: Redeems exact shares and transfers assets to the receiver.
199202
- **`totalAssets()`**: Returns the total underlying assets held by the vault.
200203

0 commit comments

Comments
 (0)