linting and added more tests

Author: frastel

tests/VerbalExpressions/PHPVerbalExpressions/VerbalExpressionsTest.php

@@ -4,29 +4,61 @@
 
 class VerbalExpressionsTest extends \PHPUnit_Framework_TestCase
 {
+    /**
+     * @dataProvider provideValidUrls
+     * @group        functional
+     */
+    public function testShouldPassWhenValidUrlGiven($url)
+    {
+        $regex = new VerbalExpressions();
+        $this->buildUrlPattern($regex);
+
+        $this->assertTrue($regex->test($url));
+    }
+
+    static public function provideValidUrls()
+    {
+        return array(
+            array('http://github.com'),
+            array('http://www.github.com'),
+            array('https://github.com'),
+            array('https://github.com'),
+            array('https://github.com/blog'),
+            array('https://foobar.github.com')
+        );
+    }
 
     /**
-     * @dataProvider provideUrls
+     * @dataProvider provideInvalidUrls
+     * @group        functional
      */
-    public function testUrlPatterns($url)
+    public function testShouldFailWithInvalidUrls($url)
     {
         $regex = new VerbalExpressions();
+        $this->buildUrlPattern($regex);
+
+        $this->assertFalse($regex->test($url));
+    }
 
-        $regex->startOfLine()
+    static public function provideInvalidUrls()
+    {
+        return array(
+            array(' http://github.com'),
+            array('foo'),
+            array('htps://github.com'),
+            array('http:/github.com'),
+            array('https://github.com /blog'),
+        );
+    }
+
+    protected function buildUrlPattern(VerbalExpressions $regex)
+    {
+        return $regex->startOfLine()
             ->then("http")
             ->maybe("s")
             ->then("://")
             ->maybe("www.")
             ->anythingBut(" ")
             ->endOfLine();
-
-        $this->assertTrue($regex->test($url));
-    }
-
-    static public function provideUrls()
-    {
-        return array(
-            array('http://github.com')
-        );
     }
-}
+}