feat: add game-hop proof widgets for examples#154
Conversation
Surface OneTimePad and ElGamal as readable infoview game-hop diagrams so the proof structure and source anchors are easier to follow. Made-with: Cursor
🤖 Gemini PR SummaryInfrastructure
Interactive UI and Widgets
Proof Visualization
Statistics
Lean Declarations ✏️ **Added:** 19 declaration(s)
📄 **Per-File Summaries**
Last updated: 2026-03-11 15:51 UTC. |
🤖 Initial AI review without external context🤖 AI ReviewReviewed Revision
Overall Summary: 1. TL;DRThe foundational models, cryptography examples, and UI widget infrastructures in this PR are structurally sound and well-formalized. However, a couple of files contain hallucinated file-header syntax that will cause immediate parsing errors and break the build, requiring a quick cleanup before this can be merged. 2. Checklist CoverageNo explicit specification checklist was provided for this PR. 3. Key Lean 4 / Mathlib Issues
Minor Nitpicks & Polish:
4. Overall VerdictChanges Requested 📄 **Review for `Examples/ElGamal.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: 📄 **Review for `Examples/OneTimePad.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: 📄 **Review for `VCVio/CryptoFoundations/SymmEncAlg.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: 📄 **Review for `VCVioWidgets.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: 📄 **Review for `VCVioWidgets/Component/RevealLocation.lean`**Verdict: Changes Requested Critical Misformalizations: Lean 4 / Mathlib Issues:
Nitpicks: 📄 **Review for `VCVioWidgets/GameHop/Anchor.lean`**Verdict: Needs Minor Revisions Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks:
📄 **Review for `VCVioWidgets/GameHop/Examples/ElGamal.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: 📄 **Review for `VCVioWidgets/GameHop/Examples/OneTimePad.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: (The file correctly instantiates the 📄 **Review for `VCVioWidgets/GameHop/Lookup.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: 📄 **Review for `VCVioWidgets/GameHop/Model.lean`**Verdict: Changes Requested Critical Misformalizations: Lean 4 / Mathlib Issues:
Nitpicks:
📄 **Review for `VCVioWidgets/GameHop/Panel.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: 📄 **Review for `VCVioWidgets/GameHop/Render.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: 📄 **Review for `lakefile.lean`**Verdict: Approved Critical Misformalizations: Lean 4 / Mathlib Issues: Nitpicks: |
There was a problem hiding this comment.
Automated AI review refreshed.
Trigger: PR synchronize event
Updated review comment: #154 (comment)
Workflow run: https://github.com/Verified-zkEVM/VCV-io/actions/runs/22934623059
Head SHA: 0e53a6681a6402708944840df0ae6be1321a28f9
Use Lean name literals and direct boolean predicates so the diagram specs stay idiomatic and easier to read during review. Made-with: Cursor
|
Addressed the actionable Gemini nits in
I also re-ran The remaining Gemini "changes requested" items are false positives for this repo/toolchain:
|
There was a problem hiding this comment.
Automated AI review refreshed.
Trigger: PR synchronize event
Updated review comment: #154 (comment)
Workflow run: https://github.com/Verified-zkEVM/VCV-io/actions/runs/22939616192
Head SHA: 888927f857180fd0f81dfa37fdcaaaac721facc6
Made-with: Cursor
Keep GameHop diagrams visible while navigating related proof files by replacing the command-scoped widget with a persistent panel host and module-based lookup. Made-with: Cursor
Make persistent game-hop panels navigate from full cards and snippets so clickthrough works reliably in the infoview. Reflow theorem snippets for narrow widget cards so linked statements stay readable. Made-with: Cursor
Summary
VCVioWidgetsLean library for infoview proof visualizationsTest plan
lake buildExamples/OneTimePad.leanin the infoview and verify the widget layout and clickback targetsExamples/ElGamal.leanin the infoview and verify the widget layout and clickback targetsMade with Cursor