better logging perf

Author: SimonCropp

src/DiffEngineTray/DiffToolLauncher.cs

@@ -6,7 +6,7 @@ static class DiffToolLauncher
     public static void Launch(TrackedMove move)
     {
         var process = move.Process;
-        if (process is {HasExited: false})
+        if (process is { HasExited: false })
         {
             if (SetForegroundWindow(process.MainWindowHandle))
             {
@@ -40,19 +40,22 @@ public static void Launch(TrackedMove move)
             }
 
             Log.Error(
-                $"""
-                 Failed to launch diff tool.
-                 {move.Exe} {move.Arguments}
-                 """);
+                """
+                Failed to launch diff tool.
+                {Exe} {Arguments}
+                """,
+                move.Exe, move.Arguments);
         }
         catch (Exception exception)
         {
             Log.Error(
                 exception,
-                $"""
-                 Failed to launch diff tool.
-                 {move.Exe} {move.Arguments}
-                 """);
+                """
+                Failed to launch diff tool.
+                {Exe} {Arguments}
+                """,
+                move.Exe,
+                move.Arguments);
         }
     }
 }

src/DiffEngineTray/FileEx.cs

@@ -19,7 +19,7 @@ public static bool SafeDeleteFile(string path)
         }
         catch (IOException exception)
         {
-            Log.Error(exception, $"Failed to delete '{path}'.");
+            Log.Error(exception, "Failed to delete '{Path}'.", path);
             //Swallow this since it is likely that a running test it reading or
             //writing to the files, and the result will re-add the tracked item
         }
@@ -48,7 +48,7 @@ public static void SafeDeleteDirectory(string path)
         }
         catch (IOException exception)
         {
-            Log.Error(exception, $"Failed to delete '{path}'.");
+            Log.Error(exception, "Failed to delete '{Path}'.", path);
         }
         catch (Exception exception)
         {
@@ -61,7 +61,7 @@ public static bool SafeMove(string temp, string target)
         //Swallow this since it is likely that a running test it reading or
         //writing to the files, and the result will re-add the tracked item
         void HandleAccessException(Exception exception) =>
-            Log.Error(exception, $"Failed to move '{temp}' to '{target}'.");
+            Log.Error(exception, "Failed to move '{Temp}' to '{Target}'.", temp, target);
 
         if (!File.Exists(temp))
         {

src/DiffEngineTray/Program.cs

@@ -125,9 +125,8 @@ static void ReBindKeys(Settings settings, KeyRegister keyRegister, Tracker track
         }
         catch (Exception exception)
         {
-            var message = $"Cannot start. Failed to read settings: {SettingsHelper.FilePath}";
-            Log.Fatal(exception, message);
-            IssueLauncher.LaunchForException(message, exception);
+            Log.Fatal(exception, "Cannot start. Failed to read settings: {FilePath}", SettingsHelper.FilePath);
+            IssueLauncher.LaunchForException($"Cannot start. Failed to read settings: {SettingsHelper.FilePath}", exception);
             return null;
         }
     }

src/DiffEngineTray/Tracker.cs

@@ -271,13 +271,13 @@ static void KillProcesses(TrackedMove move)
     {
         if (!move.CanKill)
         {
-            Log.Information($"Did not kill for `{move.Name}` since CanKill=false");
+            Log.Information("Did not kill for `{Name}` since CanKill=false", move.Name);
             return;
         }
 
         if (move.Process == null)
         {
-            Log.Information($"No processes to kill for `{move.Name}`");
+            Log.Information("No processes to kill for `{Name}`", move.Name);
             return;
         }