Skip to content

Commit 86a8487

Browse files
committed
.
1 parent 223c776 commit 86a8487

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

docs/diff-tool.custom.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ var resolvedTool = DiffTools.AddToolBasedOn(
3939
Left: (temp, target) => $"\"custom args \"{target}\" \"{temp}\"",
4040
Right: (temp, target) => $"\"custom args \"{temp}\" \"{target}\""))!;
4141
```
42-
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L83-L92' title='Snippet source file'>snippet source</a> | <a href='#snippet-AddToolBasedOn' title='Start of snippet'>anchor</a></sup>
42+
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L82-L91' title='Snippet source file'>snippet source</a> | <a href='#snippet-AddToolBasedOn' title='Start of snippet'>anchor</a></sup>
4343
<!-- endSnippet -->
4444

4545

@@ -69,7 +69,7 @@ var resolvedTool = DiffTools.AddToolBasedOn(
6969

7070
await DiffRunner.LaunchAsync(resolvedTool!, "PathToTempFile", "PathToTargetFile");
7171
```
72-
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L103-L114' title='Snippet source file'>snippet source</a> | <a href='#snippet-AddToolAndLaunch' title='Start of snippet'>anchor</a></sup>
72+
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L102-L113' title='Snippet source file'>snippet source</a> | <a href='#snippet-AddToolAndLaunch' title='Start of snippet'>anchor</a></sup>
7373
<!-- endSnippet -->
7474

7575

docs/diff-tool.order.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ For example `VisualStudio,Meld` will result in VisualStudio then Meld then all o
5151
```cs
5252
DiffTools.UseOrder(DiffTool.VisualStudio, DiffTool.AraxisMerge);
5353
```
54-
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L166-L170' title='Snippet source file'>snippet source</a> | <a href='#snippet-UseOrder' title='Start of snippet'>anchor</a></sup>
54+
<sup><a href='/src/DiffEngine.Tests/DiffToolsTest.cs#L165-L169' title='Snippet source file'>snippet source</a> | <a href='#snippet-UseOrder' title='Start of snippet'>anchor</a></sup>
5555
<!-- endSnippet -->

src/DiffEngine.Tests/DiffToolsTest.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void OrderShouldNotMessWithAddTool()
5959
public void TextConvention()
6060
{
6161
var diffToolPath = FakeDiffTool.Exe;
62-
var resolvedTool = DiffTools.AddTool(
62+
DiffTools.AddTool(
6363
name: "MyCustomDiffTool",
6464
autoRefresh: true,
6565
isMdi: false,
@@ -69,11 +69,10 @@ public void TextConvention()
6969
Left: (tempFile, targetFile) => $"\"{targetFile}\" \"{tempFile}\"",
7070
Right: (tempFile, targetFile) => $"\"{tempFile}\" \"{targetFile}\""),
7171
exePath: diffToolPath,
72-
binaryExtensions: [])!;
73-
DiffTools.UseOrder(DiffTool.VisualStudio, DiffTool.AraxisMerge);
74-
Assert.Equal("MyCustomDiffTool", resolvedTool.Name);
75-
Assert.True(DiffTools.TryFindByExtension(".txtConvention", out var forExtension));
76-
Assert.Equal("MyCustomDiffTool", forExtension.Name);
72+
binaryExtensions: []);
73+
var combine = Path.Combine(SourceDirectory, "input.temp.txtConvention");
74+
Assert.True(DiffTools.TryFindForInputFilePath(combine, out var tool));
75+
Assert.Equal("MyCustomDiffTool", tool.Name);
7776
}
7877

7978
#if DEBUG

src/DiffEngine/DiffTools_TryFind.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ public static bool TryFindForInputFilePath(
3232

3333
return ExtensionLookup.TryGetValue(Path.GetExtension(path), out tool);
3434
}
35+
3536
public static bool TryFindForInputFilePath(
3637
CharSpan path,
3738
[NotNullWhen(true)] out ResolvedTool? tool)
@@ -42,7 +43,7 @@ public static bool TryFindForInputFilePath(
4243
return tool != null;
4344
}
4445

45-
var extension = Path.GetExtension(path).ToString();
46+
var extension = PathPolyfill.GetExtension(path).ToString();
4647
return ExtensionLookup.TryGetValue(extension, out tool);
4748
}
4849

0 commit comments

Comments
 (0)