handle Temp* race condition

Author: SimonCropp

src/Verify/TempDirectory.cs

@@ -62,12 +62,13 @@ public static void Init()
 
         VerifierSettings.GlobalScrubbers.Add((scrubber, _, _) =>
         {
-            if (paths.Value == null)
+            var pathsValue = paths.Value;
+            if (pathsValue == null)
             {
                 return;
             }
 
-            foreach (var path in paths.Value)
+            foreach (var path in pathsValue)
             {
                 scrubber.Replace(path, "{TempDirectory}");
             }
@@ -118,13 +119,14 @@ public TempDirectory()
         Path = IoPath.Combine(RootDirectory, IoPath.GetRandomFileName());
         Directory.CreateDirectory(Path);
 
-        if (paths.Value == null)
+        var pathsValue = paths.Value;
+        if (pathsValue == null)
         {
             paths.Value = [Path];
         }
         else
         {
-            paths.Value!.Add(Path);
+            pathsValue.Add(Path);
         }
     }
 
@@ -135,7 +137,7 @@ public void Dispose()
             Directory.Delete(Path, true);
         }
 
-        paths.Value!.Remove(Path);
+        paths.Value?.Remove(Path);
     }
 
     /// <summary>

src/Verify/TempFile.cs

@@ -132,13 +132,14 @@ public TempFile(string? extension = null)
 
         Path = IoPath.Combine(RootDirectory, fileName);
 
-        if (paths.Value == null)
+        var pathsValue = paths.Value;
+        if (pathsValue == null)
         {
             paths.Value = [Path];
         }
         else
         {
-            paths.Value!.Add(Path);
+            pathsValue.Add(Path);
         }
     }
 
@@ -162,7 +163,7 @@ public void Dispose()
             File.Delete(Path);
         }
 
-        paths.Value!.Remove(Path);
+        paths.Value?.Remove(Path);
     }
 
     /// <summary>