.

Author: SimonCropp

src/Benchmarks/FilterLinesBenchmarks.cs

@@ -10,93 +10,6 @@ public class FilterLinesBenchmarks
     public void Setup()
     {
         // Small: ~1KB, 20 lines
-        _smallInput = CreateTestData(20, 50);
-
-        // Medium: ~50KB, 1000 lines
-        _mediumInput = CreateTestData(1000, 50);
-
-        // Large: ~500KB, 10000 lines
-        _largeInput = CreateTestData(10000, 50);
-    }
-
-    private static StringBuilder CreateTestData(int lineCount, int charsPerLine)
-    {
-        var sb = new StringBuilder();
-        for (var i = 0; i < lineCount; i++)
-        {
-            sb.Append(new string('x', charsPerLine));
-            sb.Append(i);
-            sb.AppendLine();
-        }
-        return sb;
-    }
-
-    // Remove every other line
-    private static bool RemoveEvenLines(ReadOnlySpan<char> line) =>
-        line.Length > 0 && char.IsDigit(line[^1]) && (line[^1] - '0') % 2 == 0;
-
-    [Benchmark(Baseline = true)]
-    public void Original_Small()
-    {
-        var sb = new StringBuilder(_smallInput.ToString());
-        sb.FilterLines_Original(RemoveEvenLines);
-    }
-
-    [Benchmark]
-    public void SpanBased_Small()
-    {
-        var sb = new StringBuilder(_smallInput.ToString());
-        sb.FilterLines_SpanBased(RemoveEvenLines);
-    }
-
-    [Benchmark]
-    public void ArrayPool_Small()
-    {
-        var sb = new StringBuilder(_smallInput.ToString());
-        sb.FilterLines_ArrayPool(RemoveEvenLines);
-    }
-
-    [Benchmark]
-    public void Original_Medium()
-    {
-        var sb = new StringBuilder(_mediumInput.ToString());
-        sb.FilterLines_Original(RemoveEvenLines);
-    }
-
-    [Benchmark]
-    public void SpanBased_Medium()
-    {
-        var sb = new StringBuilder(_mediumInput.ToString());
-        sb.FilterLines_SpanBased(RemoveEvenLines);
-    }
-
-    [Benchmark]
-    public void ArrayPool_Medium()
-    {
-        var sb = new StringBuilder(_mediumInput.ToString());
-        sb.FilterLines_ArrayPool(RemoveEvenLines);
-    }
-
-    [Benchmark]
-    public void Original_Large()
-    {
-        var sb = new StringBuilder(_largeInput.ToString());
-        sb.FilterLines_Original(RemoveEvenLines);
-    }
-
-    [Benchmark]
-    public void SpanBased_Large()
-    {
-        var sb = new StringBuilder(_largeInput.ToString());
-        sb.FilterLines_SpanBased(RemoveEvenLines);
-    }
-
-    [Benchmark]
-    public void ArrayPool_Large()
-    {
-        var sb = new StringBuilder(_largeInput.ToString());
-        sb.FilterLines_ArrayPool(RemoveEvenLines);
-
         smallInput = CreateTestData(20, 50);
 
         // Medium: ~50KB, 1000 lines
@@ -106,6 +19,10 @@ public void ArrayPool_Large()
         largeInput = CreateTestData(10000, 50);
     }
 
+    // Remove every other line
+    static bool RemoveEvenLines(ReadOnlySpan<char> line) =>
+        line.Length > 0 && char.IsDigit(line[^1]) && (line[^1] - '0') % 2 == 0;
+
     static StringBuilder CreateTestData(int lineCount, int charsPerLine)
     {
         var builder = new StringBuilder();
@@ -118,10 +35,6 @@ static StringBuilder CreateTestData(int lineCount, int charsPerLine)
         return builder;
     }
 
-    // Remove every other line
-    static bool RemoveEvenLines(ReadOnlySpan<char> line) =>
-        line.Length > 0 && char.IsDigit(line[^1]) && (line[^1] - '0') % 2 == 0;
-
     [Benchmark(Baseline = true)]
     public void Small()
     {

src/Verify.Tests/LinesScrubberTests.cs

@@ -278,7 +278,8 @@ public void FilterLines_LargeContent()
         var lines = Enumerable.Range(1, 1000).Select(i => $"line{i}");
         var builder = new StringBuilder(string.Join('\n', lines));
 
-        builder.FilterLines(line => int.Parse(line.Slice(4)) % 2 == 0);
+        //TODO: remove the ToString when added to polyfill
+        builder.FilterLines(line => int.Parse(line.Slice(4).ToString()) % 2 == 0);
 
         var remaining = builder.ToString().Split('\n');
         Assert.Equal(500, remaining.Length);

src/Verify/Extensions.cs

@@ -1,7 +1,5 @@
 // ReSharper disable UnusedVariable
 
-public delegate bool RemoveLine(CharSpan line);
-
 static class Extensions
 {
     static HashSet<Type> numericTypes =