.

Author: SimonCropp

src/Verify/Serialization/Scrubbers/CrossChunkMatcher.cs

@@ -17,6 +17,7 @@ public static void ReplaceAll<TContext>(
         CrossChunkHandler<TContext> onCrossChunk,
         WithinChunkHandler<TContext> onWithinChunk)
     {
+        Span<char> buffer = stackalloc char[maxLength];
         Span<char> carryoverBuffer = stackalloc char[maxLength - 1];
         var carryoverLength = 0;
         var previousChunkAbsoluteEnd = 0;
@@ -38,6 +39,7 @@ public static void ReplaceAll<TContext>(
                     onCrossChunk(
                         builder,
                         carryoverBuffer,
+                        buffer,
                         carryoverIndex,
                         remainingInCarryover,
                         chunkSpan,
@@ -77,6 +79,7 @@ public static void ReplaceAll<TContext>(
     public delegate void CrossChunkHandler<TContext>(
         StringBuilder builder,
         Span<char> carryoverBuffer,
+        Span<char> buffer,
         int carryoverIndex,
         int remainingInCarryover,
         CharSpan currentChunkSpan,

src/Verify/Serialization/Scrubbers/DateScrubber.cs

@@ -219,15 +219,14 @@ static void ReplaceInner(StringBuilder builder, string format, Counter counter,
     static void OnCrossChunk(
         StringBuilder builder,
         Span<char> carryoverBuffer,
+        Span<char> buffer,
         int carryoverIndex,
         int remainingInCarryover,
         CharSpan currentChunkSpan,
         int absoluteStartPosition,
         MatchContext context,
         Action<Match> addMatch)
     {
-        Span<char> combinedBuffer = stackalloc char[context.MaxLength];
-
         // Try lengths from longest to shortest (greedy matching)
         for (var length = context.MaxLength; length >= context.MinLength; length--)
         {
@@ -240,15 +239,16 @@ static void OnCrossChunk(
             }
 
             // Combine carryover and current chunk
-            carryoverBuffer.Slice(carryoverIndex, remainingInCarryover).CopyTo(combinedBuffer);
-            currentChunkSpan[..neededFromCurrent].CopyTo(combinedBuffer[remainingInCarryover..]);
+            carryoverBuffer.Slice(carryoverIndex, remainingInCarryover).CopyTo(buffer);
+            currentChunkSpan[..neededFromCurrent].CopyTo(buffer[remainingInCarryover..]);
 
-            var slice = combinedBuffer[..length];
+            var slice = buffer[..length];
 
             if (context.TryConvert(slice, context.Format, context.Counter, context.Culture, out var convert))
             {
                 addMatch(new(absoluteStartPosition, length, convert));
-                return; // Found match at this position
+                // Found match at this position
+                return;
             }
         }
     }

src/Verify/Serialization/Scrubbers/DirectoryReplacements_StringBuilder.cs

@@ -52,15 +52,14 @@ public static void Replace(StringBuilder builder, List<Pair> paths)
     static void OnCrossChunk(
         StringBuilder builder,
         Span<char> carryoverBuffer,
+        Span<char> buffer,
         int carryoverIndex,
         int remainingInCarryover,
         CharSpan currentChunkSpan,
         int absoluteStartPosition,
         MatchContext context,
         Action<Match> addMatch)
     {
-        Span<char> combinedBuffer = stackalloc char[context.MaxLength];
-
         foreach (var pair in context.Pairs)
         {
             var neededFromCurrent = pair.Find.Length - remainingInCarryover;
@@ -78,12 +77,12 @@ static void OnCrossChunk(
             }
 
             var combinedLength = remainingInCarryover + neededFromCurrent;
-            carryoverBuffer.Slice(carryoverIndex, remainingInCarryover).CopyTo(combinedBuffer);
-            currentChunkSpan[..neededFromCurrent].CopyTo(combinedBuffer[remainingInCarryover..]);
+            carryoverBuffer.Slice(carryoverIndex, remainingInCarryover).CopyTo(buffer);
+            currentChunkSpan[..neededFromCurrent].CopyTo(buffer[remainingInCarryover..]);
 
             if (!TryMatchAtCrossChunk(
                     builder,
-                    combinedBuffer[..combinedLength],
+                    buffer[..combinedLength],
                     currentChunkSpan,
                     absoluteStartPosition,
                     neededFromCurrent,

src/Verify/Serialization/Scrubbers/GuidScrubber.cs

@@ -24,6 +24,7 @@ public static void ReplaceGuids(StringBuilder builder, Counter counter)
     static void OnCrossChunk(
         StringBuilder builder,
         Span<char> carryoverBuffer,
+        Span<char> buffer,
         int carryoverIndex,
         int remainingInCarryover,
         CharSpan currentChunkSpan,
@@ -54,7 +55,6 @@ static void OnCrossChunk(
         }
 
         // Combine carryover and current chunk into buffer
-        Span<char> buffer = stackalloc char[36];
         carryoverBuffer.Slice(carryoverIndex, remainingInCarryover).CopyTo(buffer);
         currentChunkSpan[..neededFromCurrent].CopyTo(buffer[remainingInCarryover..]);