refs

Author: SimonCropp

src/.editorconfig

@@ -11,6 +11,11 @@ indent_style = space
 indent_size = 4
 charset = utf-8
 
+# Redundant accessor body
+resharper_redundant_accessor_body_highlighting = error
+
+# Replace with field keyword
+resharper_replace_with_field_keyword_highlighting = error
 
 # Declare types in namespaces
 dotnet_diagnostic.CA1050.severity = None
@@ -200,6 +205,7 @@ resharper_field_can_be_made_read_only_local_highlighting = none
 resharper_merge_into_logical_pattern_highlighting = warning
 resharper_merge_into_pattern_highlighting = error
 resharper_method_has_async_overload_highlighting = warning
+# because stop rider giving errors before source generators have run
 resharper_partial_type_with_single_part_highlighting = warning
 resharper_redundant_base_qualifier_highlighting = warning
 resharper_redundant_cast_highlighting = error
@@ -316,7 +322,7 @@ ij_xml_space_inside_empty_tag = true
 indent_size = 2
 
 # Verify settings
-[*.{received,verified}.{txt,xml,json,md,sql,csv,html}]
+[*.{received,verified}.{txt,xml,json,md,sql,csv,html,md}]
 charset = "utf-8-bom"
 end_of_line = lf
 indent_size = unset

src/Directory.Build.props

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project>
   <PropertyGroup>
-    <NoWarn>CS1591;CS0649;xUnit1026;xUnit1013;CS1573;VerifyTestsProjectDir;VerifySetParameters;PolyFillTargetsForNuget</NoWarn>
+    <NoWarn>CA1822;CS1591;CS0649;xUnit1026;xUnit1013;CS1573;VerifyTestsProjectDir;VerifySetParameters;PolyFillTargetsForNuget</NoWarn>
     <Version>28.2.1</Version>
     <ImplicitUsings>enable</ImplicitUsings>
     <LangVersion>preview</LangVersion>

src/Directory.Packages.props

@@ -24,7 +24,7 @@
     <PackageVersion Include="MSTest.TestFramework" Version="3.6.2" />
     <PackageVersion Include="NUnit3TestAdapter" Version="4.6.0" />
     <PackageVersion Include="Polyfill" Version="7.4.1" />
-    <PackageVersion Include="ProjectDefaults" Version="1.0.141" />
+    <PackageVersion Include="ProjectDefaults" Version="1.0.144" />
     <PackageVersion Include="PublicApiGenerator" Version="11.1.0" />
     <PackageVersion Include="SimpleInfoName" Version="3.0.1" />
     <PackageVersion Include="System.Drawing.Common" Version="8.0.10" />

src/Verify/Combinations/CombinationResult.cs

@@ -9,7 +9,7 @@ public static CombinationResult ForException(IReadOnlyList<object?> keys, Except
     {
         Keys = keys;
         Type = CombinationResultType.Exception;
-        this.exception = exception;
+        Exception = exception;
     }
 
     public static CombinationResult ForValue(IReadOnlyList<object?> keys, object? value) =>
@@ -19,7 +19,7 @@ public static CombinationResult ForValue(IReadOnlyList<object?> keys, object? va
     {
         Keys = keys;
         Type = CombinationResultType.Value;
-        this.value = value;
+        Value = value;
     }
 
     public static CombinationResult ForVoid(IReadOnlyList<object?> keys) =>
@@ -34,8 +34,6 @@ public static CombinationResult ForVoid(IReadOnlyList<object?> keys) =>
     public CombinationResultType Type { get; }
     public IReadOnlyList<object?> Keys { get; }
 
-    readonly object? value;
-
     public object? Value
     {
         get
@@ -45,12 +43,11 @@ public object? Value
                 throw new($"Invalid CombinationResultType: {Type}");
             }
 
-            return value;
+            return field;
         }
     }
 
-    Exception? exception;
-
+    [field: AllowNull, MaybeNull]
     public Exception Exception
     {
         get
@@ -60,7 +57,7 @@ public Exception Exception
                 throw new($"Invalid CombinationResultType: {Type}");
             }
 
-            return exception!;
+            return field!;
         }
     }
 }

src/Verify/SettingsTask.cs

@@ -2,15 +2,14 @@ namespace VerifyTests;
 
 public partial class SettingsTask
 {
-    VerifySettings? settings;
     Func<VerifySettings, Task<VerifyResult>> buildTask;
     Task<VerifyResult>? task;
 
     public SettingsTask(VerifySettings? settings, Func<VerifySettings, Task<VerifyResult>> buildTask)
     {
         if (settings is not null)
         {
-            this.settings = new(settings);
+            CurrentSettings = new(settings);
         }
 
         this.buildTask = buildTask;
@@ -304,7 +303,8 @@ public SettingsTask DontUseSplitModeForUniqueDirectory()
         return this;
     }
 
-    public VerifySettings CurrentSettings => settings ??= new();
+    [field: AllowNull, MaybeNull]
+    public VerifySettings CurrentSettings => field ??= new();
 
     [Pure]
     public Task<VerifyResult> ToTask() =>