♻️ refactor: unnecessary duplicate error check

srizzling · srizzling · commit a631e3730240 · 2025-05-01T10:14:03.000+10:00
Prior to this commit, The `console.go` file contained a duplicate error
check for the `err` variable, which was redundant and unnecessary.

After this commit, The duplicate error check has been removed,
simplifying the code and improving readability.

Signed-off-by: Sriram Venkatesh &lt;sriram.venkatesh@versent.com.au&gt;
diff --git a/cmd/saml2aws/commands/console.go b/cmd/saml2aws/commands/console.go
@@ -48,9 +48,6 @@ func Console(consoleFlags *flags.ConsoleFlags) error {
 		return errors.Wrap(err,
 			fmt.Sprintf("error loading credentials for profile: %s", consoleFlags.LoginExecFlags.ExecProfile))
 	}
-	if err != nil {
-		return errors.Wrap(err, "error logging in")
-	}
 
 	if consoleFlags.LoginExecFlags.ExecProfile != "" {
 		// Assume the desired role before generating env vars

Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,6 @@ func Console(consoleFlags *flags.ConsoleFlags) error {`
`48`	`48`	`return errors.Wrap(err,`
`49`	`49`	`fmt.Sprintf("error loading credentials for profile: %s", consoleFlags.LoginExecFlags.ExecProfile))`
`50`	`50`	`}`
`51`		`- if err != nil {`
`52`		`- return errors.Wrap(err, "error logging in")`
`53`		`- }`
`54`	`51`
`55`	`52`	`if consoleFlags.LoginExecFlags.ExecProfile != "" {`
`56`	`53`	`// Assume the desired role before generating env vars`