Improve AssignedAttributes

Author: Verseth

CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.6.3] - 2025-10-16
+
+[Diff](https://github.com/Verseth/ruby-shale-builder/compare/v0.6.2...v0.6.3)
+
+### Changes
+- Improve `Shale::Builder::AssignedAttributes` to handle assignment in methods like `from_hash`
+
 ## [0.6.2] - 2025-10-16
 
 [Diff](https://github.com/Verseth/ruby-shale-builder/compare/v0.6.0...v0.6.2)

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    shale-builder (0.6.2)
+    shale-builder (0.6.3)
       booleans (>= 0.1)
       shale (< 2.0)
       sorbet-runtime (> 0.5)

lib/shale/builder/assigned_attributes.rb

@@ -14,6 +14,8 @@ module AssignedAttributes
       extend T::Sig
       extend T::Helpers
 
+      DEFAULT = Object.new
+
       class << self
         extend T::Sig
 
@@ -43,14 +45,27 @@ module ClassMethods
         #: Module
         attr_reader :assigned_attributes_methods_module
 
-        #: (String | Symbol name, Class type, ?collection: bool, ?default: Proc?, ?doc: String?, **untyped kwargs) ?{ -> void } -> void
-        def attribute(name, type, collection: false, default: nil, doc: nil, **kwargs, &block)
-          super
+        #: (
+        #|  String | Symbol name,
+        #|  Class shale_mapper,
+        #|  ?collection: bool,
+        #|  ?default: Proc?,
+        #|  **Object kwargs
+        #| ) ?{ -> void } -> void
+        def attribute(
+          name,
+          shale_mapper,
+          collection: false,
+          default: -> { DEFAULT },
+          **kwargs,
+          &block
+        )
+          super(name, shale_mapper, collection:, default:, **kwargs, &block) # rubocop:disable Style/SuperArguments
 
           @assigned_attributes_methods_module.class_eval <<~RUBY, __FILE__, __LINE__ + 1
             def #{name}=(val)
+              return if val.equal?(::Shale::Builder::AssignedAttributes::DEFAULT)
               super
-              return unless @__initialized
 
               self.assigned_attribute_names << #{name.to_sym.inspect}
             end
@@ -59,14 +74,6 @@ def #{name}=(val)
       end
       mixes_in_class_methods ClassMethods
 
-      def initialize(*args, **kwargs, &block)
-        super
-        @__initialized = true
-      end
-
-      #: bool?
-      attr_reader :__initialized
-
       # Returns a set of names of assigned shale attributes.
       #
       #: -> Set[Symbol]

lib/shale/builder/version.rb

@@ -2,6 +2,6 @@
 
 module Shale
   module Builder
-    VERSION = '0.6.2'
+    VERSION = '0.6.3'
   end
 end

test/shale/builder_test.rb

@@ -50,6 +50,13 @@ class TestClientDataType < ::Shale::Mapper
     attribute :email, ::Shale::Type::String
 
     alias_attribute :name, :first_name
+
+    hsh do
+      map :first_name, to: :first_name
+      map :name, to: :first_name
+      map :last_name, to: :last_name
+      map :email, to: :email
+    end
   end
 
   class TestEnhancedTransactionType < TestTransactionType
@@ -125,6 +132,12 @@ class TestMultipleClientTransactionType < TestTransactionType
 
     obj.email = 'bar'
     assert_equal Set[:first_name, :email], obj.assigned_attribute_names
+
+    obj = TestClientDataType.from_hash({ name: 'foo', email: 'bar' })
+    assert_equal 'foo', obj.first_name
+    assert_equal 'bar', obj.email
+    assert_equal 2, obj.assigned_attribute_names.length
+    assert_equal Set[:first_name, :email], obj.assigned_attribute_names
   end
 
   should 'correctly set up a class after including' do