Skip to content

Commit 292db4c

Browse files
chore(deps): bump very_good_analysis from 7.0.0 to 9.0.0 (#108)
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcos Sevilla <[email protected]>
1 parent a5fd323 commit 292db4c

28 files changed

+714
-616
lines changed

analysis_options.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
include: package:very_good_analysis/analysis_options.7.0.0.yaml
1+
include: package:very_good_analysis/analysis_options.yaml

example/analysis_options.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
include: package:very_good_analysis/analysis_options.7.0.0.yaml
1+
include: package:very_good_analysis/analysis_options.yaml
22
linter:
33
rules:
44
public_member_api_docs: false

example/bin/example_cli.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ Future<void> main(List<String> args) async {
1313
/// exited already. This is useful to prevent Future chains from proceeding
1414
/// after you've decided to exit.
1515
Future<void> _flushThenExit(int status) {
16-
return Future.wait<void>([stdout.close(), stderr.close()])
17-
.then<void>((_) => exit(status));
16+
return Future.wait<void>([
17+
stdout.close(),
18+
stderr.close(),
19+
]).then<void>((_) => exit(status));
1820
}

example/lib/src/command_runner.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ class ExampleCommandRunner extends CompletionCommandRunner<int> {
1818
/// {@macro example_command_runner}
1919
ExampleCommandRunner({
2020
Logger? logger,
21-
}) : _logger = logger ?? Logger(),
22-
super(executableName, description) {
21+
}) : _logger = logger ?? Logger(),
22+
super(executableName, description) {
2323
// Add root options and flags
2424
argParser
2525
..addFlag(

example/lib/src/commands/some_commmand.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ class SomeCommand extends Command<int> {
3535
)
3636
..addOption(
3737
'no-option',
38-
help: 'An option that starts with "no" just to make confusion '
38+
help:
39+
'An option that starts with "no" just to make confusion '
3940
'with negated flags',
4041
)
4142
..addMultiOption(
@@ -95,9 +96,9 @@ class SomeCommand extends Command<int> {
9596

9697
@override
9798
List<String> get aliases => [
98-
'disguised:some_commmand',
99-
'melon',
100-
];
99+
'disguised:some_commmand',
100+
'melon',
101+
];
101102

102103
@override
103104
Future<int> run() async {

example/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ version: 0.0.1
44
publish_to: none
55

66
environment:
7-
sdk: ^3.5.0
7+
sdk: ^3.8.1
88

99
dependencies:
1010
args: ^2.5.0
@@ -15,7 +15,7 @@ dependencies:
1515
dev_dependencies:
1616
mocktail: ^1.0.4
1717
test: ^1.25.8
18-
very_good_analysis: ^7.0.0
18+
very_good_analysis: ^9.0.0
1919

2020
executables:
2121
example_cli:

example/test/integration/completion_integration_test.dart

Lines changed: 37 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ void main() {
196196
'--continuous': r'A continuous option\: any value is allowed',
197197
'--no-option':
198198
'An option that starts with "no" just to make confusion with negated '
199-
'flags',
199+
'flags',
200200
'--multi-d': 'An discrete option that can be passed multiple times ',
201201
'--multi-c': 'An continuous option that can be passed multiple times',
202202
'--flag': null,
@@ -313,7 +313,7 @@ void main() {
313313
suggests({
314314
'--no-option':
315315
'An option that starts with "no" just to make confusion with '
316-
'negated flags',
316+
'negated flags',
317317
'--no-flag': null,
318318
'--no-inverseflag': 'A flag that the default value is true',
319319
}),
@@ -410,13 +410,14 @@ void main() {
410410
});
411411

412412
test(
413-
'**do not** suggest possible options when using equals/quote syntax',
414-
() async {
415-
await expectLater(
416-
'example_cli some_command --discrete="',
417-
suggests(noSuggestions),
418-
);
419-
});
413+
'**do not** suggest possible options when using equals/quote syntax',
414+
() async {
415+
await expectLater(
416+
'example_cli some_command --discrete="',
417+
suggests(noSuggestions),
418+
);
419+
},
420+
);
420421
});
421422

422423
group('discrete (aliases)', () {
@@ -431,17 +432,19 @@ void main() {
431432
);
432433
});
433434

434-
test('suggest matching options for alias option when typed 2',
435-
() async {
436-
await expectLater(
437-
'example_cli some_command --defined-values ',
438-
suggests({
439-
'foo': 'foo help',
440-
'bar': 'bar help',
441-
'faa': 'faa help',
442-
}),
443-
);
444-
});
435+
test(
436+
'suggest matching options for alias option when typed 2',
437+
() async {
438+
await expectLater(
439+
'example_cli some_command --defined-values ',
440+
suggests({
441+
'foo': 'foo help',
442+
'bar': 'bar help',
443+
'faa': 'faa help',
444+
}),
445+
);
446+
},
447+
);
445448
});
446449

447450
group('continuous', () {
@@ -634,18 +637,20 @@ void main() {
634637
tags: 'known-issues',
635638
);
636639

637-
test('include discrete multi option value after it is specified',
638-
() async {
639-
await expectLater(
640-
'example_cli some_command --multi-d bar -m ',
641-
suggests({
642-
'fii': 'fii help',
643-
'bar': 'bar help',
644-
'fee': 'fee help',
645-
'i have space': 'an allowed option with space on it',
646-
}),
647-
);
648-
});
640+
test(
641+
'include discrete multi option value after it is specified',
642+
() async {
643+
await expectLater(
644+
'example_cli some_command --multi-d bar -m ',
645+
suggests({
646+
'fii': 'fii help',
647+
'bar': 'bar help',
648+
'fee': 'fee help',
649+
'i have space': 'an allowed option with space on it',
650+
}),
651+
);
652+
},
653+
);
649654
});
650655
});
651656
});

example/test/integration/utils.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ class CliCompletionMatcher extends CustomMatcher {
1818
Map<String, String?> suggestions, {
1919
this.cursorIndex,
2020
}) : super(
21-
'Completes with the expected suggestions',
22-
'suggestions',
23-
completion(suggestions),
24-
);
21+
'Completes with the expected suggestions',
22+
'suggestions',
23+
completion(suggestions),
24+
);
2525

2626
final int? cursorIndex;
2727

example/test/src/commands/some_other_command_test.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ void main() {
2525

2626
expect(exitCode, ExitCode.success.code);
2727

28-
verify(() => logger.info('A sub command of some_other_command'))
29-
.called(1);
28+
verify(
29+
() => logger.info('A sub command of some_other_command'),
30+
).called(1);
3031
verify(() => logger.info(' - anything')).called(1);
3132
verify(() => logger.info(' - after')).called(1);
3233
verify(() => logger.info(' - command')).called(1);

lib/src/command_runner/completion_command_runner.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ abstract class CompletionCommandRunner<T> extends CommandRunner<T> {
7171
}
7272

7373
/// The list of commands that should not trigger the auto installation.
74-
static const _reservedCommands = {
74+
static const Set<String> _reservedCommands = {
7575
HandleCompletionRequestCommand.commandName,
7676
InstallCompletionFilesCommand.commandName,
7777
UnistallCompletionFilesCommand.commandName,

0 commit comments

Comments
 (0)