integrate feedback from @felangel

Author: jeroen-meijer

lib/src/private/matcher_extensions.dart lib/src/matcher_extensions.dartlib/src/private/matcher_extensions.dart renamed to lib/src/matcher_extensions.dart

@@ -4,18 +4,15 @@ import 'package:matcher/matcher.dart';
 extension MatcherExtensions on Matcher {
   /// Returns the description of this matcher as a string.
   String describeAsString() {
-    Description description = StringDescription();
-    description = describe(description);
-    return description.toString();
+    return describe(StringDescription()).toString();
   }
 
   /// Returns the mismatch description of this matcher as a string.
   // ignore: avoid_positional_boolean_parameters
   String describeMismatchAsString(dynamic item, Map matchState, bool verbose) {
-    Description description = StringDescription();
-    description = describeMismatch(
+    final description = describeMismatch(
       item,
-      description,
+      StringDescription(),
       matchState,
       verbose,
     );

lib/src/matchers.dart

@@ -1,5 +1,5 @@
 import 'package:flutter/widgets.dart';
-import 'package:mockingjay/src/private/matcher_extensions.dart';
+import 'package:mockingjay/src/matcher_extensions.dart';
 import 'package:test/test.dart';
 
 /// Returns a matcher that matches [Route]s.

test/src/matchers_test.dart

@@ -15,7 +15,6 @@ Future<void> expectToFail(
     await expectLater(actual, matcher);
     didNotFail = true;
   } on TestFailure catch (error) {
-    if (didNotFail) {}
     const whichClause = '   Which: ';
     final whichClauseIndex = error.message!.indexOf(whichClause);
     final reasonIndex = whichClauseIndex + whichClause.length;