Skip to content

Commit dda46ee

Browse files
dependabot[bot]marcossevilla
dependabot[bot]
and
marcossevilla
authored
chore(deps): bump very_good_analysis from 9.0.0 to 10.0.0 (#107)
* chore(deps): bump very_good_analysis from 9.0.0 to 10.0.0 Bumps [very_good_analysis](https://github.com/VeryGoodOpenSource/very_good_analysis) from 9.0.0 to 10.0.0. - [Release notes](https://github.com/VeryGoodOpenSource/very_good_analysis/releases) - [Changelog](https://github.com/VeryGoodOpenSource/very_good_analysis/blob/main/CHANGELOG.md) - [Commits](VeryGoodOpenSource/very_good_analysis@v9.0.0...v10.0.0) --- updated-dependencies: - dependency-name: very_good_analysis dependency-version: 10.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update pubspec.yaml * fix: VGA constraint --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcos Sevilla <[email protected]> Co-authored-by: Marcos Sevilla <[email protected]>
1 parent 4c54c21 commit dda46ee

File tree

6 files changed

+95
-94
lines changed

6 files changed

+95
-94
lines changed

‎.github/workflows/example.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
build:
2020
uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_package.yml@v1
2121
with:
22+
runs_on: macos-latest
2223
flutter_channel: stable
23-
flutter_version: "3.32.0"
24+
flutter_version: "3.35.x"
2425
working_directory: example
25-
runs_on: macos-latest

‎.github/workflows/main.yaml‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,10 @@ jobs:
1717
uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/semantic_pull_request.yml@v1
1818

1919
build:
20-
strategy:
21-
matrix:
22-
flutter-version:
23-
# The version of Flutter to use should use the minimum Dart SDK version supported by the package,
24-
# refer to https://docs.flutter.dev/development/tools/sdk/releases.
25-
- "3.32.0"
26-
- "3.x"
2720
uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_package.yml@v1
2821
with:
2922
flutter_channel: stable
30-
flutter_version: ${{ matrix.flutter-version }}
23+
flutter_version: "3.35.x"
3124
package_get_excludes: example
3225

3326
spell-check:

‎example/pubspec.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ version: 0.0.1
44
homepage: https://github.com/VeryGoodOpenSource/mockingjay
55

66
environment:
7-
sdk: ^3.8.0
8-
flutter: ^3.32.0
7+
sdk: ^3.9.0
8+
flutter: ^3.35.0
99

1010
dependencies:
1111
bloc: ^9.0.0
@@ -22,7 +22,7 @@ dev_dependencies:
2222
mockingjay:
2323
path: ../
2424
mocktail: ^1.0.4
25-
very_good_analysis: ^9.0.0
25+
very_good_analysis: ^10.0.0
2626

2727
flutter:
2828
uses-material-design: true

‎lib/src/matcher_extensions.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ extension MatcherExtensions on Matcher {
88
}
99

1010
/// Returns the mismatch description of this matcher as a string.
11-
// ignore: avoid_positional_boolean_parameters
1211
String describeMismatchAsString(
1312
dynamic item,
1413
Map<dynamic, dynamic> matchState, {

‎pubspec.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ version: 2.0.0
44
homepage: https://github.com/VeryGoodOpenSource/mockingjay
55

66
environment:
7-
sdk: ^3.8.0
8-
flutter: ">=3.32.0"
7+
sdk: ^3.9.0
8+
flutter: ^3.35.0
99

1010
dependencies:
1111
flutter:
@@ -17,4 +17,4 @@ dependencies:
1717
test: ^1.25.7
1818

1919
dev_dependencies:
20-
very_good_analysis: ^9.0.0
20+
very_good_analysis: ^10.0.0

‎test/src/matchers_test.dart‎

Lines changed: 86 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -66,23 +66,23 @@ void main() {
6666
expect(createRoute<String>(name: '/test'), isRoute());
6767
});
6868

69-
test('does not match anything that is not a route', () {
70-
expectToFail(
69+
test('does not match anything that is not a route', () async {
70+
await expectToFail(
7171
1,
7272
isRoute(),
7373
withMessage: 'is not a route but an instance of `int`',
7474
);
75-
expectToFail(
75+
await expectToFail(
7676
'a',
7777
isRoute(),
7878
withMessage: 'is not a route but an instance of `String`',
7979
);
80-
expectToFail(
80+
await expectToFail(
8181
null,
8282
isRoute(),
8383
withMessage: 'is not a route but an instance of `Null`',
8484
);
85-
expectToFail(
85+
await expectToFail(
8686
const SizedBox(),
8787
isRoute(),
8888
withMessage: 'is not a route but an instance of `SizedBox`',
@@ -96,23 +96,26 @@ void main() {
9696
expect(createRoute<String>(name: '/test'), isRoute<String>());
9797
});
9898

99-
test('does not match anything that is not a route of that type', () {
100-
expectToFail(
101-
createRoute<dynamic>(),
102-
isRoute<String>(),
103-
withMessage: 'is a route of type `dynamic` instead of `String`',
104-
);
105-
expectToFail(
106-
createRoute<dynamic>(name: '/test'),
107-
isRoute<String>(),
108-
withMessage: 'is a route of type `dynamic` instead of `String`',
109-
);
110-
expectToFail(
111-
1,
112-
isRoute<String>(),
113-
withMessage: 'is not a route but an instance of `int`',
114-
);
115-
});
99+
test(
100+
'does not match anything that is not a route of that type',
101+
() async {
102+
await expectToFail(
103+
createRoute<dynamic>(),
104+
isRoute<String>(),
105+
withMessage: 'is a route of type `dynamic` instead of `String`',
106+
);
107+
await expectToFail(
108+
createRoute<dynamic>(name: '/test'),
109+
isRoute<String>(),
110+
withMessage: 'is a route of type `dynamic` instead of `String`',
111+
);
112+
await expectToFail(
113+
1,
114+
isRoute<String>(),
115+
withMessage: 'is not a route but an instance of `int`',
116+
);
117+
},
118+
);
116119
});
117120

118121
group('with whereSettings argument', () {
@@ -134,14 +137,14 @@ void main() {
134137
});
135138

136139
test('does not match anything that is not a route '
137-
'with matching settings', () {
138-
expectToFail(
140+
'with matching settings', () async {
141+
await expectToFail(
139142
createRoute<dynamic>(name: '/test'),
140143
isRoute(whereSettings: equalsSettingsOf(createRoute<String>())),
141144
withMessage:
142145
"is a route where `settings` has `name` with value '/test'",
143146
);
144-
expectToFail(
147+
await expectToFail(
145148
createRoute<dynamic>(name: '/other_name'),
146149
isRoute(
147150
whereSettings: equalsSettingsOf(
@@ -155,7 +158,7 @@ is a route where `settings` has `name` with value '/other_name' which is differe
155158
^
156159
Differ at offset 1''',
157160
);
158-
expectToFail(
161+
await expectToFail(
159162
1,
160163
isRoute(whereSettings: equalsSettingsOf(createRoute<dynamic>())),
161164
withMessage: 'is not a route but an instance of `int`',
@@ -175,29 +178,32 @@ is a route where `settings` has `name` with value '/other_name' which is differe
175178
);
176179
});
177180

178-
test('does not match anything that is not a route with that name', () {
179-
expectToFail(
180-
createRoute<dynamic>(),
181-
isRoute(whereName: equals('/test')),
182-
withMessage:
183-
"is a route where the route's `name` is empty instead of '/test'",
184-
);
185-
expectToFail(
186-
createRoute<dynamic>(name: '/other_name'),
187-
isRoute(whereName: equals('/test')),
188-
withMessage: '''
181+
test(
182+
'does not match anything that is not a route with that name',
183+
() async {
184+
await expectToFail(
185+
createRoute<dynamic>(),
186+
isRoute(whereName: equals('/test')),
187+
withMessage:
188+
"is a route where the route's `name` is empty instead of '/test'",
189+
);
190+
await expectToFail(
191+
createRoute<dynamic>(name: '/other_name'),
192+
isRoute(whereName: equals('/test')),
193+
withMessage: '''
189194
is a route where the route's `name` is different.
190195
Expected: /test
191196
Actual: /other_name ...
192197
^
193198
Differ at offset 1''',
194-
);
195-
expectToFail(
196-
1,
197-
isRoute(whereName: equals('/test')),
198-
withMessage: 'is not a route but an instance of `int`',
199-
);
200-
});
199+
);
200+
await expectToFail(
201+
1,
202+
isRoute(whereName: equals('/test')),
203+
withMessage: 'is not a route but an instance of `int`',
204+
);
205+
},
206+
);
201207
});
202208

203209
group('with whereArguments argument', () {
@@ -214,22 +220,22 @@ is a route where the route's `name` is different.
214220

215221
test(
216222
'does not match anything that is not a route with same arguments',
217-
() {
218-
expectToFail(
223+
() async {
224+
await expectToFail(
219225
createRoute<dynamic>(arguments: {'a': 1}),
220226
isRoute(whereArguments: equals({'a': 2})),
221227
withMessage:
222228
"is a route where the route's `arguments` "
223229
"at location ['a'] is <1> instead of <2>",
224230
);
225-
expectToFail(
231+
await expectToFail(
226232
createRoute<dynamic>(arguments: {'a': 1}),
227233
isRoute(whereArguments: equals({'b': 1})),
228234
withMessage:
229235
"is a route where the route's `arguments` "
230236
"is missing map key 'b'",
231237
);
232-
expectToFail(
238+
await expectToFail(
233239
1,
234240
isRoute(whereArguments: equals({'a': 1})),
235241
withMessage: 'is not a route but an instance of `int`',
@@ -244,23 +250,23 @@ is a route where the route's `name` is different.
244250
});
245251

246252
test('does not match anything that is not a route with matching '
247-
'maintainState argument', () {
248-
expectToFail(
253+
'maintainState argument', () async {
254+
await expectToFail(
249255
createRoute<dynamic>(),
250256
isRoute(whereMaintainState: isFalse),
251257
withMessage:
252258
'is a route where `maintainState` '
253259
'is true instead of false',
254260
);
255-
expectToFail(
261+
await expectToFail(
256262
NonModalRoute(),
257263
isRoute(whereMaintainState: isTrue),
258264
withMessage:
259265
'is a route where `maintainState` '
260266
'is not a property on `NonModalRoute` and can only be used '
261267
'with `ModalRoute`s',
262268
);
263-
expectToFail(
269+
await expectToFail(
264270
1,
265271
isRoute(whereMaintainState: isTrue),
266272
withMessage: 'is not a route but an instance of `int`',
@@ -276,33 +282,36 @@ is a route where the route's `name` is different.
276282
);
277283
});
278284

279-
test('does not match anything that is not a route with matching '
280-
'fullscreenDialog argument', () {
281-
expectToFail(
282-
createRoute<dynamic>(fullscreenDialog: true),
283-
isRoute(whereFullscreenDialog: isFalse),
284-
withMessage:
285-
'is a route where `fullscreenDialog` '
286-
'is true instead of false',
287-
);
288-
expectToFail(
289-
NonModalRoute(),
290-
isRoute(whereFullscreenDialog: isFalse),
291-
withMessage:
292-
'is a route where `fullscreenDialog` '
293-
'is not a property on `NonModalRoute` and can only be used '
294-
'with `PageRoute`s',
295-
);
296-
expectToFail(
297-
1,
298-
isRoute(whereFullscreenDialog: isTrue),
299-
withMessage: 'is not a route but an instance of `int`',
300-
);
301-
});
285+
test(
286+
'does not match anything that is not a route with matching '
287+
'fullscreenDialog argument',
288+
() async {
289+
await expectToFail(
290+
createRoute<dynamic>(fullscreenDialog: true),
291+
isRoute(whereFullscreenDialog: isFalse),
292+
withMessage:
293+
'is a route where `fullscreenDialog` '
294+
'is true instead of false',
295+
);
296+
await expectToFail(
297+
NonModalRoute(),
298+
isRoute(whereFullscreenDialog: isFalse),
299+
withMessage:
300+
'is a route where `fullscreenDialog` '
301+
'is not a property on `NonModalRoute` and can only be used '
302+
'with `PageRoute`s',
303+
);
304+
await expectToFail(
305+
1,
306+
isRoute(whereFullscreenDialog: isTrue),
307+
withMessage: 'is not a route but an instance of `int`',
308+
);
309+
},
310+
);
302311
});
303312

304-
test('returns all relevant mismatches in one log', () {
305-
expectToFail(
313+
test('returns all relevant mismatches in one log', () async {
314+
await expectToFail(
306315
createRoute<dynamic>(
307316
name: '/other_name',
308317
arguments: {'b': 1},

0 commit comments

Comments
 (0)