Skip to content

Commit 0f2784f

Browse files
feat: support Dart 3.10 (#178)
* chore: update rules and exclusion table * feat: add new rules * fix: test
1 parent b644968 commit 0f2784f

File tree

16 files changed

+275
-44
lines changed

16 files changed

+275
-44
lines changed

.github/workflows/bot_updater.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
- name: 🎯 Setup Dart
2424
uses: dart-lang/setup-dart@v1
2525
with:
26-
sdk: "3.9.0"
26+
sdk: "3.10.0"
2727

2828
- name: 📦 Install Dependencies
2929
run: dart pub get
@@ -56,6 +56,8 @@ jobs:
5656
author: VGV Bot <[email protected]>
5757
assignees: vgvbot
5858
committer: VGV Bot <[email protected]>
59+
token: ${{ steps.generate-token.outputs.token }}
60+
sign-commits: true
5961

6062
- name: 🔍 Check for deprecated rules changes
6163
id: deprecated
@@ -79,3 +81,5 @@ jobs:
7981
author: VGV Bot <[email protected]>
8082
assignees: vgvbot
8183
committer: VGV Bot <[email protected]>
84+
token: ${{ steps.generate-token.outputs.token }}
85+
sign-commits: true

.github/workflows/main.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
- uses: actions/checkout@v5
1313
- uses: dart-lang/setup-dart@v1
1414
with:
15-
sdk: "3.9.0"
15+
sdk: "3.10.0"
1616

1717
- name: Install Dependencies
1818
run: dart pub get

.github/workflows/pub_publish.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: 🎯 Setup Dart
1717
uses: dart-lang/setup-dart@v1
1818
with:
19-
sdk: "3.9.0"
19+
sdk: "3.10.0"
2020
- name: 📦 Install Dependencies
2121
run: dart pub get
2222
- name: 🌵 Dry Run

.github/workflows/tool_linter_rules.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ jobs:
1515
build:
1616
uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_package.yml@v1
1717
with:
18-
dart_sdk: 3.9.0
18+
dart_sdk: 3.10.0
1919
working_directory: tool/linter_rules

.github/workflows/verify_version.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414

1515
- uses: dart-lang/setup-dart@v1
1616
with:
17-
sdk: "3.9.0"
17+
sdk: "3.10.0"
1818

1919
- name: Verify version consistency
2020
run: dart run tool/verify_version/main.dart

README.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -100,24 +100,21 @@ Below is a list of rules that are not enabled by default together with the reaso
100100
| [`avoid_futureor_void`](https://dart.dev/tools/linter-rules/avoid_futureor_void) | Not specified |
101101
| [`avoid_implementing_value_types`](https://dart.dev/tools/linter-rules/avoid_implementing_value_types) | Not specified |
102102
| [`avoid_null_checks_in_equality_operators`](https://dart.dev/tools/linter-rules/avoid_null_checks_in_equality_operators) | Has been deprecated and [will be removed](https://github.com/dart-lang/sdk/issues/59514) |
103-
| [`avoid_types_on_closure_parameters`](https://dart.dev/tools/linter-rules/avoid_types_on_closure_parameters) | Not specified |
104103
| [`close_sinks`](https://dart.dev/tools/linter-rules/close_sinks) | [Has unresolved false positives](https://github.com/dart-lang/linter/issues/1381) |
105104
| [`diagnostic_describe_all_properties`](https://dart.dev/tools/linter-rules/diagnostic_describe_all_properties) | Not specified |
106105
| [`do_not_use_environment`](https://dart.dev/tools/linter-rules/do_not_use_environment) | Not specified |
107106
| [`library_names`](https://dart.dev/tools/linter-rules/library_names) | [Superseded by `unnecessary_library_name`](https://github.com/dart-lang/lints/issues/172) |
108-
| [`omit_obvious_local_variable_types`](https://dart.dev/tools/linter-rules/omit_obvious_local_variable_types) | Not specified |
107+
| [`omit_obvious_local_variable_types`](https://dart.dev/tools/linter-rules/omit_obvious_local_variable_types) | Experimental |
109108
| [`omit_obvious_property_types`](https://dart.dev/tools/linter-rules/omit_obvious_property_types) | Incompatible with [type_annotate_public_apis](https://github.com/dart-lang/sdk/issues/60642) |
110109
| [`package_prefixed_library_names`](https://dart.dev/tools/linter-rules/package_prefixed_library_names) | [Broken; superseded by `unnecessary_library_name`](https://github.com/dart-lang/lints/issues/172) |
111110
| [`prefer_double_quotes`](https://dart.dev/tools/linter-rules/prefer_double_quotes) | Incompatible with [prefer_single_quotes](https://dart.dev/tools/linter-rules/prefer_single_quotes) |
112-
| [`prefer_expression_function_bodies`](https://dart.dev/tools/linter-rules/prefer_expression_function_bodies) | Not specified |
113111
| [`prefer_final_parameters`](https://dart.dev/tools/linter-rules/prefer_final_parameters) | Incompatible with [avoid_final_parameters](https://dart.dev/tools/linter-rules/avoid_final_parameters) |
114-
| [`prefer_mixin`](https://dart.dev/tools/linter-rules/prefer_mixin) | Not specified |
115112
| [`prefer_relative_imports`](https://dart.dev/tools/linter-rules/prefer_relative_imports) | Incompatible with [always_use_package_imports](https://dart.dev/tools/linter-rules/always_use_package_imports) |
116113
| [`prefer_void_to_null`](https://dart.dev/tools/linter-rules/prefer_void_to_null) | [Has unresolved false positives](https://github.com/dart-lang/linter/issues/4758) |
117-
| [`specify_nonobvious_local_variable_types`](https://dart.dev/tools/linter-rules/specify_nonobvious_local_variable_types) | Not specified |
118-
| [`unnecessary_async`](https://dart.dev/tools/linter-rules/unnecessary_async) | Not specified |
114+
| [`specify_nonobvious_local_variable_types`](https://dart.dev/tools/linter-rules/specify_nonobvious_local_variable_types) | Experimental |
115+
| [`unnecessary_async`](https://dart.dev/tools/linter-rules/unnecessary_async) | Experimental |
119116
| [`unnecessary_final`](https://dart.dev/tools/linter-rules/unnecessary_final) | Incompatible with [prefer_final_locals](https://dart.dev/tools/linter-rules/prefer_final_locals) |
120-
| [`unsafe_variance`](https://dart.dev/tools/linter-rules/unsafe_variance) | Not specified |
117+
| [`unsafe_variance`](https://dart.dev/tools/linter-rules/unsafe_variance) | Experimental |
121118
| [`use_decorated_box`](https://dart.dev/tools/linter-rules/use_decorated_box) | [Has unresolved malfunctions](https://github.com/dart-lang/linter/issues/3286) |
122119
<!-- end:excluded_rules_table -->
123120

example/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: 0.0.1
33
publish_to: none
44

55
environment:
6-
sdk: ^3.9.0
6+
sdk: ^3.10.0
77

88
dependencies:
99
very_good_analysis:

lib/analysis_options.10.1.0.yaml

Lines changed: 234 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,234 @@
1+
analyzer:
2+
language:
3+
strict-casts: true
4+
strict-inference: true
5+
strict-raw-types: true
6+
7+
errors:
8+
close_sinks: ignore
9+
unrelated_type_equality_checks: warning
10+
collection_methods_unrelated_type: warning
11+
missing_return: error
12+
missing_required_param: error
13+
record_literal_one_positional_no_trailing_comma: error
14+
15+
exclude:
16+
- test/.test_coverage.dart
17+
- lib/generated_plugin_registrant.dart
18+
19+
formatter:
20+
trailing_commas: preserve
21+
22+
linter:
23+
rules:
24+
- always_declare_return_types
25+
- always_put_required_named_parameters_first
26+
- always_use_package_imports
27+
- annotate_overrides
28+
- avoid_bool_literals_in_conditional_expressions
29+
- avoid_catches_without_on_clauses
30+
- avoid_catching_errors
31+
- avoid_double_and_int_checks
32+
- avoid_dynamic_calls
33+
- avoid_empty_else
34+
- avoid_equals_and_hash_code_on_mutable_classes
35+
- avoid_escaping_inner_quotes
36+
- avoid_field_initializers_in_const_classes
37+
- avoid_final_parameters
38+
- avoid_function_literals_in_foreach_calls
39+
- avoid_init_to_null
40+
- avoid_js_rounded_ints
41+
- avoid_multiple_declarations_per_line
42+
- avoid_positional_boolean_parameters
43+
- avoid_print
44+
- avoid_private_typedef_functions
45+
- avoid_redundant_argument_values
46+
- avoid_relative_lib_imports
47+
- avoid_renaming_method_parameters
48+
- avoid_return_types_on_setters
49+
- avoid_returning_null_for_void
50+
- avoid_returning_this
51+
- avoid_setters_without_getters
52+
- avoid_shadowing_type_parameters
53+
- avoid_single_cascade_in_expression_statements
54+
- avoid_slow_async_io
55+
- avoid_type_to_string
56+
- avoid_types_as_parameter_names
57+
- avoid_types_on_closure_parameters
58+
- avoid_unnecessary_containers
59+
- avoid_unused_constructor_parameters
60+
- avoid_void_async
61+
- avoid_web_libraries_in_flutter
62+
- await_only_futures
63+
- camel_case_extensions
64+
- camel_case_types
65+
- cancel_subscriptions
66+
- cascade_invocations
67+
- cast_nullable_to_non_nullable
68+
- collection_methods_unrelated_type
69+
- combinators_ordering
70+
- comment_references
71+
- conditional_uri_does_not_exist
72+
- constant_identifier_names
73+
- control_flow_in_finally
74+
- curly_braces_in_flow_control_structures
75+
- dangling_library_doc_comments
76+
- depend_on_referenced_packages
77+
- deprecated_consistency
78+
- deprecated_member_use_from_same_package
79+
- directives_ordering
80+
- discarded_futures
81+
- document_ignores
82+
- empty_catches
83+
- empty_constructor_bodies
84+
- empty_statements
85+
- eol_at_end_of_file
86+
- exhaustive_cases
87+
- file_names
88+
- flutter_style_todos
89+
- hash_and_equals
90+
- implementation_imports
91+
- implicit_call_tearoffs
92+
- implicit_reopen
93+
- invalid_case_patterns
94+
- invalid_runtime_check_with_js_interop_types
95+
- join_return_with_assignment
96+
- leading_newlines_in_multiline_strings
97+
- library_annotations
98+
- library_prefixes
99+
- library_private_types_in_public_api
100+
- lines_longer_than_80_chars
101+
- literal_only_boolean_expressions
102+
- matching_super_parameters
103+
- missing_code_block_language_in_doc_comment
104+
- missing_whitespace_between_adjacent_strings
105+
- no_adjacent_strings_in_list
106+
- no_default_cases
107+
- no_duplicate_case_values
108+
- no_leading_underscores_for_library_prefixes
109+
- no_leading_underscores_for_local_identifiers
110+
- no_literal_bool_comparisons
111+
- no_logic_in_create_state
112+
- no_runtimeType_toString
113+
- no_self_assignments
114+
- no_wildcard_variable_uses
115+
- non_constant_identifier_names
116+
- noop_primitive_operations
117+
- null_check_on_nullable_type_parameter
118+
- null_closures
119+
- omit_local_variable_types
120+
- one_member_abstracts
121+
- only_throw_errors
122+
- overridden_fields
123+
- package_names
124+
- parameter_assignments
125+
- prefer_adjacent_string_concatenation
126+
- prefer_asserts_in_initializer_lists
127+
- prefer_asserts_with_message
128+
- prefer_collection_literals
129+
- prefer_conditional_assignment
130+
- prefer_const_constructors
131+
- prefer_const_constructors_in_immutables
132+
- prefer_const_declarations
133+
- prefer_const_literals_to_create_immutables
134+
- prefer_constructors_over_static_methods
135+
- prefer_contains
136+
- prefer_expression_function_bodies
137+
- prefer_final_fields
138+
- prefer_final_in_for_each
139+
- prefer_final_locals
140+
- prefer_foreach
141+
- prefer_for_elements_to_map_fromIterable
142+
- prefer_function_declarations_over_variables
143+
- prefer_generic_function_type_aliases
144+
- prefer_if_elements_to_conditional_expressions
145+
- prefer_if_null_operators
146+
- prefer_initializing_formals
147+
- prefer_inlined_adds
148+
- prefer_int_literals
149+
- prefer_interpolation_to_compose_strings
150+
- prefer_is_empty
151+
- prefer_is_not_empty
152+
- prefer_is_not_operator
153+
- prefer_iterable_whereType
154+
- prefer_mixin
155+
- prefer_null_aware_method_calls
156+
- prefer_null_aware_operators
157+
- prefer_single_quotes
158+
- prefer_spread_collections
159+
- prefer_typing_uninitialized_variables
160+
- provide_deprecation_message
161+
- public_member_api_docs
162+
- recursive_getters
163+
- remove_deprecations_in_breaking_versions
164+
- require_trailing_commas
165+
- secure_pubspec_urls
166+
- sized_box_for_whitespace
167+
- sized_box_shrink_expand
168+
- slash_for_doc_comments
169+
- sort_child_properties_last
170+
- sort_constructors_first
171+
- sort_pub_dependencies
172+
- sort_unnamed_constructors_first
173+
- specify_nonobvious_property_types
174+
- strict_top_level_inference
175+
- switch_on_type
176+
- test_types_in_equals
177+
- throw_in_finally
178+
- tighten_type_of_initializing_formals
179+
- type_annotate_public_apis
180+
- type_init_formals
181+
- type_literal_in_constant_pattern
182+
- unawaited_futures
183+
- unintended_html_in_doc_comment
184+
- unnecessary_await_in_return
185+
- unnecessary_brace_in_string_interps
186+
- unnecessary_breaks
187+
- unnecessary_const
188+
- unnecessary_constructor_name
189+
- unnecessary_getters_setters
190+
- unnecessary_ignore
191+
- unnecessary_lambdas
192+
- unnecessary_late
193+
- unnecessary_library_directive
194+
- unnecessary_library_name
195+
- unnecessary_new
196+
- unnecessary_null_aware_assignments
197+
- unnecessary_null_aware_operator_on_extension_on_nullable
198+
- unnecessary_null_checks
199+
- unnecessary_null_in_if_null_operators
200+
- unnecessary_nullable_for_final_variable_declarations
201+
- unnecessary_overrides
202+
- unnecessary_parenthesis
203+
- unnecessary_raw_strings
204+
- unnecessary_statements
205+
- unnecessary_string_escapes
206+
- unnecessary_string_interpolations
207+
- unnecessary_this
208+
- unnecessary_to_list_in_spreads
209+
- unnecessary_unawaited
210+
- unnecessary_underscores
211+
- unreachable_from_main
212+
- unrelated_type_equality_checks
213+
- use_build_context_synchronously
214+
- use_colored_box
215+
- use_enums
216+
- use_full_hex_values_for_flutter_colors
217+
- use_function_type_syntax_for_parameters
218+
- use_if_null_to_convert_nulls_to_bools
219+
- use_is_even_rather_than_modulo
220+
- use_key_in_widget_constructors
221+
- use_late_for_private_fields_and_variables
222+
- use_named_constants
223+
- use_null_aware_elements
224+
- use_raw_strings
225+
- use_rethrow_when_possible
226+
- use_setters_to_change_properties
227+
- use_string_buffers
228+
- use_string_in_part_of_directives
229+
- use_super_parameters
230+
- use_test_throws_matchers
231+
- use_to_and_as_if_applicable
232+
- use_truncating_division
233+
- valid_regexps
234+
- void_checks

lib/analysis_options.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
include: package:very_good_analysis/analysis_options.10.0.0.yaml
1+
include: package:very_good_analysis/analysis_options.10.1.0.yaml

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ documentation: https://github.com/VeryGoodOpenSource/very_good_analysis
88
topics: [lints, analyzer, analysis]
99

1010
environment:
11-
sdk: ^3.9.0
11+
sdk: ^3.10.0

0 commit comments

Comments
 (0)