feat: add new rules

Author: marcossevilla

README.md

@@ -100,7 +100,6 @@ Below is a list of rules that are not enabled by default together with the reaso
 | [`avoid_futureor_void`](https://dart.dev/tools/linter-rules/avoid_futureor_void) | Not specified |
 | [`avoid_implementing_value_types`](https://dart.dev/tools/linter-rules/avoid_implementing_value_types) | Not specified |
 | [`avoid_null_checks_in_equality_operators`](https://dart.dev/tools/linter-rules/avoid_null_checks_in_equality_operators) | Has been deprecated and [will be removed](https://github.com/dart-lang/sdk/issues/59514) |
-| [`avoid_types_on_closure_parameters`](https://dart.dev/tools/linter-rules/avoid_types_on_closure_parameters) | Not specified |
 | [`close_sinks`](https://dart.dev/tools/linter-rules/close_sinks) | [Has unresolved false positives](https://github.com/dart-lang/linter/issues/1381) |
 | [`diagnostic_describe_all_properties`](https://dart.dev/tools/linter-rules/diagnostic_describe_all_properties) | Not specified |
 | [`do_not_use_environment`](https://dart.dev/tools/linter-rules/do_not_use_environment) | Not specified |
@@ -109,12 +108,9 @@ Below is a list of rules that are not enabled by default together with the reaso
 | [`omit_obvious_property_types`](https://dart.dev/tools/linter-rules/omit_obvious_property_types) | Incompatible with [type_annotate_public_apis](https://github.com/dart-lang/sdk/issues/60642) |
 | [`package_prefixed_library_names`](https://dart.dev/tools/linter-rules/package_prefixed_library_names) | [Broken; superseded by `unnecessary_library_name`](https://github.com/dart-lang/lints/issues/172) |
 | [`prefer_double_quotes`](https://dart.dev/tools/linter-rules/prefer_double_quotes) | Incompatible with [prefer_single_quotes](https://dart.dev/tools/linter-rules/prefer_single_quotes) |
-| [`prefer_expression_function_bodies`](https://dart.dev/tools/linter-rules/prefer_expression_function_bodies) | Not specified |
 | [`prefer_final_parameters`](https://dart.dev/tools/linter-rules/prefer_final_parameters) | Incompatible with [avoid_final_parameters](https://dart.dev/tools/linter-rules/avoid_final_parameters) |
-| [`prefer_mixin`](https://dart.dev/tools/linter-rules/prefer_mixin) | Not specified |
 | [`prefer_relative_imports`](https://dart.dev/tools/linter-rules/prefer_relative_imports) | Incompatible with [always_use_package_imports](https://dart.dev/tools/linter-rules/always_use_package_imports) |
 | [`prefer_void_to_null`](https://dart.dev/tools/linter-rules/prefer_void_to_null) | [Has unresolved false positives](https://github.com/dart-lang/linter/issues/4758) |
-| [`remove_deprecations_in_breaking_versions`](https://dart.dev/tools/linter-rules/remove_deprecations_in_breaking_versions) | Not specified |
 | [`specify_nonobvious_local_variable_types`](https://dart.dev/tools/linter-rules/specify_nonobvious_local_variable_types) | Experimental |
 | [`unnecessary_async`](https://dart.dev/tools/linter-rules/unnecessary_async) | Experimental |
 | [`unnecessary_final`](https://dart.dev/tools/linter-rules/unnecessary_final) | Incompatible with [prefer_final_locals](https://dart.dev/tools/linter-rules/prefer_final_locals) |

lib/analysis_options.10.1.0.yaml

@@ -6,11 +6,11 @@ analyzer:
 
   errors:
     close_sinks: ignore
-    missing_required_param: error
+    unrelated_type_equality_checks: warning
+    collection_methods_unrelated_type: warning
     missing_return: error
+    missing_required_param: error
     record_literal_one_positional_no_trailing_comma: error
-    collection_methods_unrelated_type: warning
-    unrelated_type_equality_checks: warning
 
   exclude:
     - test/.test_coverage.dart
@@ -54,6 +54,7 @@ linter:
     - avoid_slow_async_io
     - avoid_type_to_string
     - avoid_types_as_parameter_names
+    - avoid_types_on_closure_parameters
     - avoid_unnecessary_containers
     - avoid_unused_constructor_parameters
     - avoid_void_async
@@ -86,8 +87,8 @@ linter:
     - file_names
     - flutter_style_todos
     - hash_and_equals
-    - implicit_call_tearoffs
     - implementation_imports
+    - implicit_call_tearoffs
     - implicit_reopen
     - invalid_case_patterns
     - invalid_runtime_check_with_js_interop_types
@@ -132,6 +133,7 @@ linter:
     - prefer_const_literals_to_create_immutables
     - prefer_constructors_over_static_methods
     - prefer_contains
+    - prefer_expression_function_bodies
     - prefer_final_fields
     - prefer_final_in_for_each
     - prefer_final_locals
@@ -149,6 +151,7 @@ linter:
     - prefer_is_not_empty
     - prefer_is_not_operator
     - prefer_iterable_whereType
+    - prefer_mixin
     - prefer_null_aware_method_calls
     - prefer_null_aware_operators
     - prefer_single_quotes
@@ -157,6 +160,7 @@ linter:
     - provide_deprecation_message
     - public_member_api_docs
     - recursive_getters
+    - remove_deprecations_in_breaking_versions
     - require_trailing_commas
     - secure_pubspec_urls
     - sized_box_for_whitespace
@@ -178,8 +182,8 @@ linter:
     - unawaited_futures
     - unintended_html_in_doc_comment
     - unnecessary_await_in_return
-    - unnecessary_breaks
     - unnecessary_brace_in_string_interps
+    - unnecessary_breaks
     - unnecessary_const
     - unnecessary_constructor_name
     - unnecessary_getters_setters

tool/linter_rules/exclusion_reasons.json

@@ -7,7 +7,6 @@
   "avoid_futureor_void": "Not specified",
   "avoid_implementing_value_types": "Not specified",
   "avoid_null_checks_in_equality_operators": "Has been deprecated and [will be removed](https://github.com/dart-lang/sdk/issues/59514)",
-  "avoid_types_on_closure_parameters": "Not specified",
   "close_sinks": "[Has unresolved false positives](https://github.com/dart-lang/linter/issues/1381)",
   "diagnostic_describe_all_properties": "Not specified",
   "do_not_use_environment": "Not specified",
@@ -16,12 +15,9 @@
   "omit_obvious_property_types": "Incompatible with [type_annotate_public_apis](https://github.com/dart-lang/sdk/issues/60642)",
   "package_prefixed_library_names": "[Broken; superseded by `unnecessary_library_name`](https://github.com/dart-lang/lints/issues/172)",
   "prefer_double_quotes": "Incompatible with [prefer_single_quotes](https://dart.dev/tools/linter-rules/prefer_single_quotes)",
-  "prefer_expression_function_bodies": "Not specified",
   "prefer_final_parameters": "Incompatible with [avoid_final_parameters](https://dart.dev/tools/linter-rules/avoid_final_parameters)",
-  "prefer_mixin": "Not specified",
   "prefer_relative_imports": "Incompatible with [always_use_package_imports](https://dart.dev/tools/linter-rules/always_use_package_imports)",
   "prefer_void_to_null": "[Has unresolved false positives](https://github.com/dart-lang/linter/issues/4758)",
-  "remove_deprecations_in_breaking_versions": "Not specified",
   "specify_nonobvious_local_variable_types": "Experimental",
   "unnecessary_async": "Experimental",
   "unnecessary_final": "Incompatible with [prefer_final_locals](https://dart.dev/tools/linter-rules/prefer_final_locals)",

tool/linter_rules/lib/src/models/linter_rule.dart

@@ -15,7 +15,8 @@ enum LinterRuleState {
   experimental,
 
   /// The rule is deprecated and should not be used.
-  deprecated;
+  deprecated
+  ;
 
   /// Converts a [String] value to a [LinterRuleState].
   static LinterRuleState _fromJson(String value) {
@@ -49,7 +50,8 @@ enum FixStatus {
   needsFix,
 
   /// The automated fix for the rule needs evaluation.
-  needsEvaluation;
+  needsEvaluation
+  ;
 
   /// Converts a [String] value to a [FixStatus].
   static FixStatus _fromJson(String value) {
@@ -92,19 +94,17 @@ class LinterRule {
   });
 
   /// Converts JSON to a [LinterRule].
-  factory LinterRule.fromJson(Map<String, dynamic> json) {
-    return LinterRule(
-      name: json['name'] as String,
-      description: json['description'] as String,
-      details: json['details'] as String,
-      categories: (json['categories'] as List).cast<String>(),
-      state: LinterRuleState._fromJson(json['state'] as String),
-      incompatible: (json['incompatible'] as List).cast<String>(),
-      sets: (json['sets'] as List).cast<String>(),
-      fixStatus: FixStatus._fromJson(json['fixStatus'] as String),
-      sinceDartSdk: json['sinceDartSdk'] as String,
-    );
-  }
+  factory LinterRule.fromJson(Map<String, dynamic> json) => LinterRule(
+    name: json['name'] as String,
+    description: json['description'] as String,
+    details: json['details'] as String,
+    categories: (json['categories'] as List).cast<String>(),
+    state: LinterRuleState._fromJson(json['state'] as String),
+    incompatible: (json['incompatible'] as List).cast<String>(),
+    sets: (json['sets'] as List).cast<String>(),
+    fixStatus: FixStatus._fromJson(json['fixStatus'] as String),
+    sinceDartSdk: json['sinceDartSdk'] as String,
+  );
 
   /// The unique name of the linter rule.
   final String name;

tool/linter_rules/lib/src/shared.dart

@@ -4,9 +4,8 @@ final Uri allLinterRulesUri = Uri.parse(
 );
 
 /// Returns the link to the documentation for the given linter [rule].
-String linterRuleLink(String rule) {
-  return 'https://dart.dev/tools/linter-rules/$rule';
-}
+String linterRuleLink(String rule) =>
+    'https://dart.dev/tools/linter-rules/$rule';
 
 /// The tag delimiting the start and end of the excluded rules table in the
 /// README.md file.