Revert "analysis updates and fixes"

This reverts commit 2acece7.

Author: tomarra

analysis_options.yaml

@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.7.0.0.yaml
+include: package:very_good_analysis/analysis_options.5.1.0.yaml
 analyzer:
   exclude:
     - "**/version.dart"

lib/src/cli/dart_cli.dart

@@ -9,7 +9,7 @@ class Dart {
     try {
       await _Cmd.run('dart', ['--version'], logger: logger);
       return true;
-    } on Exception catch (_) {
+    } catch (_) {
       return false;
     }
   }

lib/src/cli/flutter_cli.dart

@@ -124,7 +124,7 @@ class Flutter {
     try {
       await _Cmd.run('flutter', ['--version'], logger: logger);
       return true;
-    } on Exception catch (_) {
+    } catch (_) {
       return false;
     }
   }

lib/src/cli/git_cli.dart

@@ -31,7 +31,7 @@ class Git {
         ['ls-remote', '$remote', '--exit-code'],
         logger: logger,
       );
-    } on Exception catch (_) {
+    } catch (_) {
       throw UnreachableGitDependency(remote: remote);
     }
   }

lib/src/command_runner.dart

@@ -146,7 +146,7 @@ ${lightYellow.wrap('Changelog:')} ${lightCyan.wrap('https://github.com/verygoodo
 Run ${lightCyan.wrap('very_good update')} to update''',
           );
       }
-    } on Exception catch (_) {}
+    } catch (_) {}
   }
 
   void _showThankYou() {

lib/src/commands/create/commands/create_subcommand.dart

@@ -178,7 +178,7 @@ abstract class CreateSubCommand extends Command<int> {
         '''Building generator from brick: ${brick.name} ${brick.location.version}''',
       );
       return await _generatorFromBrick(brick);
-    } on Exception catch (error) {
+    } catch (error) {
       logger.detail('Building generator from brick failed: $error');
     }
     logger.detail(

lib/src/commands/packages/commands/check/commands/licenses.dart

@@ -269,7 +269,7 @@ class PackagesCheckLicensesCommand extends Command<int> {
       try {
         detectorResult =
             await detectLicense(licenseFileContent, _defaultDetectionThreshold);
-      } on Exception catch (e) {
+      } catch (e) {
         final errorMessage =
             '''[$dependencyName] Failed to detect license from $packagePath: $e''';
         if (!ignoreFailures) {
@@ -330,7 +330,7 @@ PubspecLock? _tryParsePubspecLock(File pubspecLockFile) {
     final content = pubspecLockFile.readAsStringSync();
     try {
       return PubspecLock.fromString(content);
-    } on Exception catch (_) {}
+    } catch (_) {}
   }
 
   return null;
@@ -348,7 +348,7 @@ Future<package_config.PackageConfig?> _tryFindPackageConfig(
     final findPackageConfig =
         findPackageConfigOverride ?? package_config.findPackageConfig;
     return await findPackageConfig(directory);
-  } on Exception {
+  } catch (error) {
     return null;
   }
 }

lib/src/commands/packages/commands/get.dart

@@ -61,7 +61,7 @@ class PackagesGetCommand extends Command<int> {
       } on PubspecNotFound catch (_) {
         _logger.err('Could not find a pubspec.yaml in $targetPath');
         return ExitCode.noInput.code;
-      } on Exception catch (error) {
+      } catch (error) {
         _logger.err('$error');
         return ExitCode.unavailable.code;
       }

lib/src/commands/test/test.dart

@@ -229,7 +229,7 @@ This command should be run from the root of your Flutter project.''',
           '''Expected coverage >= ${minCoverage.toStringAsFixed(decimalPlaces)}% but actual is ${e.coverage.toStringAsFixed(decimalPlaces)}%.''',
         );
         return ExitCode.unavailable.code;
-      } on Exception catch (error) {
+      } catch (error) {
         _logger.err('$error');
         return ExitCode.unavailable.code;
       }

lib/src/commands/update.dart

@@ -35,7 +35,7 @@ class UpdateCommand extends Command<int> {
     late final String latestVersion;
     try {
       latestVersion = await _pubUpdater.getLatestVersion(packageName);
-    } on Exception catch (error) {
+    } catch (error) {
       updateCheckProgress.fail();
       _logger.err('$error');
       return ExitCode.software.code;
@@ -57,7 +57,7 @@ class UpdateCommand extends Command<int> {
         packageName: packageName,
         versionConstraint: latestVersion,
       );
-    } on Exception catch (error) {
+    } catch (error) {
       updateProgress.fail();
       _logger.err('$error');
       return ExitCode.software.code;