feat: upgrade to flutter 3.35.0 (#1344)

marcossevilla · web-flow · commit 215cbdbe999a · 2025-08-25T07:21:58.000-04:00
diff --git a/.github/workflows/bump_templates.yaml b/.github/workflows/bump_templates.yaml
@@ -3,7 +3,7 @@ name: update_templates
 on:
   schedule:
     # weekly on mondays at 8 am utc
-    - cron: '0 8 * * 1'
+    - cron: "0 8 * * 1"
   workflow_dispatch:
 
 jobs:
@@ -13,6 +13,8 @@ jobs:
       - uses: actions/checkout@v5
 
       - uses: dart-lang/setup-dart@v1
+        with:
+          sdk: "3.9.0"
 
       - name: Install mason
         run: dart pub global activate mason_cli
diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -24,11 +24,6 @@ jobs:
 
     strategy:
       matrix:
-        flutter-version:
-          # The version of Flutter to use should use the minimum Dart SDK version supported by the package,
-          # refer to https://docs.flutter.dev/development/tools/sdk/releases.
-          - "3.32.0"
-          - "3.x"
         test:
           # E2E tests for the test command
           - test/commands/test/async_main/async_main_test.dart
@@ -41,9 +36,7 @@ jobs:
           - test/commands/create/dart_cli/dart_cli_test.dart
           - test/commands/create/dart_package/dart_pkg_test.dart
           - test/commands/create/docs_site/docs_site_test.dart
-          # FIXME(alestiago): Re-enable once the following issue has been solved:
-          # https://github.com/VeryGoodOpenSource/very_good_flame_game/issues/132
-          # - test/commands/create/flame_game/flame_game_test.dart
+          - test/commands/create/flame_game/flame_game_test.dart
           - test/commands/create/flutter_package/flutter_pkg_test.dart
           - test/commands/create/flutter_plugin/flutter_plugin_test.dart
 
@@ -58,7 +51,7 @@ jobs:
       - name: 🐦 Setup Flutter
         uses: subosito/flutter-action@v2
         with:
-          flutter-version: ${{ matrix.flutter-version }}
+          flutter-version: "3.35.x"
 
       - name: Install LCOV
         run: sudo apt-get install -y lcov
diff --git a/.github/workflows/pub_publish.yaml b/.github/workflows/pub_publish.yaml
@@ -16,6 +16,8 @@ jobs:
         uses: actions/checkout@v5
       - name: 🎯 Setup Dart
         uses: dart-lang/setup-dart@v1
+        with:
+          sdk: "3.9.0"
       - name: 📦 Install Dependencies
         run: dart pub get
       - name: 📢 Publish
diff --git a/.github/workflows/spdx_license.yaml b/.github/workflows/spdx_license.yaml
@@ -36,7 +36,7 @@ jobs:
       - name: 🎯 Setup Dart
         uses: dart-lang/setup-dart@v1
         with:
-          sdk: 3.8.0
+          sdk: "3.9.0"
 
       - name: 📦 Install Dependencies
         run: dart pub get
@@ -49,7 +49,7 @@ jobs:
 
       - name: 🧪 Run Tests
         run: |
-          dart pub global activate coverage 1.2.0
+          dart pub global activate coverage 1.15.0
           dart pub run test -j 4 --run-skipped --coverage=coverage --test-randomize-ordering-seed random && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on="pre_gen,post_gen"
 
       - name: 📊 Check Code Coverage
@@ -71,7 +71,7 @@ jobs:
       - name: 🎯 Setup Dart
         uses: dart-lang/setup-dart@v1
         with:
-          sdk: 3.8.0
+          sdk: "3.9.0"
 
       - name: 📦 Install Dependencies
         run: dart pub get
diff --git a/.github/workflows/spdx_license_bot.yaml b/.github/workflows/spdx_license_bot.yaml
@@ -22,6 +22,8 @@ jobs:
 
       - name: 🎯 Setup Dart
         uses: dart-lang/setup-dart@v1
+        with:
+          sdk: "3.9.0"
 
       - name: 📦 Install Dependencies
         run: dart pub get
diff --git a/.github/workflows/test_optimizer.yaml b/.github/workflows/test_optimizer.yaml
@@ -22,7 +22,7 @@ jobs:
   build_hooks:
     uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/dart_package.yml@v1
     with:
-      dart_sdk: 3.8.0
+      dart_sdk: "3.9.0"
       working_directory: bricks/test_optimizer/hooks
 
   verify_bundle:
@@ -31,6 +31,8 @@ jobs:
       - uses: actions/checkout@v5
 
       - uses: dart-lang/setup-dart@v1
+        with:
+          sdk: "3.9.0"
 
       - name: Install mason
         run: dart pub global activate mason_cli
diff --git a/.github/workflows/very_good_cli.yaml b/.github/workflows/very_good_cli.yaml
@@ -17,7 +17,7 @@ jobs:
 
       - uses: subosito/flutter-action@v2.8.0
         with:
-          flutter-version: 3.32.0
+          flutter-version: "3.35.x"
 
       - name: Install Dependencies
         run: flutter pub get
@@ -33,7 +33,7 @@ jobs:
 
       - name: Run Tests
         run: |
-          flutter pub global activate coverage 1.2.0
+          flutter pub global activate coverage 1.15.0
           flutter pub run test -j 1 -x pull-request-only -x e2e --coverage=coverage --test-randomize-ordering-seed random && dart pub global run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.dart_tool/package_config.json --report-on=lib
 
       - name: Check Code Coverage
@@ -44,4 +44,4 @@ jobs:
   pana:
     uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/pana.yml@v1
     with:
-      pana_version: 0.22.21
+      pana_version: 0.22.22
diff --git a/bricks/test_optimizer/hooks/pubspec.yaml b/bricks/test_optimizer/hooks/pubspec.yaml
@@ -2,7 +2,7 @@ name: hooks
 publish_to: none
 
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 
 dependencies:
   mason: ^0.1.0
diff --git a/e2e/pubspec.yaml b/e2e/pubspec.yaml
@@ -4,7 +4,7 @@ version: 0.1.0+1
 publish_to: none
 
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 
 dev_dependencies:
   mason: ^0.1.0
diff --git a/e2e/test/commands/test/async_main/fixture/pubspec.yaml b/e2e/test/commands/test/async_main/fixture/pubspec.yaml
@@ -4,7 +4,7 @@ version: 0.1.0+1
 publish_to: none
 
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 
 dev_dependencies:
   test: ^1.24.3
diff --git a/e2e/test/commands/test/compilation_error/fixture/pubspec.yaml b/e2e/test/commands/test/compilation_error/fixture/pubspec.yaml
@@ -3,7 +3,7 @@ version: 0.1.0+1
 publish_to: none
 
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 
 dev_dependencies:
   test: ^1.24.3
diff --git a/e2e/test/commands/test/spaced_golden_file_name/fixture/pubspec.yaml b/e2e/test/commands/test/spaced_golden_file_name/fixture/pubspec.yaml
@@ -3,7 +3,7 @@ description: Fixture for testing golden files with spaced file names.
 publish_to: none
 
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 
 dependencies:
   flutter:
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -8,7 +8,7 @@ documentation: https://cli.vgv.dev/docs/overview
 topics: [cli, codegen, test, template, boilerplate]
 
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 
 dependencies:
   args: ^2.6.0
diff --git a/test/src/commands/create/commands/dart_cli_test.dart b/test/src/commands/create/commands/dart_cli_test.dart
@@ -42,7 +42,7 @@ Run "very_good help" to see global options.''',
 const pubspec = '''
 name: example
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 ''';
 
 void main() {
diff --git a/test/src/commands/create/commands/dart_package_test.dart b/test/src/commands/create/commands/dart_package_test.dart
@@ -41,7 +41,7 @@ Run "very_good help" to see global options.''',
 const pubspec = '''
 name: example
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 ''';
 
 void main() {
diff --git a/test/src/commands/create/commands/docs_site_test.dart b/test/src/commands/create/commands/docs_site_test.dart
@@ -42,7 +42,7 @@ Run "very_good help" to see global options.''',
 const pubspec = '''
 name: example
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 ''';
 
 void main() {
diff --git a/test/src/commands/create/commands/flame_game_test.dart b/test/src/commands/create/commands/flame_game_test.dart
@@ -43,7 +43,7 @@ Run "very_good help" to see global options.''',
 const pubspec = '''
 name: example
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 ''';
 
 void main() {
diff --git a/test/src/commands/create/commands/flutter_app_test.dart b/test/src/commands/create/commands/flutter_app_test.dart
@@ -46,7 +46,7 @@ Run "very_good help" to see global options.''',
 const pubspec = '''
 name: example
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 ''';
 
 void main() {
diff --git a/test/src/commands/create/commands/flutter_package_test.dart b/test/src/commands/create/commands/flutter_package_test.dart
@@ -41,7 +41,7 @@ Run "very_good help" to see global options.''',
 const pubspec = '''
 name: example
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 ''';
 
 void main() {
diff --git a/test/src/commands/create/commands/flutter_plugin_test.dart b/test/src/commands/create/commands/flutter_plugin_test.dart
@@ -54,7 +54,7 @@ final expectedUsage = [
 const pubspec = '''
 name: example
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 ''';
 
 void main() {
diff --git a/test/src/commands/create/create_test.dart b/test/src/commands/create/create_test.dart
@@ -25,7 +25,7 @@ Run "very_good help" to see global options.''',
 const pubspec = '''
 name: example
 environment:
-  sdk: ^3.8.0
+  sdk: ^3.9.0
 ''';
 
 void main() {
diff --git a/test/src/commands/packages/commands/get_test.dart b/test/src/commands/packages/commands/get_test.dart
diff --git a/tool/spdx_license/hooks/pubspec.yaml b/tool/spdx_license/hooks/pubspec.yaml
diff --git a/tool/spdx_license/pubspec.yaml b/tool/spdx_license/pubspec.yaml
