fix: license check should exit 0 when no dependencies found

Author: felangel

lib/src/commands/packages/commands/check/commands/licenses.dart

@@ -202,10 +202,10 @@ class PackagesCheckLicensesCommand extends Command<int> {
 
     if (filteredDependencies.isEmpty) {
       progress.cancel();
-      _logger.err(
+      _logger.info(
         '''No hosted dependencies found in $targetPath of type: ${dependencyTypes.stringify()}.''',
       );
-      return ExitCode.usage.code;
+      return ExitCode.success.code;
     }
 
     final packageConfig = await _tryFindPackageConfig(targetDirectory);

test/src/commands/create/commands/flutter_plugin_test.dart

@@ -25,27 +25,27 @@ class _FakeDirectoryGeneratorTarget extends Fake
     implements DirectoryGeneratorTarget {}
 
 final expectedUsage = [
-  '''
-Generate a Very Good Flutter plugin.
-
-Usage: very_good create flutter_plugin <project-name> [arguments]
--h, --help                       Print this usage information.
--o, --output-directory           The desired output directory when creating a new project.
-    --description                The description for this new project.
-                                 (defaults to "A Very Good Project created by Very Good CLI.")
-    --org-name                   The organization for this new project.
-                                 (defaults to "com.example.verygoodcore")
-    --publishable                Whether the generated project is intended to be published.
-    --platforms                  The platforms supported by the plugin. By default, all platforms are enabled. Example: --platforms=android,ios
-
-          [android] (default)    The plugin supports the Android platform.
-          [ios] (default)        The plugin supports the iOS platform.
-          [linux] (default)      The plugin supports the Linux platform.
-          [macos] (default)      The plugin supports the macOS platform.
-          [web] (default)        The plugin supports the Web platform.
-          [windows] (default)    The plugin supports the Windows platform.
-
-Run "very_good help" to see global options.''',
+  // ignore: no_adjacent_strings_in_list
+  'Generate a Very Good Flutter plugin.\n'
+      '\n'
+      'Usage: very_good create flutter_plugin <project-name> [arguments]\n'
+      '-h, --help                       Print this usage information.\n'
+      '''-o, --output-directory           The desired output directory when creating a new project.\n'''
+      '    --description                The description for this new project.\n'
+      '''                                 (defaults to "A Very Good Project created by Very Good CLI.")\n'''
+      '''    --org-name                   The organization for this new project.\n'''
+      '''                                 (defaults to "com.example.verygoodcore")\n'''
+      '''    --publishable                Whether the generated project is intended to be published.\n'''
+      '''    --platforms                  The platforms supported by the plugin. By default, all platforms are enabled. Example: --platforms=android,ios\n'''
+      '\n'
+      '''          [android] (default)    The plugin supports the Android platform.\n'''
+      '          [ios] (default)        The plugin supports the iOS platform.\n'
+      '          [web] (default)        The plugin supports the Web platform.\n'
+      '''          [linux] (default)      The plugin supports the Linux platform.\n'''
+      '''          [macos] (default)      The plugin supports the macOS platform.\n'''
+      '''          [windows] (default)    The plugin supports the Windows platform.\n'''
+      '\n'
+      'Run "very_good help" to see global options.'
 ];
 
 const pubspec = '''

test/src/commands/packages/commands/check/commands/licenses_test.dart

@@ -36,10 +36,10 @@ const _expectedPackagesCheckLicensesUsage = [
       '''    --ignore-retrieval-failures      Disregard licenses that failed to be retrieved.\n'''
       '''    --dependency-type                The type of dependencies to check licenses for.\n'''
       '\n'
-      '''          [direct-dev]               Check for direct dev dependencies.\n'''
       '''          [direct-main] (default)    Check for direct main dependencies.\n'''
-      '''          [direct-overridden]        Check for direct overridden dependencies.\n'''
+      '''          [direct-dev]               Check for direct dev dependencies.\n'''
       '''          [transitive]               Check for transitive dependencies.\n'''
+      '''          [direct-overridden]        Check for direct overridden dependencies.\n'''
       '\n'
       '''    --allowed                        Only allow the use of certain licenses.\n'''
       '    --forbidden                      Deny the use of certain licenses.\n'
@@ -1384,13 +1384,13 @@ void main() {
               ],
             );
 
-            final errorMessage =
+            final expectedMessage =
                 '''No hosted dependencies found in ${tempDirectory.path} of type: direct-main.''';
-            verify(() => logger.err(errorMessage)).called(1);
+            verify(() => logger.info(expectedMessage)).called(1);
 
             verify(() => progress.cancel()).called(1);
 
-            expect(result, equals(ExitCode.usage.code));
+            expect(result, equals(ExitCode.success.code));
           }),
         );
       });
@@ -1466,13 +1466,13 @@ void main() {
             [...commandArguments, tempDirectory.path],
           );
 
-          final errorMessage =
+          final expectedMessage =
               '''No hosted dependencies found in ${tempDirectory.path} of type: direct-main.''';
-          verify(() => logger.err(errorMessage)).called(1);
+          verify(() => logger.info(expectedMessage)).called(1);
 
           verify(() => progress.cancel()).called(1);
 
-          expect(result, equals(ExitCode.usage.code));
+          expect(result, equals(ExitCode.success.code));
         }),
       );